v19.6.0 proposal #46455
Merged
v19.6.0 proposal #46455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the logic for handling --test-reporter out of the general module loader and into the test_runner subsystem. Backport-PR-URL: #46361 PR-URL: #45923 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #43772 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: #46046 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Since v19.2 it's not possible to use readableStreams as async iterators (confirmed bug). This patch fixes the problem by reading the Stream.Duplex property from 'streams/duplex' instead of 'streams/legacy' module Fixes: #46141 PR-URL: #46147 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This passes the strictest -Wimplicit-fallthrough setting. PR-URL: #46251 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Notable changes: - Use GetThreadTimes() on Windows for CLOCK_THREAD_CPUTIME_ID. - Increase the precision of the process and thread clocks on Windows. PR-URL: #46253 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #46267 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Update mismatched output of `events.getEventListeners` example. Plus, show output using console.log. PR-URL: #46268 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Some parameters are described as optional in spec, so update mismatched parameter. Refs: https://streams.spec.whatwg.org/ PR-URL: #46269 Refs: https://streams.spec.whatwg.org/ Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #46271 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #46274 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Refs: nodejs/build#2998 Small icu seems broken from 14.x since it uses python2. Although main no longer supports python2 landing and backporting this change to the 14.x line would allow us to simplify future backports as currently the files are the same across lines. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46263 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
`crypto_util.h` references `HMAC_CTX_free` but doesn't include the header file that contains it. PR-URL: #46279 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
All paths leading up to this UNREACHABLE either return or abort. (If they did not, the compiler would at least emit a warning.) PR-URL: #46281 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #46186 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #45735 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #45735 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Replace stoull() with strtoull(). The former throws an exception when the input is malformed, the latter doesn't. Fixes: #46223 PR-URL: #46290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #46303 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #46303 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This also improves performance to map the stack trace when the `Error.stack` is accessed. PR-URL: #46225 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Extend the Linux logic to all POSIX platforms in test-child-process-exec-abortcontroller-promisified. PR-URL: #46276 Fixes: nodejs/build#3154 Refs: #37518 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Update to @rollup/plugin-commonjs@24.0.1 and rollup@3.10.1. PR-URL: #46302 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #45966 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #46400 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #46402 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #45486 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #46406 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Otherwise there might be pending tracing fs writes which lead to a crash because the libuv threadpool is already gone. Fixes: #46376 PR-URL: #46380 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #46397 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
|
Review requested:
|
nodejs-github-bot
added
doc
ruyadorno
added a commit
that referenced
this pull request
Feb 1, 2023
ruyadorno
force-pushed
the
v19.6.0-proposal
branch
from
a61a25c to
8b59e6c
Compare
|
Looks this notable change nodejs/node@ |
thanks for the note @gengjiawen, following up in the PR! |
Notable changes: buffer: * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046 deps: * upgrade npm to 9.4.0 (npm team) #46353 esm: * leverage loaders when resolving subsequent loaders (Maël Nison) #43772 fs: * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358 src,lib: * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218 test_runner: * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712 v8: * (SEMVER-MINOR) support gc profile (theanarkh) #46255 vm: * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: #46455
ruyadorno
force-pushed
the
v19.6.0-proposal
branch
from
8b59e6c to
3ecd96f
Compare
richardlau
approved these changes
Feb 1, 2023
RafaelGSS
approved these changes
Feb 1, 2023
BethGriggs
approved these changes
Feb 1, 2023
ruyadorno
added a commit
that referenced
this pull request
Feb 2, 2023
Notable changes: buffer: * (SEMVER-MINOR) add isAscii method (Yagiz Nizipli) #46046 deps: * upgrade npm to 9.4.0 (npm team) #46353 esm: * leverage loaders when resolving subsequent loaders (Maël Nison) #43772 fs: * (SEMVER-MINOR) add statfs() functions (Colin Ihrig) #46358 src,lib: * (SEMVER-MINOR) add constrainedMemory API for process (theanarkh) #46218 test_runner: * (SEMVER-MINOR) add reporters (Moshe Atlow) #45712 v8: * (SEMVER-MINOR) support gc profile (theanarkh) #46255 vm: * (SEMVER-MINOR) expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320 PR-URL: #46455
ruyadorno
added a commit
to ruyadorno/nodejs.org
that referenced
this pull request
Feb 2, 2023
richardlau
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2023-02-02, Version 19.6.0 (Current), @ruyadorno
Notable changes
ESM: Leverage loaders when resolving subsequent loaders
Loaders now apply to subsequent loaders, for example:
--experimental-loader ts-node --experimental-loader loader-written-in-typescript.Upgrade npm to 9.4.0
Added
--install-strategy=linkedoption for installations similar to pnpm.Other notable changes
a7c9daa497] - (SEMVER-MINOR) fs: add statfs() functions (Colin Ihrig) #4635834d70ce615] - (SEMVER-MINOR) vm: expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320b4ac794923] - (SEMVER-MINOR) v8: support gc profile (theanarkh) #46255d52f60009a] - (SEMVER-MINOR) src,lib: add constrainedMemory API for process (theanarkh) #462185ad6c2088e] - (SEMVER-MINOR) buffer: add isAscii method (Yagiz Nizipli) #46046fbdc3f7316] - (SEMVER-MINOR) test_runner: add reporters (Moshe Atlow) #45712Commits
524eec70e2] - benchmark: add trailing commas (Antoine du Hamel) #46370f318a85408] - benchmark: remove buffer benchmarks redundancy (Brian White) #457356186b3ea14] - benchmark: introduce benchmark combination filtering (Brian White) #457355ad6c2088e] - (SEMVER-MINOR) buffer: add isAscii method (Yagiz Nizipli) #460468c6c4338a6] - build: export more OpenSSL symbols on Windows (Mohamed Akram) #45486d795d93901] - build: fix MSVC 2022 Release compilation (Vladimir Morozov (REDMOND)) #462288e363cf8e8] - crypto: includehmac.hincrypto_util.h(Adam Langley) #46279c1f3e13c65] - deps: update acorn to 8.8.2 (Node.js GitHub Bot) #46363813b160bd7] - deps: upgrade npm to 9.4.0 (npm team) #463539c2f3cea70] - deps: update undici to 5.15.0 (Node.js GitHub Bot) #46213312e10c1e3] - deps: update to uvwasi 0.0.15 (Colin Ihrig) #46253c7024eec16] - doc: correct thesedcommand for macOS in release process docs (Juan José) #46397996bac044b] - doc: include webstreams in finished() and Duplex.from() parameters (Debadree Chatterjee) #46312891d18d55c] - doc: pass string totextEncoder.encodeas input (Deokjin Kim) #46421968db213f8] - doc: add tip for session.post function (theanarkh) #46354a64d7f4e31] - doc: add documentation for socket.destroySoon() (Luigi Pinca) #46337975788899f] - doc: fix commit message using test instead of deps (Tony Gorez) #463131d44017f52] - doc: add v8 fast api contribution guidelines (Yagiz Nizipli) #46199e2698c05fb] - doc: fix small typo error (0xflotus) #46186f39fb8c001] - doc: mark some parameters as optional in webstreams (Deokjin Kim) #462697a9af38128] - doc: update output of example inevents.getEventListeners(Deokjin Kim) #46268729642f30b] - esm: delete preload mock test (Geoffrey Booth) #464027aac21e90a] - esm: leverage loaders when resolving subsequent loaders (Maël Nison) #43772a7c9daa497] - (SEMVER-MINOR) fs: add statfs() functions (Colin Ihrig) #463581ec6270efa] - http: res.setHeaders first implementation (Marco Ippolito) #46109d4370259e9] - inspector: allow opening inspector whenNODE_V8_COVERAGEis set (Moshe Atlow) #46113b966ef9a42] - lib: remove unnecessary ObjectGetValueSafe (Chengzhong Wu) #463352b06d66289] - lib: cache parsed source maps to reduce memory footprint (Chengzhong Wu) #46225c38673df91] - meta: update AUTHORS (Node.js GitHub Bot) #46399c10e602547] - meta: update AUTHORS (Node.js GitHub Bot) #463039dc026b14a] - meta: add .mailmap entry (Rich Trott) #463037c514574f7] - meta: move evanlucas to emeritus (Evan Lucas) #462743a3a6d87f1] - module: move test reporter loading (Geoffrey Booth) #459234ae2492a33] - readline: fix detection of carriage return (Antoine du Hamel) #4630643cad78b7a] - src: stop tracing agent before shutting down libuv (Santiago Gimeno) #46380360a3f3094] - src: get rid of fp arithmetic in ParseIPv4Host (Tobias Nießen) #46326e7b507a8cf] - src: use UNREACHABLE instead of CHECK(falsy) (Tobias Nießen) #463174c59b60ee8] - src: add support for ETW stack walking (José Dapena Paz) #46203640d111f95] - src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid (Miguel Teixeira) #46227fb7bee2b6e] - src: fix c++ exception on bad command line arg (Ben Noordhuis) #4629018c95ec4bd] - src: remove unreachable UNREACHABLE (Tobias Nießen) #4628135bf93b01a] - src: replace custom ASCII validation with simdutf one (Anna Henningsen) #462718307a4bbcd] - src: replace unreachable code with static_assert (Tobias Nießen) #462507cf0da020a] - src: use explicit C++17 fallthrough (Tobias Nießen) #46251d52f60009a] - (SEMVER-MINOR) src,lib: add constrainedMemory API for process (theanarkh) #462182e5e7a9261] - stream: remove brandchecks from stream duplexify (Debadree Chatterjee) #463159675863461] - stream: fix readable stream as async iterator function (Erick Wendel) #46147232bdd5d16] - test: add trailing commas intest/node-api(Antoine du Hamel) #463844cc081815d] - test: add trailing commas intest/message(Antoine du Hamel) #46372b83c5d9deb] - test: add trailing commas intest/pseudo-tty(Antoine du Hamel) #463718a45c9d231] - test: fix tap escaping with and without --test (Pulkit Gupta) #46311367dc41299] - test: set common.bits to 64 for loong64 (Shi Pujin) #453837385edc7d0] - test: s390x zlib test case fixes (Adam Majer) #46367d5d837bdee] - test: fix logInTimeout is not function (theanarkh) #46348a1d79546ac] - test: avoid trying to call sysctl directly (Adam Majer) #46366747f3689e0] - test: avoid left behind child processes (Richard Lau) #46276940484b7aa] - test: add failing test for readline with carriage return (Alec Mev) #46075d13116a719] - test,crypto: add CFRG curve vectors to wrap/unwrap tests (Filip Skokan) #46406398a7477b3] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #462678b473affe8] - test_runner: make built in reporters internal (Colin Ihrig) #46092a49e17e22b] - test_runner: reportfilein test runner events (Moshe Atlow) #46030fbdc3f7316] - test_runner: add reporters (Moshe Atlow) #457126579de8c47] - tools: update eslint to 8.33.0 (Node.js GitHub Bot) #46400bf62da55ad] - tools: update doc to unist-util-select@4.0.3 unist-util-visit@4.1.2 (Node.js GitHub Bot) #46364b0acf55197] - tools: update lint-md-dependencies to rollup@3.12.0 (Node.js GitHub Bot) #4639888b904cf24] - tools: require more trailing commas (Antoine du Hamel) #463464440b3ef87] - tools: update lint-md-dependencies (Node.js GitHub Bot) #46302e75faff4bd] - tools: allow icutrim.py to run on python2 (Michael Dawson) #46263e460d16d73] - url: refactor to use more primordials (Antoine du Hamel) #45966b4ac794923] - (SEMVER-MINOR) v8: support gc profile (theanarkh) #4625534d70ce615] - (SEMVER-MINOR) vm: expose cachedDataRejected for vm.compileFunction (Anna Henningsen) #46320