Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] lib: support FORCE_COLOR for non TTY streams #48682

Closed
wants to merge 1 commit into from
Closed

[v18.x backport] lib: support FORCE_COLOR for non TTY streams #48682

wants to merge 1 commit into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jul 6, 2023

PR-URL: #48034
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

@MoLow
lib: support FORCE_COLOR for non TTY streams
d7d3c0a 
PR-URL: nodejs#48034
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Jul 6, 2023
@MoLow MoLow mentioned this pull request Jul 6, 2023
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52670/

@MoLow
Copy link
Member Author

MoLow commented Jul 9, 2023

Superseded by #48684

@MoLow MoLow closed this Jul 9, 2023
@MoLow MoLow deleted the backport-force-colors branch July 9, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoLow @nodejs-github-bot