Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] test_runner: align stdout and std error with and without --test #48684

Closed
wants to merge 4 commits into from
Closed

[v18.x backport] test_runner: align stdout and std error with and without --test #48684

wants to merge 4 commits into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jul 6, 2023 •
edited
Loading

backport of #48057, #48034 and #48428

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Jul 6, 2023
@MoLow MoLow changed the title lib: support FORCE_COLOR for non TTY streams [v18.x backport] test_runner: align stdout and std error with and without --test Jul 6, 2023
@MoLow MoLow mentioned this pull request Jul 9, 2023
Closed
@MoLow MoLow force-pushed the backport-align-stdout branch 2 times, most recently from 2042910 to 1ac9c1d Compare July 9, 2023 19:20
MoLow added 4 commits July 9, 2023 22:24
@MoLow
lib: support FORCE_COLOR for non TTY streams
b23dcb9 
PR-URL: nodejs#48034
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MoLow
test_runner: pass FORCE_COLOR to child process
12bb570 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow
test_runner: dont split lines on test:stdout
d0a39ca
@MoLow
test_runner: add enqueue and dequeue events
c8cd582 
PR-URL: nodejs#48428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MoLow MoLow force-pushed the backport-align-stdout branch from 1ac9c1d to c8cd582 Compare July 9, 2023 19:26
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2023
@MoLow MoLow requested a review from danielleadams July 9, 2023 19:28
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52671/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52677/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52679/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52683/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52690/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52693/

@danielleadams
Copy link
Contributor

@MoLow does d0a39ca have a PR associated?

@MoLow
Copy link
Member Author

MoLow commented Jul 12, 2023

@MoLow does d0a39ca have a PR associated?

@danielleadams , yes. It is https://github.com/nodejs/node/pull/48057/commits which contains two commits

danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@MoLow @danielleadams
lib: support FORCE_COLOR for non TTY streams
c46b31f 
PR-URL: #48034
Backport-PR-URL: #48684
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@MoLow @danielleadams
test_runner: pass FORCE_COLOR to child process
04eb1f8 
PR-URL: #48057
Backport-PR-URL: #48684
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@MoLow @danielleadams
test_runner: dont split lines on test:stdout
d795c0a 
PR-URL: #48057
Backport-PR-URL: #48684
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@MoLow @danielleadams
test_runner: add enqueue and dequeue events
5d910ca 
PR-URL: #48428
Backport-PR-URL: #48684
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams
Copy link
Contributor

Landed in a2bfe02...5d910ca

@MoLow MoLow deleted the backport-align-stdout branch July 12, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoLow @nodejs-github-bot @danielleadams