-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade to npm 2.14.15 #4872
Conversation
will manually test tomorrow |
I may be able to slurp a fix into this that includes the relevant CI fixes -- but this still needs that quick pre-test patch to make it stop being a prerelease :( |
@zkat the CI failures appear to be unrelated... looks like windows fanned was down last night, and the single failure on arm is also a CI failure not code. I'm going to re run those two systems again ARM: https://ci.nodejs.org/job/node-test-commit-arm/1931/ WINDOWS: https://ci.nodejs.org/job/node-test-commit-windows-fanned/1115/ |
Failure on PPC for citgm is expected |
@thealphanerd Keep in mind |
Oh yeah... Womp. At least citgm tests a bunch of npm functionality
|
Also our test suite still isn't passing on Windows. That'll stay red until we're done with our current project. |
I'm trying to get the Windows CI stable, and noticed this failing.
So, |
@joaocgreis Maybe we should run npm3's dedupe on the npm2 source tree for this, that might help? |
@Fishrock123 if that works and makes the tree less deep, it should solve this. |
Usual failures with pre-release builds. None with a "release" build. LGTM. |
Please don't flatten things -- last we checked, it won't work, and this is all part of the work we're doing right now to get Windows CI stable for npm. It is, in fact, our main focus right now, so you should be seeing a green Windows soon enough. I've pushed a small patch that -should- get things working on non-windows CI again (it worked locally, so here's hoping! fingers crossed). |
@zkat If npm's LICENSE has been updated please could you keep Node's LICENSE in step? I think this will have to be done manually as the license-builder tool hasn't been backported to v4.x. |
@zkat any reason not to include 2.14.16 in this PR? It has a couple of important Windows fixes and we were hoping to get it merged into Node soon. |
@orangemocha Not to speak for @zkat, but |
LGTM on cursory scan. At least nothing significant caught my eye. |
@richardlau Ahh! Thanks for the heads up. Change is pushed. @orangemocha As @iarna said -- we have delayed releases. I'll be putting up another PR for I'm gonna go ahead and merge this once the LICENSE thing gets a +1 |
This corresponds to npm/npm@6051a69
LGTM |
This cannot land without doing something about CI, or it'll break. @zkat
isn't there any way to make the tree less deep, even if just for that
package?
|
Hi! This PR includes three releases!
Relevant changes:
6051a69
#10685 Fix npm public registry URL in notices.registry.npmjs.org
is the default, but that you're free to use the npm CLI with whatever registry you wish. This goes along with previous licensing-related improvements, too.333e118
Better AIX support for node-gypThose are the highlights! And to repeat: This does include some of the previously-talked-about licensing changes.
r: @Fishrock123
r: @iarna