-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade to npm 2.14.16 #4960
Conversation
CI: https://ci.nodejs.org/job/node-test-pull-request/1436/ It is worth mentioning the CI does not run |
Noted! If you want, |
I opened an issue nodejs/build#317 to discuss CI plans |
|
@Fishrock123 Next release (v2.14.17) will include the patch for pre-releases without cherry-picking btw. |
So I went ahead and made a CI job for npm and am doing a test run I'm expecting failures. To reduce noise I'll post updates in this comment |
@zkat this doesn't include that? I didn't modify Edit: can confirm I did indeed build the branch and instal before testing. |
@Fishrock123 Oh sorry, it wasn't clear: I included it as an extra patch cherry-picked from the last release, because it won't be included in npm itself until next week. See 24b8a5f |
LGTM |
PR-URL: nodejs#4960 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#4960 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #4960 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #4960 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Looks like these commits are on the staging branch. Closing landed in fcb8cae...9a9ac8e |
PR-URL: #4960 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #4960 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#4960 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#4960 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #4960 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #4960 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #4960 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #4960 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #4960 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #4960 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Another day, another LTS!
The changelog for this version can be found here: https://github.com/npm/npm/releases/tag/v2.14.16
Interesting changes:
24b13fb
#11158 and5c0e4c4
#10940 which include patches by @orangemocha that they had asked about in deps: upgrade to npm 2.14.15 #487264995be
75ab216
a9f6fe9
649c193
94cb05e
6541690
255be6f
9e84fa4
8a587b0
bf812a5
#10903 Get rid of nock from tests, and get Travis green, which might hopefully also make CI in general more reliable. (@zkat and @iarna)r: @Fishrock123
r: @iarna