Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: limit Buffer::kMaxLength to 1TB #49930

Closed
wants to merge 2 commits into from
Closed

src: limit Buffer::kMaxLength to 1TB #49930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12f841d
src: limit Buffer::kMaxLength to 1TB
targos Sep 28, 2023
0c15d82
fixup! src: limit Buffer::kMaxLength to 1TB
targos Sep 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/node_buffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ namespace node {

namespace Buffer {

static const size_t kMaxLength = v8::TypedArray::kMaxLength;
static constexpr size_t kMaxLength =
v8::Uint8Array::kMaxLength < 0x10000000000ull ? v8::Uint8Array::kMaxLength
: 0x10000000000ull;

typedef void (*FreeCallback)(char* data, void* hint);

Expand Down
8 changes: 5 additions & 3 deletions src/node_errors.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

#include "debug_utils-inl.h"
#include "env.h"
#include "node_buffer.h"
#include "v8.h"

// Use ostringstream to print exact-width integer types
Expand Down Expand Up @@ -216,9 +217,10 @@ inline void THROW_ERR_SCRIPT_EXECUTION_TIMEOUT(Environment* env,

inline v8::Local<v8::Value> ERR_BUFFER_TOO_LARGE(v8::Isolate* isolate) {
char message[128];
snprintf(message, sizeof(message),
"Cannot create a Buffer larger than 0x%zx bytes",
v8::TypedArray::kMaxLength);
snprintf(message,
sizeof(message),
"Cannot create a Buffer larger than 0x%zx bytes",
Buffer::kMaxLength);
return ERR_BUFFER_TOO_LARGE(isolate, message);
}

Expand Down