stream: allow pass stream class to stream.compose

[himself65]

class A extends Transform {
  // ...
}

stream.compose(A) // old behavior: A will be called as a normal function and nothing will happen

Fixes: #50176

[nodejs-github-bot]

Review requested:

• @nodejs/streams

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54804/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54834/

[koshic]

should we reflect this in the docs?

[himself65]

Hard to say, since this is for internal use and the way of init is not decently

[koshic]

It's used for public API Duplex.from, whose behavior will also be slightly changed

node/lib/internal/streams/duplex.js

Lines 142 to 147 in 356b4a2

	Duplex.from = function(body) {
	if (!duplexify) {
	duplexify = require('internal/streams/duplexify');
	}
	return duplexify(body, 'body');
	};

[himself65]

Duplex.from is still an experimental API. I will put it into doc later

[koshic]

Stable pipeline also affected

node/lib/internal/streams/pipeline.js

Lines 288 to 298 in 4032ad5

	if (typeof stream === 'function') {
	ret = stream({ signal });
	if (!isIterable(ret)) {
	throw new ERR_INVALID_RETURN_VALUE(
	'Iterable, AsyncIterable or Stream', 'source', ret);
	}
	} else if (isIterable(stream) || isReadableNodeStream(stream) || isTransformStream(stream)) {
	ret = stream;
	} else {
	ret = Duplex.from(stream);
	}

[himself65]

I will update doc later

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/50187
✔  Done loading data for nodejs/node/pull/50187
----------------------------------- PR info ------------------------------------
Title      stream: allow pass stream class to `stream.compose` (#50187)
Author     Alex Yang  (@himself65)
Branch     himself65:himself65/1014/spec -> nodejs:main
Labels     author ready, needs-ci
Commits    2
 - stream: allow pass stream class to `stream.compose`
 - fixup! fix: lint
Committers 1
 - Alex Yang 
PR-URL: https://github.com/nodejs/node/pull/50187
Fixes: https://github.com/nodejs/node/issues/50176
Reviewed-By: Moshe Atlow 
Reviewed-By: Robert Nagy 
Reviewed-By: Benjamin Gruenbaum 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50187
Fixes: https://github.com/nodejs/node/issues/50176
Reviewed-By: Moshe Atlow 
Reviewed-By: Robert Nagy 
Reviewed-By: Benjamin Gruenbaum 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 14 Oct 2023 22:05:57 GMT
   ✔  Approvals: 3
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/50187#pullrequestreview-1678677911
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/50187#pullrequestreview-1678678064
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50187#pullrequestreview-1679839150
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-10-15T19:22:34Z: https://ci.nodejs.org/job/node-test-pull-request/54834/
- Querying data for job/node-test-pull-request/54834/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 50187
From https://github.com/nodejs/node
 * branch                  refs/pull/50187/merge -> FETCH_HEAD
✔  Fetched commits as 4032ad593c0d..83cf4248107a
--------------------------------------------------------------------------------
[main 843d25cb7c] stream: allow pass stream class to `stream.compose`
 Author: Alex Yang 
 Date: Sat Oct 14 17:04:43 2023 -0500
 2 files changed, 15 insertions(+)
[main 52a91a55af] fixup! fix: lint
 Author: Alex Yang 
 Date: Sat Oct 14 17:43:19 2023 -0500
 2 files changed, 2 insertions(+), 2 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

stream: allow pass stream class to stream.compose
PR-URL: #50187

Fixes: #50176

Reviewed-By: Moshe Atlow moshe@atlow.co.il

Reviewed-By: Robert Nagy ronagy@icloud.com

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
[detached HEAD 92ba1de03d] stream: allow pass stream class to stream.compose

Author: Alex Yang himself65@outlook.com

Date: Sat Oct 14 17:04:43 2023 -0500

2 files changed, 15 insertions(+)

Rebasing (3/4)

Rebasing (4/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fixup! fix: lint
PR-URL: #50187

Fixes: #50176

Reviewed-By: Moshe Atlow moshe@atlow.co.il

Reviewed-By: Robert Nagy ronagy@icloud.com

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
[detached HEAD 81e52e6e8e] fixup! fix: lint

Author: Alex Yang himself65@outlook.com

Date: Sat Oct 14 17:43:19 2023 -0500

2 files changed, 2 insertions(+), 2 deletions(-)
Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/6539860160

[himself65]

Landed in ef7363e

[targos]

Please think about assigning the semver-minor label when you add new features.