docs: update api stream.compose
#50206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
himself65
force-pushed
the
himself65/1014/docs-update
branch
2 times, most recently
from
407468c
to
3cfa55c
Compare
himself65
force-pushed
the
himself65/1014/docs-update
branch
from
01d7a5e
to
10789bf
Compare
MoLow
approved these changes
Oct 17, 2023
Mifrill
reviewed
Oct 17, 2023
| @@ -2833,7 +2836,7 @@ changes: | |||
| > Stability: 1 - `stream.compose` is experimental. | |||
|
|
|||
| * `streams` {Stream\[]|Iterable\[]|AsyncIterable\[]|Function\[]| | |||
| ReadableStream\[]|WritableStream\[]|TransformStream\[]} | |||
| ReadableStream\[]|WritableStream\[]|TransformStream\[]|Duplex\[]|Function} | |||
There was a problem hiding this comment.
How about additionally including various types of streams such as Transform, PassThrough, FileReadStream, FileWriteStream, and Socket, allowing for more comprehensive coverage of stream types?
Suggested change
| ReadableStream\[]|WritableStream\[]|TransformStream\[]|Duplex\[]|Function} | |
| ReadableStream\[]|WritableStream\[]|TransformStream\[]|Duplex\[]|Function|Transform\[]|PassThrough\[]| FileReadStream\[]|FileWriteStream\[]|Socket\[]} |
There was a problem hiding this comment.
I think other document doesn't have such classes. Also I think current classes are top-level class, we don't need add all of the builtin class stuff
himself65
added
the
fast-track
|
Fast-track has been requested by @himself65. Please 👍 to approve. |
H4ad
approved these changes
Oct 18, 2023
H4ad
added
the
author ready
himself65
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50206 ✔ Done loading data for nodejs/node/pull/50206 ----------------------------------- PR info ------------------------------------ Title docs: update api `stream.compose` (#50206) Author Alex Yang (@himself65) Branch himself65:himself65/1014/docs-update -> nodejs:main Labels doc, stream, fast-track, author ready Commits 1 - doc: update api `stream.compose` Committers 1 - Alex Yang PR-URL: https://github.com/nodejs/node/pull/50206 Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879 Reviewed-By: Moshe Atlow Reviewed-By: Vinícius Lourenço Claro Cardoso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50206 Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879 Reviewed-By: Moshe Atlow Reviewed-By: Vinícius Lourenço Claro Cardoso -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 16 Oct 2023 22:50:21 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/50206#pullrequestreview-1682063884 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50206#pullrequestreview-1683690155 ℹ This PR is being fast-tracked ✘ This PR needs to wait 3 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6565350236 |
himself65
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50206 ✔ Done loading data for nodejs/node/pull/50206 ----------------------------------- PR info ------------------------------------ Title docs: update api `stream.compose` (#50206) Author Alex Yang (@himself65) Branch himself65:himself65/1014/docs-update -> nodejs:main Labels doc, stream, fast-track, author ready Commits 1 - doc: update api `stream.compose` Committers 1 - Alex Yang PR-URL: https://github.com/nodejs/node/pull/50206 Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879 Reviewed-By: Moshe Atlow Reviewed-By: Vinícius Lourenço Claro Cardoso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50206 Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879 Reviewed-By: Moshe Atlow Reviewed-By: Vinícius Lourenço Claro Cardoso -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 16 Oct 2023 22:50:21 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/50206#pullrequestreview-1682063884 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50206#pullrequestreview-1683690155 ℹ This PR is being fast-tracked ✘ This PR needs to wait 2 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6566227376 |
himself65
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50206 ✔ Done loading data for nodejs/node/pull/50206 ----------------------------------- PR info ------------------------------------ Title docs: update api `stream.compose` (#50206) Author Alex Yang (@himself65) Branch himself65:himself65/1014/docs-update -> nodejs:main Labels doc, stream, fast-track, author ready Commits 1 - doc: update api `stream.compose` Committers 1 - Alex Yang PR-URL: https://github.com/nodejs/node/pull/50206 Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879 Reviewed-By: Moshe Atlow Reviewed-By: Vinícius Lourenço Claro Cardoso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50206 Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879 Reviewed-By: Moshe Atlow Reviewed-By: Vinícius Lourenço Claro Cardoso -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 16 Oct 2023 22:50:21 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/50206#pullrequestreview-1682063884 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50206#pullrequestreview-1683690155 ℹ This PR is being fast-tracked ✘ This PR needs to wait 21 more minutes to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6567293855 |
himself65
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c016397 |
targos
pushed a commit
that referenced
this pull request
Oct 23, 2023
PR-URL: #50206 Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50206 Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50206 Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream: #50187
Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879