tools: remove readability/fn_size rule #54663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW it's already appearing in PRs adding to the CLI flags. |
|
ping @nodejs/build @nodejs/linting |
anonrig
approved these changes
Aug 31, 2024
anonrig
added
the
author ready
RedYetiDev
added
the
c++
|
I can attest. Got it in #53060 |
RedYetiDev
reviewed
Sep 1, 2024
| @@ -325,7 +325,6 @@ | |||
| 'readability/casting', | |||
| 'readability/check', | |||
| 'readability/constructors', | |||
| 'readability/fn_size', | |||
There was a problem hiding this comment.
IMO this should be commented out with a note as to why?
lpinca
approved these changes
Sep 1, 2024
RafaelGSS
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3d954dc |
|
Still getting the error after rebasing in #53060. It's blocking that PR from landing. @RafaelGSS May something have been missed by any chance? |
|
Weird. Does it fail locally? |
|
@RafaelGSS Yup Edit: currently running a |
RafaelGSS
added a commit
to RafaelGSS/node
that referenced
this pull request
Sep 3, 2024
|
See: #54744 |
Nice! Thanks for the quick response, that should do it👍🏼 |
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
PR-URL: #54663 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Sep 22, 2024
PR-URL: #54663 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #53927 I had to update the v22.x-staging branch to include a
// NOLINT(readability/fn_size)https://github.com/nodejs/node/blob/v22.x-staging/src/node_options.cc#L890I'm questioning whether having this rule is really necessary or beneficial. This lint didn't fail on
main(yet) because we have more code on this specific function in v22.x-staging. So, this will likely appear in a PR soon, and I think that dropping this rule instead of adding aNOLINTcomment is a much better option.