tools: remove readability/fn_size error throw #54744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
RedYetiDev
added
the
c++
lpinca
approved these changes
Sep 4, 2024
|
Not a blocker, but a question/observation: This is a patch we'll need to float on top of updates to |
|
Anything blocking this PR? It's needed for #53060 🙏🏼 |
I can try it later. If I'm reading the code correctly, they ignore the exclude filters and assume fn_size is enabled anyway. We can land this PR while I take a look at it. |
RafaelGSS
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54744 ✔ Done loading data for nodejs/node/pull/54744 ----------------------------------- PR info ------------------------------------ Title tools: remove readability/fn_size error throw (#54744) Author Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS) Branch RafaelGSS:tools-remove-fn-size-lint -> nodejs:main Labels c++, tools, fast-track, author ready Commits 1 - tools: remove readability/fn_size error throw Committers 1 - RafaelGSS <rafael.nunu@hotmail.com> PR-URL: https://github.com/nodejs/node/pull/54744 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54744 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 03 Sep 2024 19:55:43 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54744#pullrequestreview-2280422138 ℹ This PR is being fast-tracked ✘ This PR needs to wait 121 more hours to land (or 1 hours if there is one more approval) (or 0 hours if there are 2 more approvals (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10726236123 |
RafaelGSS
removed
the
commit-queue-failed
|
I looks like it's not passing the cpplint CI (cpplint/cpplint#287), I'm not sure we should land it as is. |
aduh95
removed
the
author ready
|
Can you implement cpplint/cpplint@73f2546 instead? |
Sure thing. I'll do it asap |
RafaelGSS
force-pushed
the
tools-remove-fn-size-lint
branch
from
00a2b5a
to
ec0be69
Compare
jasnell
approved these changes
Sep 7, 2024
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 46c6f8c |
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
PR-URL: #54744 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Sep 22, 2024
PR-URL: #54744 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #54663