test: exclude new fs watch test for AIX #5937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
fs
|
LGTM |
|
LGTM but s/waching/watching/ in commit log. |
|
LGTM |
As per nodejs#5085 exclude new test from AIX until we have fixes for libuv for fs watching on AIX. Excluding test so AIX tests are green and we don't miss other regressions
|
Regular CI run https://ci.nodejs.org/job/node-test-pull-request/2085/ |
|
Both CI runs green, landing |
mhdawson
added a commit
that referenced
this pull request
Mar 28, 2016
As per #5085 exclude new test from AIX until we have fixes for libuv for fs watching on AIX. Excluding test so AIX tests are green and we don't miss other regressions PR-URL: #5937 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
landed as b1c0587 |
evanlucas
pushed a commit
that referenced
this pull request
Mar 30, 2016
As per #5085 exclude new test from AIX until we have fixes for libuv for fs watching on AIX. Excluding test so AIX tests are green and we don't miss other regressions PR-URL: #5937 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas
pushed a commit
that referenced
this pull request
Mar 31, 2016
As per #5085 exclude new test from AIX until we have fixes for libuv for fs watching on AIX. Excluding test so AIX tests are green and we don't miss other regressions PR-URL: #5937 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
fs
Description of change
As per #5085
exclude new test from AIX until we have fixes for
libuv for fs watching on AIX. Excluding test
so AIX tests are green and we don't miss
other regressions