-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.10.0 Release Proposal #5970
v5.10.0 Release Proposal #5970
Conversation
@Fishrock123 I have excluded your commits for now. If you are able to get them backported in time, I'll add them to the list :] |
@evanlucas The CI failures are due to #5974, and as noted there, some tests are failing locally for me even after that fix. git bisect says it’s 18db2af (#4414), which would make sense. |
Found the buffer issue. Got a PR incoming shortly |
4d0dcaa
to
5044612
Compare
My backport is at #5975, you should be able to land anything that came after it after you merge it w/o any significant problems I think. |
b2d7b36
to
9cd6e98
Compare
citgm looks good. Will plan on getting this out later on today |
9cd6e98
to
688a07e
Compare
Notable changes: * buffer: * make byteLength work with ArrayBuffer & DataView (Jackson Tian) [#5255](#5255) * backport --zero-fill-buffers command line option (James M Snell) [#5744](#5744) * backport new buffer constructor APIs (James M Snell) [#5763](#5763) * add swap16() and swap32() methods (James M Snell) [#5724](#5724) * fs: add the fs.mkdtemp() function. (Florian MARGAINE) [#5333](#5333) * net: emit host in lookup event (HUANG Wei) [#5598](#5598) * node: --no-browser-globals configure flag (Fedor Indutny) [#5853](#5853) * npm: Upgrade to v3.8.3. Fixes a security flaw in the use of authentication tokens in HTTP requests that would allow an attacker to set up a server that could collect tokens from users of the command-line interface. Authentication tokens have previously been sent with every request made by the CLI for logged-in users, regardless of the destination of the request. This update fixes this by only including those tokens for requests made against the registry or registries used for the current install. (Forrest L Norvell) [npm#6](npm#6) * repl: support standalone blocks (Prince J Wesley) [#5581](#5581) * src: override v8 thread defaults using cli options (Tom Gallacher) [#4344](#4344)
688a07e
to
1bb2c4b
Compare
Notable changes: * buffer: * make byteLength work with ArrayBuffer & DataView (Jackson Tian) [#5255](#5255) * backport --zero-fill-buffers command line option (James M Snell) [#5744](#5744) * backport new buffer constructor APIs (James M Snell) [#5763](#5763) * add swap16() and swap32() methods (James M Snell) [#5724](#5724) * fs: add the fs.mkdtemp() function. (Florian MARGAINE) [#5333](#5333) * net: emit host in lookup event (HUANG Wei) [#5598](#5598) * node: --no-browser-globals configure flag (Fedor Indutny) [#5853](#5853) * npm: Upgrade to v3.8.3. Fixes a security flaw in the use of authentication tokens in HTTP requests that would allow an attacker to set up a server that could collect tokens from users of the command-line interface. Authentication tokens have previously been sent with every request made by the CLI for logged-in users, regardless of the destination of the request. This update fixes this by only including those tokens for requests made against the registry or registries used for the current install. (Forrest L Norvell) [npm#6](npm#6) * repl: support standalone blocks (Prince J Wesley) [#5581](#5581) * src: override v8 thread defaults using cli options (Tom Gallacher) [#4344](#4344) PR-URL: #5970
Landed in 79ea8c3 |
Notable changes:
#5255
#5744
#5763
#5724
#5333
#5598
would allow an attacker to set up a server that could collect tokens from users of the command-line interface.
Authentication tokens have previously been sent with every request made by the CLI for logged-in users,
regardless of the destination of the request. This update fixes this by only including those tokens for requests
made against the registry or registries used for the current install. (Forrest L Norvell) npm/node#6
#5581
#4344
Commits
2cbbaafca9
] - async_wrap: don't abort on callback exception (Trevor Norris) #57566f16882733
] - async_wrap: notify post if intercepted exception (Trevor Norris) #5756a4856122d3
] - async_wrap: setupHooks now accepts object (Trevor Norris) #5756ee83c956c5
] - (SEMVER-MINOR) buffer: make byteLength work with ArrayBuffer & DataView (Jackson Tian) #52551f8e4b54ce
] - (SEMVER-MINOR) buffer: add swap16() and swap32() methods (James M Snell) #5724bdf933bece
] - buffer: changing let in for loops back to var (Gareth Ellis) #5819c1534e7eaf
] - (SEMVER-MINOR) buffer: backport new buffer constructor APIs (James M Snell) #57633c02727055
] - (SEMVER-MINOR) buffer: backport --zero-fill-buffers command line option (James M Snell) #574458b5c1e19f
] - build: add suport for x86 architecture (Robert Chiras) #5544389f5a85e6
] - build: add script to create Android .mk files (Robert Chiras) #55445ee5fa292f
] - build: add missingopenssl_fips%
to common.gypi (Fedor Indutny) #59195681ffecf7
] - build: enable compilation for linuxOne (Michael Dawson) #5941660ec9f889
] - child_process: refactor self=this in socket_list (Benjamin Gruenbaum) #5860e1a012f277
] - deps: upgrade npm to 3.8.3 (Forrest L Norvell)ec1813199d
] - deps: backport 8d00c2c from v8 upstream (Ben Noordhuis) #55772a5c6d7006
] - dns: Refactor forEach to map (Benjamin Gruenbaum) #58036a6112a2f3
] - dns: Use object without protoype for map (Benjamin Gruenbaum) #58438fa0b5c1da
] - doc: Add @mhdawson back to the CTC (James M Snell) #5633858a524325
] - doc: typo: interal->internal. (Corey Kosak) #58495676a35bd9
] - doc: explain path.format expected properties (John Eversole) #580129778393a0
] - doc: use consistent event name parameter (Benjamin Gruenbaum) #5850949b17ff6d
] - doc: fix order of end tags of list after heading (firedfox) #58748e790b7a0c
] - doc: add instructions to only sign a release (Jeremiah Senkpiel) #5876f1f9aff855
] - doc: fix doc for Buffer.readInt32LE() (ghaiklor) #5890731f7b8055
] - etw: fix descriptors of events 9 and 23 (João Reis) #5742aac9ead379
] - etw,build: always generate .rc and .h files (João Reis) #565780155d398c
] - (SEMVER-MINOR) fs: add the fs.mkdtemp() function. (Florian MARGAINE) #5333ae15d68ad1
] - governance: remove target size for CTC (Rich Trott) #587963c601bc15
] - http: speed up checkIsHttpToken (Jackson Tian) #479040847b0b8b
] - lib: rename /node.js to /bootstrap_node.js (Jeremiah Senkpiel) #5103e644eb3d69
] - lib: refactor code with startsWith/endsWith (Jackson Tian) #5753a757e0583c
] - lib,src: move src/node.js to lib/internal/node.js (Jeremiah Senkpiel) #5103e3c7b46326
] - lib,src: refactor src/node.js into internal files (Jeremiah Senkpiel) #5103b07bc5d996
] - (SEMVER-MINOR) net: emit host in lookup event (HUANG Wei) #55982fa959be15
] - (SEMVER-MINOR) node: --no-browser-globals configure flag (Fedor Indutny) #5853a2ad21645f
] - querystring: don't stringify bad surrogate pair (Brian White) #5858427173204e
] - (SEMVER-MINOR) repl: support standalone blocks (Prince J Wesley) #5581d044898495
] - src: Add missingusing v8::MaybeLocal
(Anna Henningsen) #59740d0c57ff5e
] - (SEMVER-MINOR) src: override v8 thread defaults using cli options (Tom Gallacher) #4344f9d0166291
] - src: reword command and add ternary (Trevor Norris) #5756f1488bb24c
] - src,http_parser: remove KickNextTick call (Trevor Norris) #57568e8768ecbb
] - test: add known_issues test for stdout/stderr buffering with TTY #2148 (Rich Trott) #5920bf94b5a1b9
] - test: mitigate flaky test-https-agent (Rich Trott) #59392192528326
] - test: fix flaky test-repl (Brian White) #5914aebe6245b7
] - test: add test for piping large input from stdin (Anna Henningsen) #5949a19de97d2f
] - test: remove the use of curl in the test suite (Santiago Gimeno) #57506928a17aa3
] - test: exclude new fs watch test for AIX (Michael Dawson) #59373238bff3b3
] - test: confirm globals not used internally (Rich Trott) #5882a41fd93f68
] - test: fix flaky test-net-socket-timeout (Brian White) #590282a50d3def
] - test: move dns test to test/internet (Ben Noordhuis) #5905fb0c5bcac2
] - test: fix flaky test-http-set-timeout (Rich Trott) #58568344a522a8
] - test: fix test-debugger-client.js (Rich Trott) #58517ec5397954
] - timers: fixing API refs to use safe internal refs (Kyle Simpson) #5882cb676cf3e7
] - tools: fix json doc generation (firedfox) #594377bed269ad
] - win,build: build and test add-ons on test-ci (Bogdan Lobor) #5886afcd276ecc
] - zlib: Fix handling of gzip magic bytes mid-file (Anna Henningsen) #5863