Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: guard against overflow in ParseArrayIndex() #7497

Merged
merged 2 commits into from
Jul 6, 2016
Merged

src: guard against overflow in ParseArrayIndex() #7497

merged 2 commits into from
Jul 6, 2016

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Jun 30, 2016 •
edited
Loading

ParseArrayIndex() would wrap around large (>=2^32) index values on
platforms where sizeof(int64_t) > sizeof(size_t). Ensure that the
return value fits in a size_t.

CI: https://ci.nodejs.org/job/node-test-pull-request/3139/

@bnoordhuis bnoordhuis added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jun 30, 2016
@addaleax
Copy link
Member

LGTM with CI

@cjihrig
Copy link
Contributor

cjihrig commented Jun 30, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Jun 30, 2016

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Jul 5, 2016

Looks like the CI came back green.

bnoordhuis added 2 commits July 6, 2016 16:29
@bnoordhuis
src: move ParseArrayIndex() to src/node_buffer.cc
6ae2043 
It's not used anywhere else so move it out of src/node_internals.h.

PR-URL: nodejs#7497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis
src: guard against overflow in ParseArrayIndex()
630096b 
ParseArrayIndex() would wrap around large (>=2^32) index values on
platforms where sizeof(int64_t) > sizeof(size_t).  Ensure that the
return value fits in a size_t.

PR-URL: nodejs#7497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis bnoordhuis force-pushed the fix-array-index-overflow branch from a7a0b60 to 630096b Compare July 6, 2016 14:33
@bnoordhuis bnoordhuis closed this Jul 6, 2016
@bnoordhuis bnoordhuis deleted the fix-array-index-overflow branch July 6, 2016 14:33
@bnoordhuis bnoordhuis merged commit 630096b into nodejs:master Jul 6, 2016
@cjihrig cjihrig mentioned this pull request Jul 12, 2016
Merged
2 tasks
@cjihrig cjihrig mentioned this pull request Aug 8, 2016
Closed
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
@bnoordhuis @cjihrig
src: move ParseArrayIndex() to src/node_buffer.cc
c730a5d 
It's not used anywhere else so move it out of src/node_internals.h.

PR-URL: #7497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Conflicts:
	src/node_internals.h
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
@bnoordhuis @cjihrig
src: guard against overflow in ParseArrayIndex()
f3e5b39 
ParseArrayIndex() would wrap around large (>=2^32) index values on
platforms where sizeof(int64_t) > sizeof(size_t).  Ensure that the
return value fits in a size_t.

PR-URL: #7497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
Merged
@MylesBorins
Copy link
Contributor

@bnoordhuis this is not landing cleanly, would you be willing to backport

@bnoordhuis bnoordhuis mentioned this pull request Sep 5, 2016
Closed
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Oct 19, 2016
@bnoordhuis
src: move ParseArrayIndex() to src/node_buffer.cc
31ea3a5 
It's not used anywhere else so move it out of src/node_internals.h.

PR-URL: nodejs#7497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Oct 19, 2016
@bnoordhuis
src: guard against overflow in ParseArrayIndex()
6e62d9f 
ParseArrayIndex() would wrap around large (>=2^32) index values on
platforms where sizeof(int64_t) > sizeof(size_t).  Ensure that the
return value fits in a size_t.

PR-URL: nodejs#7497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 24, 2016
@bnoordhuis @MylesBorins
src: move ParseArrayIndex() to src/node_buffer.cc
29412e0 
It's not used anywhere else so move it out of src/node_internals.h.

PR-URL: #7497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 24, 2016
@bnoordhuis @MylesBorins
src: guard against overflow in ParseArrayIndex()
2148128 
ParseArrayIndex() would wrap around large (>=2^32) index values on
platforms where sizeof(int64_t) > sizeof(size_t).  Ensure that the
return value fits in a size_t.

PR-URL: #7497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@bnoordhuis @MylesBorins
src: move ParseArrayIndex() to src/node_buffer.cc
e1f961d 
It's not used anywhere else so move it out of src/node_internals.h.

PR-URL: #7497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@bnoordhuis @MylesBorins
src: guard against overflow in ParseArrayIndex()
6ba3ad5 
ParseArrayIndex() would wrap around large (>=2^32) index values on
platforms where sizeof(int64_t) > sizeof(size_t).  Ensure that the
return value fits in a size_t.

PR-URL: #7497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bnoordhuis @addaleax @cjihrig @jasnell @MylesBorins