src: suppress coverity message #7587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
|
LGTM |
| @@ -209,6 +209,8 @@ inline MUST_USE_RESULT bool ParseArrayIndex(Local<Value> arg, | |||
|
|
|||
| // Check that the result fits in a size_t. | |||
| const uint64_t kSizeMax = static_cast<uint64_t>(static_cast<size_t>(-1)); | |||
| // Tell coverity that this is not a constant expression on all platforms. | |||
There was a problem hiding this comment.
It is a constant expression, however. I'd just leave out the comment, it's clear enough from context that we're trying to shut up coverity.
|
LGTM with or without the comment |
|
LGTM |
Coverity marked a change in 630096b as a constant expression. However, on platforms where sizeof(int64_t) > sizeof(size_t), this should not be the case. This commit flags the comparison as OK to coverity. PR-URL: nodejs#7587 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in 18ae74c without the extra comment. |
|
@cjihrig lts? |
|
Yes please. |
|
@cjihrig this does not land cleanly and will require a manual backport if you are up for it |
|
This should apply cleanly once #7497 is backported. If that's not the case, let me know. |
cjihrig
added a commit
that referenced
this pull request
Aug 10, 2016
Coverity marked a change in 630096b as a constant expression. However, on platforms where sizeof(int64_t) > sizeof(size_t), this should not be the case. This commit flags the comparison as OK to coverity. PR-URL: #7587 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
bnoordhuis
pushed a commit
to bnoordhuis/io.js
that referenced
this pull request
Oct 19, 2016
Coverity marked a change in 630096b as a constant expression. However, on platforms where sizeof(int64_t) > sizeof(size_t), this should not be the case. This commit flags the comparison as OK to coverity. PR-URL: nodejs#7587 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 24, 2016
Coverity marked a change in 630096b as a constant expression. However, on platforms where sizeof(int64_t) > sizeof(size_t), this should not be the case. This commit flags the comparison as OK to coverity. PR-URL: #7587 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Coverity marked a change in 630096b as a constant expression. However, on platforms where sizeof(int64_t) > sizeof(size_t), this should not be the case. This commit flags the comparison as OK to coverity. PR-URL: #7587 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
src
Description of change
Coverity marked a change in 630096b as a constant expression. However, on platforms where
sizeof(int64_t) > sizeof(size_t), this should not be the case. This commit flags the comparisonas OK to coverity.
Disclaimer: I have no idea how to test this with coverity. I put this together based on existing code in core and some Googling.
R= @bnoordhuis