test: increase _debugger coverage #8403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The uncaught exception test for `_debugger.js` was not exercising some code (particularly concerning `interface_.child`) because of the synchronous nature of the test. This adds an asynchronous version to increase test coverage.
|
CI is green (except for perma-yellow AIX). |
|
@nodejs/testing @indutny |
|
|
||
| assert.doesNotThrow(emit); | ||
|
|
||
| debug.start(['sterrance']); |
There was a problem hiding this comment.
That's sending debug.start() an argv array of length 1 to avoid code that exits if argv is empty.
I'll add a comment and/or change sterrance to a more meaningful string.
|
LGTM |
|
LGTM with nits addressed. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Sep 7, 2016
The uncaught exception test for `_debugger.js` was not exercising some code (particularly concerning `interface_.child`) because of the synchronous nature of the test. This adds an asynchronous version to increase test coverage. PR-URL: nodejs#8403 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 801115d |
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
The uncaught exception test for `_debugger.js` was not exercising some code (particularly concerning `interface_.child`) because of the synchronous nature of the test. This adds an asynchronous version to increase test coverage. PR-URL: #8403 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
seeing failures with this being backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test debugger
Description of change
The uncaught exception test for
_debugger.jswas not exercising somecode (particularly concerning
interface_.child) because of thesynchronous nature of the test. This adds an asynchronous version to
increase test coverage.