Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase _debugger coverage #8403

Closed
wants to merge 2 commits into from
Closed

test: increase _debugger coverage #8403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e07a397
test: increase _debugger coverage
Trott Sep 4, 2016
a450ba2
squash: setImmediate() will do just fine
Trott Sep 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions test/fixtures/debug-uncaught-async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'use strict';

require('../common');
const assert = require('assert');
const debug = require('_debugger');

function emit() {
const error = new Error('fhqwhgads');
process.emit('uncaughtException', error);
}

assert.doesNotThrow(emit);

debug.start(['sterrance']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wut?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's sending debug.start() an argv array of length 1 to avoid code that exits if argv is empty.

I'll add a comment and/or change sterrance to a more meaningful string.


setImmediate(emit);
22 changes: 22 additions & 0 deletions test/parallel/test-debug-uncaught-exception-async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const path = require('path');
const spawn = require('child_process').spawn;

const emitUncaught = path.join(common.fixturesDir, 'debug-uncaught-async.js');
const result = spawn(process.execPath, [emitUncaught], {encoding: 'utf8'});

var stderr = '';
result.stderr.on('data', (data) => {
stderr += data;
});

result.on('close', (code) => {
const expectedMessage =
"There was an internal error in Node's debugger. Please report this bug.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single quotes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used double-quotes to avoid escaping the apostrophe in Node's. (The linter allows for double-quotes if it avoids escaping a ' character.) I can switch to single-quotes if that's deemed an inadequate reason to use double-quotes.


assert.strictEqual(code, 1);
assert(stderr.includes(expectedMessage));
assert(stderr.includes('Error: fhqwhgads'));
});