Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(zh-cn): translate about/index.md && index.md - banner into Chinese #1590

Closed
wants to merge 3 commits into from

Conversation

QC-L
Copy link
Contributor

@QC-L QC-L commented Mar 13, 2018

No description provided.

@fhemberger
Copy link
Contributor

You can remove untranslated pages from locale/zh-cn/site.json, maybe better then copying the English version.

/cc @nodejs/nodejs-cn

@QC-L
Copy link
Contributor Author

QC-L commented Mar 13, 2018

I will complete all pages as soon as possible.

@fhinkel
Copy link
Member

fhinkel commented May 29, 2018

ping @QC-L

@QC-L
Copy link
Contributor Author

QC-L commented May 30, 2018

@fhinkel Recently there was a problem at home and I will finish it soon.

@@ -1,7 +1,7 @@
---
layout: index.hbs
labels:
banner: 重要的安全版本,请立即更新!
banner: 崩溃和幽灵(漏洞) - 对Node.js的影响
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use English original for those two security issues, since people are more familiar with its English name. Good to me for current translated content, and keep it going.

@fhemberger
Copy link
Contributor

@QC-L There has been quite some localization activity lately. Do you need some help with the translations or can we split things up so it's easier to handle?

@laosb
Copy link

laosb commented Jun 16, 2018

It would be better to split this PR into few PRs and abandon those currently untranslated content. If no one works on this PR, I will try to tackle this. Post-semester Todolist Added.

@ghost
Copy link

ghost commented Jun 19, 2018

#1701, all translated, submitted and changed.
#1713, all translated, submitted and changed.

@ghost
Copy link

ghost commented Jul 6, 2018

local\zh-CN\about is now translated

@QC-L QC-L closed this Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants