-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add SidebarItem, sideBarGroup and sideBar components #6065
feat: Add SidebarItem, sideBarGroup and sideBar components #6065
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: canerakdas <canerakdas@gmail.com> Signed-off-by: manikanta mavireddy <56877683+manikantamavireddy@users.noreply.github.com>
Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Signed-off-by: manikanta mavireddy <56877683+manikantamavireddy@users.noreply.github.com>
Co-authored-by: canerakdas <canerakdas@gmail.com> Signed-off-by: manikanta mavireddy <56877683+manikantamavireddy@users.noreply.github.com>
Co-authored-by: canerakdas <canerakdas@gmail.com> Signed-off-by: manikanta mavireddy <56877683+manikantamavireddy@users.noreply.github.com>
Co-authored-by: canerakdas <canerakdas@gmail.com> Signed-off-by: manikanta mavireddy <56877683+manikantamavireddy@users.noreply.github.com>
Co-authored-by: canerakdas <canerakdas@gmail.com> Signed-off-by: manikanta mavireddy <56877683+manikantamavireddy@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Hey @canerakdas I have updated my code as per your suggestions could you be more specific about what styling changes that are required |
I'm neutral. The Hook today is something we want to get rid of, since we want to get rid of the |
Co-authored-by: canerakdas <canerakdas@gmail.com> Signed-off-by: manikanta mavireddy <56877683+manikantamavireddy@users.noreply.github.com>
Co-authored-by: canerakdas <canerakdas@gmail.com> Signed-off-by: manikanta mavireddy <56877683+manikantamavireddy@users.noreply.github.com>
Co-authored-by: canerakdas <canerakdas@gmail.com> Signed-off-by: manikanta mavireddy <56877683+manikantamavireddy@users.noreply.github.com>
Co-authored-by: canerakdas <canerakdas@gmail.com> Signed-off-by: manikanta mavireddy <56877683+manikantamavireddy@users.noreply.github.com>
Co-authored-by: canerakdas <canerakdas@gmail.com> Signed-off-by: manikanta mavireddy <56877683+manikantamavireddy@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manikantamavireddy there are some small lints to clean up and then i think this is ready |
nice work @manikantamavireddy thanks for your contribution! |
Description
Validation
Related Issues
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.