fix: response error interceptor (#3930)

nodejs · Dec 8, 2024 · 503ad76 · 503ad76
1 parent 03edf68
commit 503ad76
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/lib/interceptor/response-error.js b/lib/interceptor/response-error.js
@@ -81,8 +81,8 @@ class ResponseErrorHandler extends DecoratorHandler {
     }
   }
 
-  onResponseError (err) {
-    super.onResponseError(err)
+  onResponseError (controller, err) {
+    super.onResponseError(controller, err)
   }
 }
 

diff --git a/test/interceptors/response-error.js b/test/interceptors/response-error.js
@@ -168,3 +168,28 @@ test('should throw error for error response, parsing JSON without charset', asyn
     message: 'Bad Request'
   })
 })
+
+test('should throw error for networking errors response', async () => {
+  const client = new Client(
+    'http://localhost:12345'
+  ).compose(responseError())
+
+  after(async () => {
+    await client.close()
+  })
+
+  let error
+  try {
+    await client.request({
+      method: 'GET',
+      path: '/',
+      headers: {
+        'content-type': 'text/plain'
+      }
+    })
+  } catch (err) {
+    error = err
+  }
+
+  assert.equal(error.code, 'ECONNREFUSED')
+})