Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: response error interceptor #3930

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

Gigioliva
Copy link
Contributor

@Gigioliva Gigioliva commented Dec 7, 2024

Fix response error interceptor

Rationale

This this issue

Changes

Use the correct method signature.

Status

@Gigioliva
Copy link
Contributor Author

Tests are failing for something not related to my PR 🤷🏼‍♂️ Also in main they fail

@mcollina
Copy link
Member

mcollina commented Dec 8, 2024

Can you please rebase/update this branch?

@Gigioliva Gigioliva force-pushed the fix/response-error-interceptor branch from 1195d1f to 1f8e98a Compare December 8, 2024 09:49
@Gigioliva
Copy link
Contributor Author

Can you please rebase/update this branch?

Done... but still there are some flaky tests

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 503ad76 into nodejs:main Dec 8, 2024
30 of 31 checks passed
This was referenced Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants