Merge pull request #634 from nodenv/lts-script

Work on LTS linting scripts

.github/workflows/fix-lts.yml

@@ -5,7 +5,6 @@ on:
 
 jobs:
   fix:
-    if: github.event_name == 'schedule'
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
@@ -15,11 +14,11 @@ jobs:
       uses: peter-evans/create-pull-request@v3
       with:
         token: ${{ secrets.BOT_TOKEN }}
+        committer: 'nodenv bot <jason.karns+nodenv@github.com>'
+        commit-message: 'Add LTS warning messages'
         branch: lts-warning-message
-        title: 'Update warning messages per LTS Schedule'
+        title: 'Adds/Updates LTS warning messages'
         body: |-
           [![node lts schedule](https://raw.githubusercontent.com/nodejs/Release/master/schedule.svg)](https://github.com/nodejs/Release)
 
           > Automated changes by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action
-        committer: 'nodenv bot <jason.karns+nodenv@github.com>'
-        commit-message: 'Prepend warning message per LTS schedule'

.github/workflows/lint-checksums.yml → .github/workflows/lint.yml

@@ -1,9 +1,16 @@
-name: Lint Checksums
+name: Lint Definitions
 on:
   pull_request: { paths: 'share/node-build/**' }
 
 jobs:
-  lint:
+  lts:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - run: npm ci
+    - run: npm run lint:lts
+
+  checksums:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2

.github/workflows/scrape-definitions.yml

@@ -10,6 +10,8 @@ jobs:
     - uses: actions/checkout@v2
     - run: npm ci
     - run: npm run scrape-definitions
+    - run: npm run lint:lts -- --fix
+      continue-on-error: true
     - run: npm run commit-definitions
       env:
         GIT_AUTHOR_NAME: 'nodenv bot'

package.json

@@ -32,12 +32,12 @@
     "clean": "git clean -f -- share",
     "start": "bin/node-build",
     "scrape-definitions": "nodenv-update-version-defs --nodejs --chakracore --graal -d share/node-build/",
-    "commit-definitions": "npm explore @nodenv/node-build-update-defs -- npm run defs:commit",
-    "submit-definitions": "npm explore @nodenv/node-build-update-defs -- npm run defs:submit",
+    "commit-definitions": "npm explore @nodenv/node-build-update-defs -- npm run defs:commit --",
+    "submit-definitions": "npm explore @nodenv/node-build-update-defs -- npm run defs:submit --",
     "test": "bats ${CI:+--tap} test",
     "lint": "git ls-files bin script **/*.*sh | xargs shellcheck",
-    "lint:lts": "script/lint/lts",
-    "lint:checksums": "npm explore @nodenv/node-build-update-defs -- npm run defs:verify",
+    "lint:lts": "npm explore @nodenv/node-build-update-defs -- npm run defs:lint:lts -- \"$PWD/share/node-build\"",
+    "lint:checksums": "npm explore @nodenv/node-build-update-defs -- npm run defs:verify --",
     "preversion": "script/preversion",
     "version": "script/version-sync",
     "postversion": "git push --follow-tags",
@@ -46,7 +46,7 @@
   },
   "devDependencies": {
     "@nodenv/devutil": "^0.1.1",
-    "@nodenv/node-build-update-defs": "^2.10.0",
+    "@nodenv/node-build-update-defs": "^2.11.0",
     "bats": "^1.1.0",
     "bats-assert": "jasonkarns/bats-assert-1",
     "bats-mock": "^1.0.1",