Work on LTS linting scripts #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jasonkarns
commented
Jul 27, 2020
•
jasonkarns
commented
- moves lts lint script to node-build-update-defs
- combines lts and checksum lint workflows
- auto-lint (with fixing) the warning messages after scraping (this may cause issues if there are other lint fixes other than the new definitions just created)
The old LTS linter also ran on pushes to master. But since the checksum linter can _only_ run on PRs (requires base_ref property), it's easier to just skip master pushes. This is fine because the scheduled linter (with fixing!) already runs regularly from master anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.