Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on LTS linting scripts #634

Merged
merged 6 commits into from
Jul 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/fix-lts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ on:

jobs:
fix:
if: github.event_name == 'schedule'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -15,11 +14,11 @@ jobs:
uses: peter-evans/create-pull-request@v3
with:
token: ${{ secrets.BOT_TOKEN }}
committer: 'nodenv bot <jason.karns+nodenv@github.com>'
commit-message: 'Add LTS warning messages'
branch: lts-warning-message
title: 'Update warning messages per LTS Schedule'
title: 'Adds/Updates LTS warning messages'
body: |-
[![node lts schedule](https://raw.githubusercontent.com/nodejs/Release/master/schedule.svg)](https://github.com/nodejs/Release)
> Automated changes by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action
committer: 'nodenv bot <jason.karns+nodenv@github.com>'
commit-message: 'Prepend warning message per LTS schedule'
12 changes: 0 additions & 12 deletions .github/workflows/lint-lts.yml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
name: Lint Checksums
name: Lint Definitions
on:
pull_request: { paths: 'share/node-build/**' }

jobs:
lint:
lts:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- run: npm ci
- run: npm run lint:lts

checksums:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/scrape-definitions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ jobs:
- uses: actions/checkout@v2
- run: npm ci
- run: npm run scrape-definitions
- run: npm run lint:lts -- --fix
continue-on-error: true
- run: npm run commit-definitions
env:
GIT_AUTHOR_NAME: 'nodenv bot'
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@
"clean": "git clean -f -- share",
"start": "bin/node-build",
"scrape-definitions": "nodenv-update-version-defs --nodejs --chakracore --graal -d share/node-build/",
"commit-definitions": "npm explore @nodenv/node-build-update-defs -- npm run defs:commit",
"submit-definitions": "npm explore @nodenv/node-build-update-defs -- npm run defs:submit",
"commit-definitions": "npm explore @nodenv/node-build-update-defs -- npm run defs:commit --",
"submit-definitions": "npm explore @nodenv/node-build-update-defs -- npm run defs:submit --",
"test": "bats ${CI:+--tap} test",
"lint": "git ls-files bin script **/*.*sh | xargs shellcheck",
"lint:lts": "script/lint/lts",
"lint:checksums": "npm explore @nodenv/node-build-update-defs -- npm run defs:verify",
"lint:lts": "npm explore @nodenv/node-build-update-defs -- npm run defs:lint:lts -- \"$PWD/share/node-build\"",
"lint:checksums": "npm explore @nodenv/node-build-update-defs -- npm run defs:verify --",
"preversion": "script/preversion",
"version": "script/version-sync",
"postversion": "git push --follow-tags",
Expand All @@ -46,7 +46,7 @@
},
"devDependencies": {
"@nodenv/devutil": "^0.1.1",
"@nodenv/node-build-update-defs": "^2.10.0",
"@nodenv/node-build-update-defs": "^2.11.0",
"bats": "^1.1.0",
"bats-assert": "jasonkarns/bats-assert-1",
"bats-mock": "^1.0.1",
Expand Down
127 changes: 0 additions & 127 deletions script/lint/lts

This file was deleted.