fix: killing the process hangs issue #169
Conversation
Codecov ReportBase: 92.36% // Head: 92.36% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
=======================================
Coverage 92.36% 92.36%
=======================================
Files 9 9
Lines 262 262
=======================================
Hits 242 242
Misses 20 20 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Steps to reproduce:
|
|
Video: foo-2023-02-04_09.37.53.mp4 |
|
After merge the changes from main branch I started to see this in CI
I'm using Node 18 maybe is this something related to package-lock.json ? |
helio-frota
force-pushed
the
replace-death
branch
from
1fb7230 to
14edff9
Compare
Changed to node 16x , deleted and re-generated |
|
@lance was there a reason for choosing the |
Nothing other than, "it seems to work as expected" 🤣 |
| @@ -40,7 +40,7 @@ async function runServer(file) { | |||
| console.error(code); | |||
| throw TypeError(`Cannot find Invokable function 'handle' in ${code}`); | |||
| } | |||
| ON_DEATH(_ => { | |||
| nodeCleanup(_ => { | |||
| server.close(); | |||
There was a problem hiding this comment.
I think the only thing that needs to be added is a process.exit(0) after the server.close instead of changing the module.
There was a problem hiding this comment.
@helio-frota can you give this a try in your test scenario?
There was a problem hiding this comment.
@lholmquist @lance that works thanks!
There was a problem hiding this comment.
interesting it has a little bit different behavior we need 2 control+c but works.. [ maybe a delay thing happening don't know ]
I saw that other node.js tools also need 2 control+c , sometimes
|
PR sent #172 |
Related to #120