Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add process.exit(0) in ON_DEATH hook #172

Merged
merged 1 commit into from
Feb 14, 2023
Merged

fix: add process.exit(0) in ON_DEATH hook #172

merged 1 commit into from
Feb 14, 2023

Conversation

helio-frota
Copy link
Member

@helio-frota helio-frota commented Feb 14, 2023 •
edited by lance
Loading

Ensure quick shutdown when browsers are holding open a connection.

Fixes: #120

@helio-frota helio-frota mentioned this pull request Feb 14, 2023
Closed
@lance lance changed the title fix: killing the process hangs issue fix: add process.exit(0) in ON_DEATH hook Feb 14, 2023
@lance
Copy link
Member

lance commented Feb 14, 2023

Thanks @helio-frota !

@lance lance merged commit 3ac8b9d into nodeshift:main Feb 14, 2023
@helio-frota helio-frota deleted the add-process-exit branch February 14, 2023 18:03
@github-actions github-actions bot mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lholmquist lholmquist lholmquist approved these changes

@lance lance Awaiting requested review from lance

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Killing the process hangs after a browser request
3 participants
@helio-frota @lance @lholmquist