fix: disabled breaker emits fire events #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To revert to previous behaviour up to v8.1.4. nodeshift#894
|
can you add a test that makes sure to test this behaviour? |
Pull Request Test Coverage Report for Build 11554823158Details
💛 - Coveralls |
|
I noticed this was a Draft, it looks good, was there something else you wanted to add, or just hit the wrong button :) |
Couldn't change the state before (missing privileges) - ready for review! |
lholmquist
approved these changes
Oct 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To revert to previous behaviour up to v8.1.4.
#894