Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for 8.20.0 #896

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

daan944
Copy link
Contributor

@daan944 daan944 commented Oct 25, 2024

Bugfix: coalesce re-used empty cachekey when cache was not used.
Bugfix: emit fire when circuitbreaker is disabled.

Bugfix: emit fire when circuitbreaker is disabled.
@coveralls
Copy link

coveralls commented Oct 25, 2024

Pull Request Test Coverage Report for Build 11555588227

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 98.328%

Totals Coverage Status
Change from base Build 11555340370: 0.007%
Covered Lines: 401
Relevant Lines: 402

💛 - Coveralls

@lholmquist
Copy link
Member

We just merged #895 which fixes that fire issue. could you remove that part from this PR and just make this PR resolve the "Bugfix: coalesce re-used empty cachekey when cache was not used."?

@daan944
Copy link
Contributor Author

daan944 commented Oct 28, 2024

Of course!

@lholmquist lholmquist merged commit cac798c into nodeshift:main Oct 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants