Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

feat!: update to acvm with non-homogeneous bb calls #169

Merged
merged 4 commits into from
May 11, 2023

Conversation

sirasistant
Copy link
Contributor

related to noir-lang/acvm#269

@phated
Copy link
Contributor

phated commented May 9, 2023

@sirasistant This is a duplicate of c19f184, right? Nvm, I see the changes that you are adding on now.

@sirasistant sirasistant changed the title feat!: update to acvm with non-homogeneous bb calls DO NOT MERGE feat!: update to acvm with non-homogeneous bb calls May 11, 2023
@sirasistant sirasistant marked this pull request as ready for review May 11, 2023 09:43
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit about a missing assertion.

src/barretenberg_structures.rs Show resolved Hide resolved
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
@sirasistant sirasistant merged commit 947c413 into acvm-0.12.0 May 11, 2023
@sirasistant sirasistant deleted the arv/bb_call_variants branch May 11, 2023 11:48
TomAFrench added a commit that referenced this pull request May 12, 2023
* acvm-0.12.0:
  fix bad rebase
  chore: Release 0.1.2 (#183)
  fix: Remove star dependencies to allow publishing (#182)
  chore: Release 0.1.1 (#181)
  fix: Add description so crate can be published (#180)
  chore: update readme to new name and add contract note (#177)
  feat!: update to acvm with non-homogeneous bb calls (#169)
  update to latest changes
  chore: Release 0.1.0 (#173)
  use patch syntax
  chore: update to use new black box solver interface
  feat!: update to target acvm-84b5d18d
  chore(ci): Update tokens (#174)
  chore: Add release-please and publish workflows to project (#172)
  feat!: Update to ACVM v0.11.0 (#151)
  chore: remove usage of `std::mem::forget` (#164)
  chore: Enforce proper conversion of memory into fixed length array (#163)
  chore: Add test for Keccak256 constraint (#158)
  chore: use `WASMValue` for wasm arguments as well as return values (#157)
  feat!: Add Keccak constraints (#150)
TomAFrench added a commit that referenced this pull request May 19, 2023
* feat!: update to target acvm-84b5d18d

* chore: update to use new black box solver interface

* use patch syntax

* update to latest changes

* feat!: update to acvm with non-homogeneous bb calls (#169)

* feat: update acvm

* feat!: updated acvm to latest master

* chore: update cargo toml

* Update src/barretenberg_structures.rs

Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

---------

Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

* fix bad rebase

* feat!: Update backend to rely on WitnessMap (#152)

Co-authored-by: Tom French <tom@tomfren.ch>

* update acvm

* feat!: Implement CommonReferenceString trait (#139)

* chore!: Remove filesystem access and utilize async fetch with range requests

Co-authored-by: Tom French <tom@tomfren.ch>

* chore: Switch to tokio test macro for async function (#191)

* chore: Remove `sled` & `tempfile` dev-dependencies (#190)

* chore: Remove sled & tempfile dev-dependencies

* chore: space out functions

---------

Co-authored-by: Tom French <tom@tomfren.ch>

* chore: bump to crates.io release

* Update src/crs.rs

* chore: Remove streaming CRS download & indicator (#194)

* Update src/acvm_interop/common_reference_string.rs

* code review

---------

Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Co-authored-by: Álvaro Rodríguez <sirasistant@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants