This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
chore: Switch to tokio test macro for async function #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
approved these changes
May 17, 2023
|
tbh, I'm inclined to rework/remove the
|
TomAFrench
added a commit
that referenced
this pull request
May 19, 2023
* feat!: update to target acvm-84b5d18d * chore: update to use new black box solver interface * use patch syntax * update to latest changes * feat!: update to acvm with non-homogeneous bb calls (#169) * feat: update acvm * feat!: updated acvm to latest master * chore: update cargo toml * Update src/barretenberg_structures.rs Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> * fix bad rebase * feat!: Update backend to rely on WitnessMap (#152) Co-authored-by: Tom French <tom@tomfren.ch> * update acvm * feat!: Implement CommonReferenceString trait (#139) * chore!: Remove filesystem access and utilize async fetch with range requests Co-authored-by: Tom French <tom@tomfren.ch> * chore: Switch to tokio test macro for async function (#191) * chore: Remove `sled` & `tempfile` dev-dependencies (#190) * chore: Remove sled & tempfile dev-dependencies * chore: space out functions --------- Co-authored-by: Tom French <tom@tomfren.ch> * chore: bump to crates.io release * Update src/crs.rs * chore: Remove streaming CRS download & indicator (#194) * Update src/acvm_interop/common_reference_string.rs * code review --------- Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com> Co-authored-by: Álvaro Rodríguez <sirasistant@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to using the
tokio::testmacro to use tokio async test runner for any functions that rely on CRS and other async functions in the future.Removing the tokio calls from functions will allow us to swap in other test runners that support async functions, such as wasm-bindgen-test for browser tests.
I also made the CRS pippenger test run in all targets by relying on the
get_pippengerabstraction.BEGIN_COMMIT_OVERRIDE
chore: Switch to tokio test macro for async functions (#191)
END_COMMIT_OVERRIDE