Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Debt of duplicated compile code between nargo::ops::compile and nargo_cli:clie:compile_cmd #3503

Open
Tracked by #2941
kobyhallx opened this issue Nov 17, 2023 · 2 comments
Open
Tracked by #2941

fix: Debt of duplicated compile code between nargo::ops::compile and nargo_cli:clie:compile_cmd #3503

kobyhallx opened this issue Nov 17, 2023 · 2 comments
Assignees
@TomAFrench

Comments

@kobyhallx
Copy link
Contributor

No description provided.

This was referenced Nov 17, 2023
Closed
Merged
@kobyhallx kobyhallx changed the title fix: Debt of diplicated compile code between nargo::ops::compile and nargo_cli:clie:compile_cmd fix: Debt of duplicated compile code between nargo::ops::compile and nargo_cli:clie:compile_cmd Nov 17, 2023
@Savio-Sou
Copy link
Collaborator

Was this fixed?

@kevaundray kevaundray added this to the 0.24.0 milestone Jan 15, 2024
@kevaundray
Copy link
Contributor

This has not been completely fixed, assigning Koby

@TomAFrench TomAFrench mentioned this issue Jan 19, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 19, 2024
@TomAFrench
chore: deduplicate compile_program and compile_contract methods (#…
6001b01 
…4098)

# Description

## Problem\*

Resolves partially #3503

## Summary\*

This PR removes some duplication on the compilation methods

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@Savio-Sou Savio-Sou removed this from the 0.24 milestone Feb 9, 2024
@Savio-Sou Savio-Sou assigned TomAFrench and kevaundray and unassigned kobyhallx Feb 9, 2024
@TomAFrench TomAFrench mentioned this issue Mar 1, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 4, 2024
@TomAFrench
chore: export report_errors from nargo (#4461)
17f343b 
# Description

## Problem\*

Related to #3503 

## Summary\*

This PR removes the extra copy of the `report_errors` function.

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomAFrench TomAFrench

Labels
None yet
Projects
Noir
Status: 🏗 In progress
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TomAFrench @kevaundray @Savio-Sou @kobyhallx