Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deduplicate compile_program and compile_contract methods #4098

Merged
merged 9 commits into from
Jan 19, 2024

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Jan 19, 2024

Description

Problem*

Resolves partially #3503

Summary*

This PR removes some duplication on the compilation methods

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@kobyhallx kobyhallx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kobyhallx kobyhallx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomAFrench TomAFrench added this pull request to the merge queue Jan 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 19, 2024
@TomAFrench TomAFrench added this pull request to the merge queue Jan 19, 2024
@TomAFrench TomAFrench changed the title chore: deduplicate compile_program and compile_contract methods feat: deduplicate compile_program and compile_contract methods Jan 19, 2024
Merged via the queue into master with commit 6001b01 Jan 19, 2024
33 checks passed
@TomAFrench TomAFrench deleted the tf/remove-some-compilation-duplication branch January 19, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants