Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling closures in the comptime interpreter is incorrect #4879

Closed
Tracked by #4594
jfecher opened this issue Apr 22, 2024 · 0 comments · Fixed by #5682
Closed
Tracked by #4594

Calling closures in the comptime interpreter is incorrect #4879

jfecher opened this issue Apr 22, 2024 · 0 comments · Fixed by #5682
Labels
bug Something isn't working

Comments

@jfecher
Copy link
Contributor

jfecher commented Apr 22, 2024

Aim

Resolving a TODO:

https://github.com/noir-lang/noir/blob/master/compiler/noirc_frontend/src/hir/comptime/interpreter.rs#L168

Expected Behavior

Closures should be able to be called like normal functions

Bug

Calling closures with captures will likely fail when the capture is later referenced

To Reproduce

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Installation Method

None

Nargo Version

No response

NoirJS Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the bug Something isn't working label Apr 22, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Apr 22, 2024
github-merge-queue bot pushed a commit that referenced this issue Aug 5, 2024
# Description

## Problem\*

Resolves #4879

## Summary\*

Implements closures in the comptime interpreter.

## Additional Context

This ended up being much easier than expected. Almost makes me
suspicious.

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant