Upgrade nargo to 0.29.0 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akonior
reviewed
May 13, 2024
| global BORED_APE_YACHT_CLUB = ERC721Token { | ||
| address: [0xbc, 0x4c, 0xa0, 0xed, 0xa7, 0x64, 0x7a, 0x8a, 0xb7, 0xc2, 0x06, 0x1c, 0x2e, 0x11, 0x8a, 0x18, 0xa9, 0x36, 0xf1, 0x3d], | ||
| token_id_to_slot: |token_id| { | ||
| pub fn BORED_APE_YACHT_CLUB() -> ERC721Token { |
There was a problem hiding this comment.
OK, now I see
error: Returning closures from a comptime fn is currently unimplemented
┌─ /Users/akonior/projects/vlayer/noir-ethereum-history-api/vlayer/examples/circuits/is_ape_owner/src/main.nr:9:17
│
9 │ let owner = BORED_APE_YACHT_CLUB.get_owner(token_id, block_number);
marekkirejczyk
approved these changes
May 13, 2024
Pasifaee
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue in Noir 0.29.0 that it's impossible to call closures from comptime context: noir-lang/noir#4879
Therefore this PR changes the format of nft_list and now it has functions that return values that can use closures