Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace FixedBaseScalarMul blackbox function with a MultiScalarMul opcode #4928

Closed
TomAFrench opened this issue Apr 26, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#6097
Closed

Replace FixedBaseScalarMul blackbox function with a MultiScalarMul opcode #4928

TomAFrench opened this issue Apr 26, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#6097
Assignees
@benesjan

Comments

@TomAFrench
Copy link
Member

TomAFrench commented Apr 26, 2024 •
edited
Loading

We currently have a FixedBaseScalarMul and an open PR to add a variable base version as well.

We often perform multiple scalar multiplications in one go (e.g. in schnorr verification) and this would be most efficient if it were packaged up into a MultiScalarMul opcode as this makes it easier for the backend to choose the best constraint implementation.

The current FixedBaseScalarMul would then be msm([generator_point_constant], [scalar]), the backend could then recognise that the witnesses for generator_point_constant were constants and then perform a simple fixed-base scalar mul.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Apr 26, 2024
This was referenced Apr 26, 2024
Merged
Closed
@benesjan benesjan self-assigned this Apr 30, 2024
@benesjan benesjan mentioned this issue Apr 30, 2024
Merged
TomAFrench pushed a commit to AztecProtocol/aztec-packages that referenced this issue May 7, 2024
@benesjan
feat: multi_scalar_mul blackbox func (#6097)
f6b1ba6 
Fixes noir-lang/noir#4928
Fixes noir-lang/noir#4932

**Note**: Noticed that we have [lookup
table](https://github.com/AztecProtocol/aztec-packages/blob/46749ac9f32d4720efb380fb3a0e10a8ab1c345d/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/plookup_tables/fixed_base/fixed_base.hpp#L15)
for fixed base in BB. Not sure if it's still needed after nuking the
fixed based scalar mul.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: multi_scalar_mul blackbox func AztecProtocol/aztec-packages
2 participants
@benesjan @TomAFrench