Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update to ACVM 0.21.0 #2051

Merged
merged 4 commits into from
Jul 27, 2023
Merged

feat!: Update to ACVM 0.21.0 #2051

merged 4 commits into from
Jul 27, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

Migrates to ACVM 0.21.0 (Stepwise ACVM)

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench marked this pull request as draft July 26, 2023 17:25
@TomAFrench
Copy link
Member Author

Actually, we need to hold off on merging until bberg uses the new serialisation format.

kobyhallx
kobyhallx previously approved these changes Jul 26, 2023
@jfecher
Copy link
Contributor

jfecher commented Jul 26, 2023

@kobyhallx are the bberg changes done?

@TomAFrench TomAFrench marked this pull request as ready for review July 27, 2023 09:43
@TomAFrench
Copy link
Member Author

TomAFrench commented Jul 27, 2023

I've updated bberg to use the new ACIR parser here: AztecProtocol/barretenberg#631

As part of this I've had to remove the bb-bin-tests job as this uses legacy ssa artifacts which are incompatible with the new serialisation and the new SSA does not support recursion.

@kobyhallx kobyhallx added this pull request to the merge queue Jul 27, 2023
Merged via the queue into master with commit ad118eb Jul 27, 2023
4 checks passed
@kobyhallx kobyhallx deleted the acvm-0.21.0 branch July 27, 2023 10:43
TomAFrench added a commit that referenced this pull request Aug 1, 2023
* master: (53 commits)
  chore: Update `noir-source-resolver` to v1.1.3 (#1912)
  chore: Document `GeneratedAcir::more_than_eq_comparison` (#2085)
  chore: refresh ACIR test artifacts (#2091)
  feat: Add `deprecated` attribute (#2041)
  chore(ssa refactor): Implement `acir_gen` errors (#2071)
  chore: use witnesses from the generated acir in the ABI (#2095)
  fix: Fix methods not mutating fields (#2087)
  chore(nargo): Use Display impl for InputValue (#1990)
  feat: Make arrays and slices polymorphic over each other (#2070)
  feat: Remove an unnecessary witness in `mul_with_witness` (#2078)
  chore: document truncate (#2082)
  fix: avoid potential panic in `two_complement` (#2081)
  chore: Cleanup integration tests (#2074)
  chore: replace `Type::TypeVariable`, `Type::PolymorphicInteger`, and … (#2065)
  chore!: Require package names in `Nargo.toml` files (#2056)
  fix: Avoid non-determinism in defunctionalization (#2069)
  chore: change 'unnecessary pub' error to a warning (#2064)
  feat!: Update to ACVM 0.21.0 (#2051)
  chore: Rename execute tests for an accurate description (#2063)
  chore: Restore lost integration test (#2062)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants