Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Cleanup integration tests #2074

Merged
merged 1 commit into from
Jul 28, 2023
Merged

chore: Cleanup integration tests #2074

merged 1 commit into from
Jul 28, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Jul 27, 2023

Description

Problem*

Resolves

Summary*

It looks like this wasn't cleaned up when the ssa refactor was made default. I noticed this because the nightly build failed.

This just renames the test directory and adjusts the build script. Be aware that any PRs that update tests in this directory will need to be updated.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@phated phated requested a review from TomAFrench July 27, 2023 19:27
@TomAFrench TomAFrench mentioned this pull request Jul 28, 2023
Merged
6 tasks
@TomAFrench TomAFrench added this pull request to the merge queue Jul 28, 2023
@TomAFrench TomAFrench mentioned this pull request Jul 28, 2023
Merged
5 tasks
Merged via the queue into master with commit 0164a92 Jul 28, 2023
@TomAFrench TomAFrench deleted the phated/rename-test-data branch July 28, 2023 04:07
iAmMichaelConnor pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 28, 2023
@TomAFrench
chore: update directory from which to pull noir test cases (#1257)
79e3471 
# Description

noir-lang/noir#2074 performs a cleanup of the
location of the Noir test data directory and so bberg needs to update to
match

# Checklist:

- [x] I have reviewed my diff in github, line by line.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to the issue(s) that it resolves.
- [x] There are no unexpected formatting changes, superfluous debug
logs, or commented-out code.
- [x] The branch has been merged or rebased against the head of its
merge target.
- [x] I'm happy for the PR to be merged at the reviewer's next
convenience.
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this pull request Jul 28, 2023
@TomAFrench @AztecBot
chore: update directory from which to pull noir test cases (#1257)
3084d60 
# Description

noir-lang/noir#2074 performs a cleanup of the
location of the Noir test data directory and so bberg needs to update to
match

# Checklist:

- [x] I have reviewed my diff in github, line by line.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to the issue(s) that it resolves.
- [x] There are no unexpected formatting changes, superfluous debug
logs, or commented-out code.
- [x] The branch has been merged or rebased against the head of its
merge target.
- [x] I'm happy for the PR to be merged at the reviewer's next
convenience.
@TomAFrench TomAFrench mentioned this pull request Jul 28, 2023
Merged
5 tasks
zac-williamson added a commit to AztecProtocol/barretenberg that referenced this pull request Jul 30, 2023
@zac-williamson
feat: Modify bb.js to be compatible with next.js (#544)
070a1a4 
Co-authored-by: ludamad <adam.domurad@gmail.com>
each subrelation can now choose to not scale relation term by random polynomial

permutation relation arithmetic defined exclusively in relationclasses

comments, naming cleanup

init

ecc_vm_relation_test, algebra test passes sumcheck relation test does not

wip

eccvm, shiftable polynomials now have 0 at first coefficient

added clearer comments to eccvm relations

removed redundant test files

eccvm composer test passes

eccvm flavor (+ upstream circuit builder) are parametrised by curve type / commitment scheme

wip

wip

wip

wip

reduced eccvm relation lengths

added more descriptive comments to ecc_set_relation

cleaned up sumcheck relation fowarding macros

added missing explicit template declarations

slight cleanup of method name bloat

added missing method

removed unused using declaration

added explicit `lookup_library.hpp` file to compute logderivative inverses

typo fix

formatting reversions

added ECCVM concepts to flavor

removed unused logderivative method

each subrelation can now choose to not scale relation term by random polynomial

permutation relation arithmetic defined exclusively in relationclasses

comments, naming cleanup

removed TypeMuncher from relation_types

remove foundation

blah compiler errors

chore: Switch to using `test_data_ssa_refactor` for `acir_tests` (#626)

Co-authored-by: guipublic <47281315+guipublic@users.noreply.github.com>
compile error fix

chore(barretenberg): Release 0.3.4 (#618)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
compiler fix

compiler fix

wasm compiler fix

docs: barretenberg README update (#1211)

* docs: barretenberg README update

* Update README.md

docs: update barretenberg integration notes (#1215)

This is also just continuing to test the barretenberg mirror.

wasm compiler fix

feat: internal keyword + lending contract and tests (#978)

* feat: noir contracts and test file

* feat: include is_internal in kernels

* feat: assume isInternal unless told otherwise + update snaps

* test: cleanup tests

* chore: update noir

* chore: recompile noir

* fix: rebase issues and clean test

* chore: prettier + update name

* chore: fix snapshots

* fix: add to ci

* chore: minor fixes

* fix: update noir FunctionData (cannot satisfy 💀)

* fix: serialization

* fix: bump lending contract

* chore: address nits

* chore: recompile noir

* chore: recompile noir

---------

Co-authored-by: Maddiaa0 <47148561+Maddiaa0@users.noreply.github.com>

Merge pull request #1235 from AztecProtocol/acvm-0.21.0-compat

feat!: update bberg ACIR parser to target ACVM 0.21.0

feat: Goblin Honk Composer/Prover/Verifier (#1220)

The Composer, Prover and Verifier for Goblin Ultra Honk. These are
implemented as instantiations of the existing "Ultra" template classes,
e.g. `GoblinUltraComposer = UltraComposer_<flavor::GoblinUltra>`, etc.

This work makes it possible to create and verify a Goblin Ultra Honk
proof. "Verification" here means confirmation that the ECC op gates have
been correctly incorporated into the circuit (checked via a new
relation) plus genuine verification of the conventional UltraHonk proof.
The _correctness_ of the the ECC op gates is of course not verified, as
that is the role of the other components of the Goblin stack.

The new "op gate consistency" relation simply checks that the op wire
values have been correctly copied into the conventional wires (needed
for copy constraints) and that the op wire polynomials vanish everywhere
outside the range of ECC op gates.

- [ ] I have reviewed my diff in github, line by line.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to the issue(s) that it resolves.
- [ ] There are no unexpected formatting changes, superfluous debug
logs, or commented-out code.
- [ ] The branch has been merged or rebased against the head of its
merge target.
- [ ] I'm happy for the PR to be merged at the reviewer's next
convenience.

---------

Co-authored-by: ludamad <adam.domurad@gmail.com>

feat: Goblin translator prototype (#1249)

Added a prototype of  goblin translator with accumulation gate.

Automatic formatting when committing caused changes to several files,
too

- [ ] I have reviewed my diff in github, line by line.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to the issue(s) that it resolves.
- [ ] There are no unexpected formatting changes, superfluous debug
logs, or commented-out code.
- [ ] The branch has been merged or rebased against the head of its
merge target.
- [ ] I'm happy for the PR to be merged at the reviewer's next
convenience.

fix: Fixing external benchmarks (#1250)

Some updates broke internal benchmarks. This fixes them

chore: update directory from which to pull noir test cases (#1257)

noir-lang/noir#2074 performs a cleanup of the
location of the Noir test data directory and so bberg needs to update to
match

- [x] I have reviewed my diff in github, line by line.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to the issue(s) that it resolves.
- [x] There are no unexpected formatting changes, superfluous debug
logs, or commented-out code.
- [x] The branch has been merged or rebased against the head of its
merge target.
- [x] I'm happy for the PR to be merged at the reviewer's next
convenience.

fix: bootstrap.sh git hook for monorepo (#1256)

This had the wrong path inside the monorepo.

compiler fix

compiler fix

fixed error in eccvm lookup relation

Merge branch 'master' into zw/eccvm-v2
zac-williamson added a commit to AztecProtocol/barretenberg that referenced this pull request Jul 30, 2023
@zac-williamson
each subrelation can now choose to not scale relation term by random …
edac18c 
…polynomial

permutation relation arithmetic defined exclusively in relationclasses

comments, naming cleanup

init

ecc_vm_relation_test, algebra test passes sumcheck relation test does not

wip

eccvm, shiftable polynomials now have 0 at first coefficient

added clearer comments to eccvm relations

removed redundant test files

eccvm composer test passes

eccvm flavor (+ upstream circuit builder) are parametrised by curve type / commitment scheme

wip

wip

wip

wip

reduced eccvm relation lengths

added more descriptive comments to ecc_set_relation

cleaned up sumcheck relation fowarding macros

added missing explicit template declarations

slight cleanup of method name bloat

added missing method

removed unused using declaration

added explicit `lookup_library.hpp` file to compute logderivative inverses

typo fix

formatting reversions

added ECCVM concepts to flavor

removed unused logderivative method

each subrelation can now choose to not scale relation term by random polynomial

permutation relation arithmetic defined exclusively in relationclasses

comments, naming cleanup

removed TypeMuncher from relation_types

remove foundation

blah compiler errors

chore: Switch to using `test_data_ssa_refactor` for `acir_tests` (#626)

Co-authored-by: guipublic <47281315+guipublic@users.noreply.github.com>
compile error fix

chore(barretenberg): Release 0.3.4 (#618)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
compiler fix

compiler fix

wasm compiler fix

docs: barretenberg README update (#1211)

* docs: barretenberg README update

* Update README.md

docs: update barretenberg integration notes (#1215)

This is also just continuing to test the barretenberg mirror.

wasm compiler fix

feat: internal keyword + lending contract and tests (#978)

* feat: noir contracts and test file

* feat: include is_internal in kernels

* feat: assume isInternal unless told otherwise + update snaps

* test: cleanup tests

* chore: update noir

* chore: recompile noir

* fix: rebase issues and clean test

* chore: prettier + update name

* chore: fix snapshots

* fix: add to ci

* chore: minor fixes

* fix: update noir FunctionData (cannot satisfy 💀)

* fix: serialization

* fix: bump lending contract

* chore: address nits

* chore: recompile noir

* chore: recompile noir

---------

Co-authored-by: Maddiaa0 <47148561+Maddiaa0@users.noreply.github.com>

Merge pull request #1235 from AztecProtocol/acvm-0.21.0-compat

feat!: update bberg ACIR parser to target ACVM 0.21.0

feat: Goblin Honk Composer/Prover/Verifier (#1220)

The Composer, Prover and Verifier for Goblin Ultra Honk. These are
implemented as instantiations of the existing "Ultra" template classes,
e.g. `GoblinUltraComposer = UltraComposer_<flavor::GoblinUltra>`, etc.

This work makes it possible to create and verify a Goblin Ultra Honk
proof. "Verification" here means confirmation that the ECC op gates have
been correctly incorporated into the circuit (checked via a new
relation) plus genuine verification of the conventional UltraHonk proof.
The _correctness_ of the the ECC op gates is of course not verified, as
that is the role of the other components of the Goblin stack.

The new "op gate consistency" relation simply checks that the op wire
values have been correctly copied into the conventional wires (needed
for copy constraints) and that the op wire polynomials vanish everywhere
outside the range of ECC op gates.

- [ ] I have reviewed my diff in github, line by line.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to the issue(s) that it resolves.
- [ ] There are no unexpected formatting changes, superfluous debug
logs, or commented-out code.
- [ ] The branch has been merged or rebased against the head of its
merge target.
- [ ] I'm happy for the PR to be merged at the reviewer's next
convenience.

---------

Co-authored-by: ludamad <adam.domurad@gmail.com>

feat: Goblin translator prototype (#1249)

Added a prototype of  goblin translator with accumulation gate.

Automatic formatting when committing caused changes to several files,
too

- [ ] I have reviewed my diff in github, line by line.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to the issue(s) that it resolves.
- [ ] There are no unexpected formatting changes, superfluous debug
logs, or commented-out code.
- [ ] The branch has been merged or rebased against the head of its
merge target.
- [ ] I'm happy for the PR to be merged at the reviewer's next
convenience.

fix: Fixing external benchmarks (#1250)

Some updates broke internal benchmarks. This fixes them

chore: update directory from which to pull noir test cases (#1257)

noir-lang/noir#2074 performs a cleanup of the
location of the Noir test data directory and so bberg needs to update to
match

- [x] I have reviewed my diff in github, line by line.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to the issue(s) that it resolves.
- [x] There are no unexpected formatting changes, superfluous debug
logs, or commented-out code.
- [x] The branch has been merged or rebased against the head of its
merge target.
- [x] I'm happy for the PR to be merged at the reviewer's next
convenience.

fix: bootstrap.sh git hook for monorepo (#1256)

This had the wrong path inside the monorepo.

compiler fix

compiler fix

fixed error in eccvm lookup relation

Merge branch 'master' into zw/eccvm-v2
TomAFrench added a commit that referenced this pull request Aug 1, 2023
@TomAFrench
Merge branch 'master' into boolean-and
d56bddf 
* master: (53 commits)
  chore: Update `noir-source-resolver` to v1.1.3 (#1912)
  chore: Document `GeneratedAcir::more_than_eq_comparison` (#2085)
  chore: refresh ACIR test artifacts (#2091)
  feat: Add `deprecated` attribute (#2041)
  chore(ssa refactor): Implement `acir_gen` errors (#2071)
  chore: use witnesses from the generated acir in the ABI (#2095)
  fix: Fix methods not mutating fields (#2087)
  chore(nargo): Use Display impl for InputValue (#1990)
  feat: Make arrays and slices polymorphic over each other (#2070)
  feat: Remove an unnecessary witness in `mul_with_witness` (#2078)
  chore: document truncate (#2082)
  fix: avoid potential panic in `two_complement` (#2081)
  chore: Cleanup integration tests (#2074)
  chore: replace `Type::TypeVariable`, `Type::PolymorphicInteger`, and … (#2065)
  chore!: Require package names in `Nargo.toml` files (#2056)
  fix: Avoid non-determinism in defunctionalization (#2069)
  chore: change 'unnecessary pub' error to a warning (#2064)
  feat!: Update to ACVM 0.21.0 (#2051)
  chore: Rename execute tests for an accurate description (#2063)
  chore: Restore lost integration test (#2062)
  ...
TomAFrench added a commit that referenced this pull request Aug 1, 2023
@TomAFrench
Merge branch 'master' into abi-wasm
8182412 
* master: (75 commits)
  fix: Mutating a variable no longer mutates its copy (#2057)
  fix: Implement `.len()` in Acir-Gen (#2077)
  chore: clippy fixes (#2101)
  chore: Update `noir-source-resolver` to v1.1.3 (#1912)
  chore: Document `GeneratedAcir::more_than_eq_comparison` (#2085)
  chore: refresh ACIR test artifacts (#2091)
  feat: Add `deprecated` attribute (#2041)
  chore(ssa refactor): Implement `acir_gen` errors (#2071)
  chore: use witnesses from the generated acir in the ABI (#2095)
  fix: Fix methods not mutating fields (#2087)
  chore(nargo): Use Display impl for InputValue (#1990)
  feat: Make arrays and slices polymorphic over each other (#2070)
  feat: Remove an unnecessary witness in `mul_with_witness` (#2078)
  chore: document truncate (#2082)
  fix: avoid potential panic in `two_complement` (#2081)
  chore: Cleanup integration tests (#2074)
  chore: replace `Type::TypeVariable`, `Type::PolymorphicInteger`, and … (#2065)
  chore!: Require package names in `Nargo.toml` files (#2056)
  fix: Avoid non-determinism in defunctionalization (#2069)
  chore: change 'unnecessary pub' error to a warning (#2064)
  ...
TomAFrench added a commit that referenced this pull request Aug 1, 2023
@TomAFrench
Merge branch 'master' into abi-wasm
0ccf055 
* master: (75 commits)
  fix: Mutating a variable no longer mutates its copy (#2057)
  fix: Implement `.len()` in Acir-Gen (#2077)
  chore: clippy fixes (#2101)
  chore: Update `noir-source-resolver` to v1.1.3 (#1912)
  chore: Document `GeneratedAcir::more_than_eq_comparison` (#2085)
  chore: refresh ACIR test artifacts (#2091)
  feat: Add `deprecated` attribute (#2041)
  chore(ssa refactor): Implement `acir_gen` errors (#2071)
  chore: use witnesses from the generated acir in the ABI (#2095)
  fix: Fix methods not mutating fields (#2087)
  chore(nargo): Use Display impl for InputValue (#1990)
  feat: Make arrays and slices polymorphic over each other (#2070)
  feat: Remove an unnecessary witness in `mul_with_witness` (#2078)
  chore: document truncate (#2082)
  fix: avoid potential panic in `two_complement` (#2081)
  chore: Cleanup integration tests (#2074)
  chore: replace `Type::TypeVariable`, `Type::PolymorphicInteger`, and … (#2065)
  chore!: Require package names in `Nargo.toml` files (#2056)
  fix: Avoid non-determinism in defunctionalization (#2069)
  chore: change 'unnecessary pub' error to a warning (#2064)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

@TomAFrench TomAFrench Awaiting requested review from TomAFrench

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phated @jfecher @TomAFrench