Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update to acvm 0.22.0 #2363

Merged
merged 5 commits into from
Aug 21, 2023
Merged

feat: Update to acvm 0.22.0 #2363

merged 5 commits into from
Aug 21, 2023

Conversation

sirasistant
Copy link
Contributor

@sirasistant sirasistant commented Aug 18, 2023

Description

Problem*

Starts using acvm 0.22 and backend 0.11. It also substitutes direct acir indexes with the new OpcodeLocation enum.

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@sirasistant
Copy link
Contributor Author

We need to update to version 0.11 of the backend when released, since version 0.10 points to the old 0.21 of the acvm

@sirasistant sirasistant marked this pull request as ready for review August 21, 2023 07:39
@sirasistant sirasistant changed the title feat: support for acvm 0.22.0 feat: acvm 0.22 for OpcodeLocation Aug 21, 2023
@sirasistant sirasistant changed the title feat: acvm 0.22 for OpcodeLocation feat: use acvm 0.22 for OpcodeLocation in debug metadata Aug 21, 2023
@sirasistant sirasistant changed the title feat: use acvm 0.22 for OpcodeLocation in debug metadata feat: Use acvm 0.22 for OpcodeLocation in debug metadata Aug 21, 2023
@TomAFrench TomAFrench changed the title feat: Use acvm 0.22 for OpcodeLocation in debug metadata feat: Update to acvm 0.22.0 Aug 21, 2023
@TomAFrench
Copy link
Member

Looking at this now

Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small nits :)

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long review, got distracted.

Looks good, the only issue is the abstraction leak of unresolved errors but that's an existing issue.

Happy to merge once Kev's nits are dealt with.

crates/nargo_cli/src/cli/execute_cmd.rs Show resolved Hide resolved
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sirasistant sirasistant added this pull request to the merge queue Aug 21, 2023
Merged via the queue into master with commit e050fab Aug 21, 2023
16 checks passed
@sirasistant sirasistant deleted the acvm-0.22.0 branch August 21, 2023 11:31
TomAFrench added a commit that referenced this pull request Aug 21, 2023
* master:
  feat: Perform more checks for compile-time arithmetic (#2380)
  chore: Remove `noirc_abi::FunctionSignature` and define in terms of HIR (#2372)
  feat: Update to `acvm` 0.22.0 (#2363)
TomAFrench added a commit that referenced this pull request Aug 22, 2023
* master: (46 commits)
  chore: Remove `serde` from `noirc_frontend` (#2390)
  chore: allow parenthesizing in two type locations  (#2388)
  chore(ci): automatically delete cache entries associated with closed PRs (#2342)
  feat: Perform more checks for compile-time arithmetic (#2380)
  chore: Remove `noirc_abi::FunctionSignature` and define in terms of HIR (#2372)
  feat: Update to `acvm` 0.22.0 (#2363)
  chore: Update committed ACIR artifacts (#2376)
  feat(ssa): Merge slices in if statements with witness conditions (#2347)
  chore: Separate frontend `Visibility` and `Distinctness` from the ABI (#2369)
  feat: add syntax for specifying function type environments (#2357)
  chore: Remove unused `Directive::Log` (#2366)
  chore: clippy fixes (#2365)
  chore: Extract bytecode from artifact files for backend integration test inputs (#2356)
  feat: Add trait definition representation in DefCollector and HIR (#2338)
  chore: Remove unused `Intrinsic::Println` (#2358)
  fix: Remove duplicte `T` in `expected T, found T` error on tuple assignment (#2360)
  chore(brillig): Fix brillig radix instruction return vector size (#2350)
  fix: Show types in error message in same order as in source code (#2353)
  chore: update noir-source-resolver from `1.1.2` to `^1.1.3` (#2349)
  chore(ci): Avoid writing to cache in workflows triggered by the merge queue (#2341)
  ...
TomAFrench added a commit that referenced this pull request Aug 23, 2023
* master: (34 commits)
  chore: Decouple `noirc_abi` from frontend by introducing `PrintableType` (#2373)
  feat(brillig): Added locations for brillig artifacts (#2415)
  feat: Report compilation warnings before errors (#2398)
  chore: Rework `CrateGraph` to only have one root crate (#2391)
  chore: clippy fix (#2408)
  chore(deps): bump rustls-webpki from 0.101.1 to 0.101.4 (#2404)
  fix(acir): Attach locations to MemoryOps in ACIR (#2389)
  feat: Use equivalence information from equality assertions to simplify circuit (#2378)
  chore: fix body expr span (#2402)
  feat(attributes): enable custom attributes (#2395)
  chore: Remove `serde` from `noirc_frontend` (#2390)
  chore: allow parenthesizing in two type locations  (#2388)
  chore(ci): automatically delete cache entries associated with closed PRs (#2342)
  feat: Perform more checks for compile-time arithmetic (#2380)
  chore: Remove `noirc_abi::FunctionSignature` and define in terms of HIR (#2372)
  feat: Update to `acvm` 0.22.0 (#2363)
  chore: Update committed ACIR artifacts (#2376)
  feat(ssa): Merge slices in if statements with witness conditions (#2347)
  chore: Separate frontend `Visibility` and `Distinctness` from the ABI (#2369)
  feat: add syntax for specifying function type environments (#2357)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants