-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Decouple noirc_abi
from frontend by introducing PrintableType
#2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
reviewed
Aug 18, 2023
Base automatically changed from
phated/remove-function-signature-from-abi
to
master
August 21, 2023 13:36
phated
force-pushed
the
phated/separate-abi-and-print
branch
from
August 21, 2023 17:29
9f769ad
to
1f76e23
Compare
5 tasks
vezenovm
reviewed
Aug 22, 2023
Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
2 tasks
vezenovm
approved these changes
Aug 23, 2023
TomAFrench
added a commit
that referenced
this pull request
Aug 23, 2023
* master: (34 commits) chore: Decouple `noirc_abi` from frontend by introducing `PrintableType` (#2373) feat(brillig): Added locations for brillig artifacts (#2415) feat: Report compilation warnings before errors (#2398) chore: Rework `CrateGraph` to only have one root crate (#2391) chore: clippy fix (#2408) chore(deps): bump rustls-webpki from 0.101.1 to 0.101.4 (#2404) fix(acir): Attach locations to MemoryOps in ACIR (#2389) feat: Use equivalence information from equality assertions to simplify circuit (#2378) chore: fix body expr span (#2402) feat(attributes): enable custom attributes (#2395) chore: Remove `serde` from `noirc_frontend` (#2390) chore: allow parenthesizing in two type locations (#2388) chore(ci): automatically delete cache entries associated with closed PRs (#2342) feat: Perform more checks for compile-time arithmetic (#2380) chore: Remove `noirc_abi::FunctionSignature` and define in terms of HIR (#2372) feat: Update to `acvm` 0.22.0 (#2363) chore: Update committed ACIR artifacts (#2376) feat(ssa): Merge slices in if statements with witness conditions (#2347) chore: Separate frontend `Visibility` and `Distinctness` from the ABI (#2369) feat: add syntax for specifying function type environments (#2357) ...
TomAFrench
added a commit
that referenced
this pull request
Aug 23, 2023
* master: chore: Decouple `noirc_abi` from frontend by introducing `PrintableType` (#2373) feat(brillig): Added locations for brillig artifacts (#2415) feat: Report compilation warnings before errors (#2398) chore: Rework `CrateGraph` to only have one root crate (#2391) chore: clippy fix (#2408) chore(deps): bump rustls-webpki from 0.101.1 to 0.101.4 (#2404)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Towards #2238
Summary*
This completes the decoupling of the
noirc_abi
from thenoirc_frontend
by introducing a new crate callednoirc_printable_type
. Right now, thePrintableType
is similar to theAbiType
but is a separate implementation to allow these to grow independently. For example, we probably want to print tuples but might not want to support them in the ABI, or the more concrete example of #2238.In doing this work, I also noticed room for improvement in how
Display
was implemented forPrintableType
to avoid round-tripping to serde_json. Here's the new output from runningnargo execute
on https://github.com/noir-lang/noir/blob/master/crates/nargo_cli/tests/execution_success/debug_logs/src/main.nr:"i: {i}, j: {j}" i: 0x01, j: 0x02 i: 0x01, j: 0x02 i: 0x01, j: 0x02 myStruct { y: 0x01, x: 0x02 } randomstring0x010x01 i: 0x01, s: myStruct { y: 0x01, x: 0x02 } 0x01 [0x01, 0x02] s: myStruct { y: 0x01, x: 0x02 }, foo: fooStruct { my_struct: myStruct { y: 0x02, x: 0x01 }, foo: 0x02 } x: 0, y: 1 s1: myStruct { y: 0x01, x: 0x02 }, s2: myStruct { y: 0x02, x: 0x1e } foo1: fooStruct { my_struct: myStruct { y: 0x01, x: 0x02 }, foo: 0x0f }, foo2: fooStruct { my_struct: myStruct { y: 0x02, x: 0x0f }, foo: 0x1e } fooStruct { my_struct: myStruct { y: 0x01, x: 0x02 }, foo: 0x0f }
I'm happy to make any println formatting changes here if we don't like this output.
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.