Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Decouple noirc_abi from frontend by introducing PrintableType #2373

Merged
merged 9 commits into from
Aug 23, 2023
Merged

chore: Decouple noirc_abi from frontend by introducing PrintableType #2373

merged 9 commits into from
Aug 23, 2023

Commits on Aug 21, 2023

  1. chore: Decouple noirc_abi from frontend by introducing PrintableType

    @phated
    phated committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    a2d0345 View commit details
    Browse the repository at this point in the history

  2. chore: Cleanup some unused error variants

    @phated
    phated committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    1f76e23 View commit details
    Browse the repository at this point in the history

  3. undo the full removal of serde, will do in followup PR

    @phated
    phated committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    22a01b1 View commit details
    Browse the repository at this point in the history

  4. remove the display impl on abi now

    @phated
    phated committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    2bc6ce7 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
    @phated @vezenovm
    phated and vezenovm authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    47aa682 View commit details
    Browse the repository at this point in the history

  2. Update crates/noirc_printable_type/src/lib.rs

    @phated
    phated authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    2b0697d View commit details
    Browse the repository at this point in the history

  3. implement TryFrom and rework printing to avoid leaking internal funct… 

    …ions
    @phated
    phated committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    595040d View commit details
    Browse the repository at this point in the history

  4. cspell

    @phated
    phated committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    214562a View commit details
    Browse the repository at this point in the history

  5. avoid unwrapping in display

    @phated
    phated committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    5e1fa6a View commit details
    Browse the repository at this point in the history