Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add test(should_fail) attribute for tests that are meant to fail #2418

Merged
merged 35 commits into from
Aug 24, 2023
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
04f20b9
test(should_fail)
Ethan-000 Aug 23, 2023
d684879
update comment
Ethan-000 Aug 23, 2023
b8dc4f5
make only unsatisfied constraint success
Ethan-000 Aug 23, 2023
54137b1
testfunc type alias to replace tuple
Ethan-000 Aug 23, 2023
5ee5dfb
inline comment
Ethan-000 Aug 23, 2023
2268b1e
change to expect failure
Ethan-000 Aug 23, 2023
4c5145f
change Test(bool) to Test{}
Ethan-000 Aug 23, 2023
4bd422e
clippy
Ethan-000 Aug 23, 2023
09b0799
remove duplication
Ethan-000 Aug 23, 2023
148ab5c
remove duplication
Ethan-000 Aug 23, 2023
f165f48
remove duplication
Ethan-000 Aug 23, 2023
52ca47f
add some spacing
Ethan-000 Aug 23, 2023
131eec5
Update crates/noirc_frontend/src/hir/resolution/resolver.rs
Ethan-000 Aug 23, 2023
83a281e
Update crates/noirc_frontend/src/hir/def_map/mod.rs
Ethan-000 Aug 23, 2023
f550b30
make testfunc a struct
Ethan-000 Aug 23, 2023
a0c3771
fix typo
Ethan-000 Aug 23, 2023
34f3af7
rename testfunc to testfunction
Ethan-000 Aug 24, 2023
0a33986
only pass in test function
Ethan-000 Aug 24, 2023
aa1a719
Update crates/nargo_cli/src/cli/test_cmd.rs
Ethan-000 Aug 24, 2023
d741ef3
use pattern matching
Ethan-000 Aug 24, 2023
49bd10a
use a single filtermap untested
Ethan-000 Aug 24, 2023
3d96f3f
clippy
Ethan-000 Aug 24, 2023
77d9c33
use if le
Ethan-000 Aug 24, 2023
9d55fbf
Update crates/noirc_frontend/src/hir/def_map/mod.rs
Ethan-000 Aug 24, 2023
8f8106a
chore: use general scope variant instead of expect_failure (#2427)
kevaundray Aug 24, 2023
74ef56f
fix clippy
Ethan-000 Aug 24, 2023
a49655d
use cfg test to fix clippy
Ethan-000 Aug 24, 2023
cb36da0
Update crates/nargo_cli/src/cli/test_cmd.rs
Ethan-000 Aug 24, 2023
d1188a2
rename function to should_fail
Ethan-000 Aug 24, 2023
6cddf30
fix clippy by putting a cfg on mod tests
kevaundray Aug 24, 2023
53d4bdf
Merge branch 'e/should_panic' of github.com:noir-lang/noir into e/sho…
kevaundray Aug 24, 2023
f1ff2ad
Merge branch 'e/should_panic' of github.com:noir-lang/noir into e/sho…
kevaundray Aug 24, 2023
8b26cb8
add comments
kevaundray Aug 24, 2023
239484f
write error with color
Ethan-000 Aug 24, 2023
095741b
add more comments regarding programs that are never satisfiable
kevaundray Aug 24, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/noirc_frontend/src/lexer/token.rs
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@
Builtin(String),
Oracle(String),
Deprecated(Option<String>),
Test(/* should fail: */ bool),
Test(/* expect failure: */ bool),
phated marked this conversation as resolved.
Show resolved Hide resolved
Custom(String),
}

Expand Down Expand Up @@ -507,7 +507,7 @@
Keyword::Field => write!(f, "Field"),
Keyword::Fn => write!(f, "fn"),
Keyword::For => write!(f, "for"),
Keyword::FormatString => write!(f, "fmtstr"),

Check warning on line 510 in crates/noirc_frontend/src/lexer/token.rs

View workflow job for this annotation

GitHub Actions / Spellcheck / Spellcheck

Unknown word (fmtstr)
Keyword::Global => write!(f, "global"),
Keyword::If => write!(f, "if"),
Keyword::Impl => write!(f, "impl"),
Expand Down Expand Up @@ -549,7 +549,7 @@
"Field" => Keyword::Field,
"fn" => Keyword::Fn,
"for" => Keyword::For,
"fmtstr" => Keyword::FormatString,

Check warning on line 552 in crates/noirc_frontend/src/lexer/token.rs

View workflow job for this annotation

GitHub Actions / Spellcheck / Spellcheck

Unknown word (fmtstr)
"global" => Keyword::Global,
"if" => Keyword::If,
"impl" => Keyword::Impl,
Expand Down
Loading