Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Optmize update_acir() #2476

Merged
merged 4 commits into from
Sep 6, 2023
Merged

chore: Optmize update_acir() #2476

merged 4 commits into from
Sep 6, 2023

Conversation

Ethan-000
Copy link
Contributor

Description

Problem*

Blocked by noir-lang/acvm#507

Resolves #2474

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@Ethan-000 Ethan-000 marked this pull request as draft August 29, 2023 14:56
@Ethan-000
Copy link
Contributor Author

this should be ready after #2504

@Ethan-000 Ethan-000 marked this pull request as ready for review September 4, 2023 09:21
@kevaundray kevaundray added this pull request to the merge queue Sep 6, 2023
Merged via the queue into master with commit e6c139b Sep 6, 2023
11 checks passed
@kevaundray kevaundray deleted the e/optimize_update_acir branch September 6, 2023 13:50
@TomAFrench TomAFrench mentioned this pull request Sep 11, 2023
Merged
5 tasks
@vezenovm vezenovm mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench left review comments

@jfecher jfecher jfecher left review comments

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize update_acir
4 participants
@Ethan-000 @jfecher @TomAFrench @kevaundray