Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: ACVM 0.24 #2504

Merged
merged 23 commits into from
Sep 4, 2023
Merged

chore!: ACVM 0.24 #2504

merged 23 commits into from
Sep 4, 2023

Conversation

kevaundray
Copy link
Contributor

Description

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
Copy link
Contributor Author

Seems we have a circular dependency due to the backend being in here when we are making serialization changes:

  1. This PR requires a new version of barretenberg to pass
  2. The barretenberg PR requires* this branch to be merged into master to pass

*We could merge barretenberg while tests link to this branch, then merge this branch, then change the tests on bb to point to master again.

We could also push changes to AztecProtocol/barretenberg, push a nightly version, update this to point to the nightly, merge this, then merge barretenberg once this is in master, then change this to point to the released barretenberg

@kevaundray
Copy link
Contributor Author

I'll open up a PR so that acvm-backend-barretenberg references the nargo_cli tests

Cargo.toml Outdated Show resolved Hide resolved
crates/nargo/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@sirasistant sirasistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevaundray kevaundray added this pull request to the merge queue Sep 4, 2023
Merged via the queue into master with commit f06fbdb Sep 4, 2023
11 checks passed
@kevaundray kevaundray deleted the kw/acvm-0-24 branch September 4, 2023 08:40
@Ethan-000 Ethan-000 mentioned this pull request Sep 4, 2023
2 tasks
@kevaundray kevaundray restored the kw/acvm-0-24 branch September 4, 2023 11:16
TomAFrench added a commit that referenced this pull request Sep 5, 2023
* master:
  chore: Replace hashers of hashmaps in dfg with fxhashes (#2490)
  chore: remove duplicate span from FunctionReturnType (#2546)
  feat: Add support for brillig call stacks in runtime errors (#2549)
  feat: add `noirc_abi_wasm` crate for ABI encoding in JS (#1945)
  chore: move CRS files into their own directory (#2558)
  chore: Cleanup `rebuild.sh` script (#2470)
  chore(ci): add mocked backend binary to improve `compile_success_empty` tests (#2554)
  chore: add noir-source-resolver (#2485)
  chore: fix double verify proof (#2556)
  feat: add `nargo backend ls` and `nargo backend use` command to switch between backends (#2552)
  chore(ci): bump checkout action to v4 (#2551)
  feat: Support for optional assertion messages (#2491)
  fix: allow usage of decimal string encoding for fields larger than a `i128` (#2547)
  feat(nargo): add hidden option to produce JSON output from `nargo info` (#2542)
  chore(stdlib)!: Rename `fixed_base_scalar_mul` to be more descriptive (#2488)
  chore: Document requirement for range opcode on `r_witness` in  `GeneratedAcir::euclidean_division` (#2437)
  chore!: ACVM 0.24 (#2504)
  fix(aztec_noir): generalise loop to not always inject a hasher instance (#2529)
  chore: create helper functions for writing programs and contracts to file (#2526)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants