chore: remove duplicate span from FunctionReturnType #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvitkov
changed the title
|
The default variant of the enum was needed in order not to display help in such cases; I guess it would be confusing, not sure. |
alexvitkov
force-pushed
the
remove-function-return-type
branch
from
30e1338
to
1545441
Compare
|
Ah ok, makes sense -- I thought it was just for the Span. In that case I'll bring back the struct and just remove span, since we're storing it twice in the struct. |
alexvitkov
changed the title
TomAFrench
added a commit
that referenced
this pull request
Sep 5, 2023
* master: chore: Replace hashers of hashmaps in dfg with fxhashes (#2490) chore: remove duplicate span from FunctionReturnType (#2546) feat: Add support for brillig call stacks in runtime errors (#2549) feat: add `noirc_abi_wasm` crate for ABI encoding in JS (#1945) chore: move CRS files into their own directory (#2558) chore: Cleanup `rebuild.sh` script (#2470) chore(ci): add mocked backend binary to improve `compile_success_empty` tests (#2554) chore: add noir-source-resolver (#2485) chore: fix double verify proof (#2556) feat: add `nargo backend ls` and `nargo backend use` command to switch between backends (#2552) chore(ci): bump checkout action to v4 (#2551) feat: Support for optional assertion messages (#2491) fix: allow usage of decimal string encoding for fields larger than a `i128` (#2547) feat(nargo): add hidden option to produce JSON output from `nargo info` (#2542) chore(stdlib)!: Rename `fixed_base_scalar_mul` to be more descriptive (#2488) chore: Document requirement for range opcode on `r_witness` in `GeneratedAcir::euclidean_division` (#2437) chore!: ACVM 0.24 (#2504) fix(aztec_noir): generalise loop to not always inject a hasher instance (#2529) chore: create helper functions for writing programs and contracts to file (#2526)
5 tasks
TomAFrench
added a commit
that referenced
this pull request
Sep 5, 2023
* master: fix(aztec): fix compilation of `aztec_library.rs` (#2567) feat(ssa): Replace values which have previously been constrained with simplified value (#2483) fix: Black box func slice handling (#2562) chore: Temporarily disable `noir_wasm` test (#2566) fix: Make def collector ordering more deterministic (#2515) chore: refactor `constant_folding` pass (#2533) chore: Cleanup mem2reg pass (#2531) chore: Replace hashers of hashmaps in dfg with fxhashes (#2490) chore: remove duplicate span from FunctionReturnType (#2546)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
We have a struct called
FunctionReturnType, that has a UnresolvedType and a Span. Recently we added a Span toUnresolvedTypeitself, so the Span is no longer neededSummary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.