fix(ssa): Slice mergers with multiple ifs #2597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
No issue as this was found and quickly patched as part of #374
Summary*
The handling of
get_slice_length
was incorrect in that for some instruction cases it used the slice capacity (the total number of slice elements in an array value) and in some cases it used the slice length prefix. During slice merger we should only ever use the capacity. The length is to be used only for checking against user out of bounds accesses. This was not a problem in the existing tests, but when trying to do a push back outside of an if statement where there was a slice merger we get mismatched slice values as the length is not correct.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.