Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove usage of serial_test dependency #2598

Merged
merged 1 commit into from
Sep 7, 2023
Merged

chore: remove usage of serial_test dependency #2598

merged 1 commit into from
Sep 7, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

We used to require this as we were installing the mocked backend in each test (which resulted in many backends being simultaneously written to the same location. We now allow using backends at arbitrary paths so no longer need to do this.

We then run these tests in parallel.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray added this pull request to the merge queue Sep 7, 2023
Merged via the queue into master with commit ed7ad6e Sep 7, 2023
14 checks passed
@kevaundray kevaundray deleted the parallel-cli-tests branch September 7, 2023 17:57
TomAFrench added a commit that referenced this pull request Sep 7, 2023
@TomAFrench
Merge branch 'master' into backend-errors
8a6b501 
* master:
  chore: remove usage of `serial_test` dependency (#2598)
  fix: Implement auto-dereferencing when calling methods (#2581)
  chore(noir): Release 0.11.1 (#2594)
TomAFrench added a commit that referenced this pull request Sep 7, 2023
@TomAFrench
Merge branch 'master' into stdout-backend-communication
35b287c 
* master:
  fix(ssa): Slice mergers with multiple ifs (#2597)
  chore: remove usage of `serial_test` dependency (#2598)
  fix: Implement auto-dereferencing when calling methods (#2581)
  chore(noir): Release 0.11.1 (#2594)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @kevaundray