chore: generalise `FunctionVisibility` to `ItemVisibility` #4495

TomAFrench · 2024-03-06T20:51:19Z

Description

Problem*

Resolves

Summary*

This pulls out a renaming from #4491.

We have the concept of FunctionVisibility which determines whether a function can be called from other modules in the same crate/other crates.

If we're expanding the same concept of visibility to items other than functions we need a generic name for this which doesn't mention functions. I've then renamed it to ModuleVisibility to reflect that it shows how this item is visible in other modules but I'm open to suggestions.

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

jfecher · 2024-03-06T21:11:21Z

I've then renamed it to ModuleVisibility to reflect that it shows how this item is visible in other modules but I'm open to suggestions.

I think a plain Visibility also works.

ModuleVisibility makes me think of either the visibility of a module or the visibility within a single module

TomAFrench · 2024-03-06T21:17:22Z

Yeah, that was my first preference but that conflicts with Visibility as used for whether a variable is a public input, to the point of we're using them both in the same files so we'd need to rename one of them when importing.

TomAFrench · 2024-03-06T21:18:18Z

ImportVisibility was another option, but we're not directly importing a lot of the time.

jfecher · 2024-03-06T21:48:13Z

ItemVisibility? ImportVisibility works for me too

jfecher

LGTM

* master: chore: generalise `FunctionVisibility` to `ItemVisibility` (#4495) fix: Dynamic assert messages in brillig (#4531) chore: organize the `blackbox_solver` crate (#4519) fix(acir_gen): More granular element sizes array check (#4528) chore: Release Noir(0.25.0) (#4352) chore: document big integers (#4487) fix: Add `follow_bindings` to follow `Type::Alias` links (#4521) fix: Fix brillig slowdown when assigning arrays in loops (#4472) chore: Move `check_method_signatures` to type checking phase (#4516) chore(ci): fix JS publishing workflow checking out inconsistent commits (#4493) fix(ssa): Handle mergers of slices returned from calls (#4496) chore: Add HashMap docs (#4457) chore: custom hash for eddsa (#4440) chore: update various dependencies (#4513)

noir-lang/noir#4495) fix: Dynamic assert messages in brillig (noir-lang/noir#4531) chore: organize the `blackbox_solver` crate (noir-lang/noir#4519) fix(acir_gen): More granular element sizes array check (noir-lang/noir#4528) chore: Release Noir(0.25.0) (noir-lang/noir#4352) chore: document big integers (noir-lang/noir#4487) fix: Add `follow_bindings` to follow `Type::Alias` links (noir-lang/noir#4521) fix: Fix brillig slowdown when assigning arrays in loops (noir-lang/noir#4472) chore: Move `check_method_signatures` to type checking phase (noir-lang/noir#4516) chore(ci): fix JS publishing workflow checking out inconsistent commits (noir-lang/noir#4493) fix(ssa): Handle mergers of slices returned from calls (noir-lang/noir#4496) chore: Add HashMap docs (noir-lang/noir#4457) chore: custom hash for eddsa (noir-lang/noir#4440) chore: update various dependencies (noir-lang/noir#4513) fix: Allow type aliases in main (noir-lang/noir#4505) chore: add `ModuleDeclaration` struct (noir-lang/noir#4512) fix: Force src impl for == on slices (noir-lang/noir#4507) chore: pass `import_directive` by reference (noir-lang/noir#4511) feat: Track stack frames and their variables in the debugger (noir-lang/noir#4188) chore: add regression test for issue 4449 (noir-lang/noir#4503) chore: pass macro processors by reference (noir-lang/noir#4501) chore: bump bb to 0.26.3 (noir-lang/noir#4488) fix: handling of gh deps in noir_wasm (noir-lang/noir#4499) fix: iterative flattening pass (noir-lang/noir#4492) chore: Move templated code for assert_message into the stdlib (noir-lang/noir#4475) chore: pull out separate function for compiling and running a test chore: update cargo deny config (noir-lang/noir#4486) feat: run tests in parallel in `nargo test` (noir-lang/noir#4484)

…/noir#4495) fix: Dynamic assert messages in brillig (noir-lang/noir#4531) chore: organize the `blackbox_solver` crate (noir-lang/noir#4519) fix(acir_gen): More granular element sizes array check (noir-lang/noir#4528) chore: Release Noir(0.25.0) (noir-lang/noir#4352) chore: document big integers (noir-lang/noir#4487) fix: Add `follow_bindings` to follow `Type::Alias` links (noir-lang/noir#4521) fix: Fix brillig slowdown when assigning arrays in loops (noir-lang/noir#4472) chore: Move `check_method_signatures` to type checking phase (noir-lang/noir#4516) chore(ci): fix JS publishing workflow checking out inconsistent commits (noir-lang/noir#4493) fix(ssa): Handle mergers of slices returned from calls (noir-lang/noir#4496) chore: Add HashMap docs (noir-lang/noir#4457) chore: custom hash for eddsa (noir-lang/noir#4440) chore: update various dependencies (noir-lang/noir#4513) fix: Allow type aliases in main (noir-lang/noir#4505) chore: add `ModuleDeclaration` struct (noir-lang/noir#4512) fix: Force src impl for == on slices (noir-lang/noir#4507) chore: pass `import_directive` by reference (noir-lang/noir#4511) feat: Track stack frames and their variables in the debugger (noir-lang/noir#4188) chore: add regression test for issue 4449 (noir-lang/noir#4503) chore: pass macro processors by reference (noir-lang/noir#4501) chore: bump bb to 0.26.3 (noir-lang/noir#4488) fix: handling of gh deps in noir_wasm (noir-lang/noir#4499) fix: iterative flattening pass (noir-lang/noir#4492) chore: Move templated code for assert_message into the stdlib (noir-lang/noir#4475) chore: pull out separate function for compiling and running a test chore: update cargo deny config (noir-lang/noir#4486) feat: run tests in parallel in `nargo test` (noir-lang/noir#4484)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: generalise `FunctionVisibility` to `ItemVisibility` (noir-lang/noir#4495) fix: Dynamic assert messages in brillig (noir-lang/noir#4531) chore: organize the `blackbox_solver` crate (noir-lang/noir#4519) fix(acir_gen): More granular element sizes array check (noir-lang/noir#4528) chore: Release Noir(0.25.0) (noir-lang/noir#4352) chore: document big integers (noir-lang/noir#4487) fix: Add `follow_bindings` to follow `Type::Alias` links (noir-lang/noir#4521) fix: Fix brillig slowdown when assigning arrays in loops (noir-lang/noir#4472) chore: Move `check_method_signatures` to type checking phase (noir-lang/noir#4516) chore(ci): fix JS publishing workflow checking out inconsistent commits (noir-lang/noir#4493) fix(ssa): Handle mergers of slices returned from calls (noir-lang/noir#4496) chore: Add HashMap docs (noir-lang/noir#4457) chore: custom hash for eddsa (noir-lang/noir#4440) chore: update various dependencies (noir-lang/noir#4513) fix: Allow type aliases in main (noir-lang/noir#4505) chore: add `ModuleDeclaration` struct (noir-lang/noir#4512) fix: Force src impl for == on slices (noir-lang/noir#4507) chore: pass `import_directive` by reference (noir-lang/noir#4511) feat: Track stack frames and their variables in the debugger (noir-lang/noir#4188) chore: add regression test for issue 4449 (noir-lang/noir#4503) chore: pass macro processors by reference (noir-lang/noir#4501) chore: bump bb to 0.26.3 (noir-lang/noir#4488) fix: handling of gh deps in noir_wasm (noir-lang/noir#4499) fix: iterative flattening pass (noir-lang/noir#4492) chore: Move templated code for assert_message into the stdlib (noir-lang/noir#4475) chore: pull out separate function for compiling and running a test chore: update cargo deny config (noir-lang/noir#4486) feat: run tests in parallel in `nargo test` (noir-lang/noir#4484) END_COMMIT_OVERRIDE --------- Co-authored-by: TomAFrench <tom@tomfren.ch> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: generalise `FunctionVisibility` to `ItemVisibility` (#4495) fix: Dynamic assert messages in brillig (#4531) chore: organize the `blackbox_solver` crate (#4519) fix(acir_gen): More granular element sizes array check (#4528) chore: Release Noir(0.25.0) (#4352) chore: document big integers (#4487) fix: Add `follow_bindings` to follow `Type::Alias` links (#4521) fix: Fix brillig slowdown when assigning arrays in loops (#4472) chore: Move `check_method_signatures` to type checking phase (#4516) chore(ci): fix JS publishing workflow checking out inconsistent commits (#4493) fix(ssa): Handle mergers of slices returned from calls (#4496) chore: Add HashMap docs (#4457) chore: custom hash for eddsa (#4440) chore: update various dependencies (#4513) fix: Allow type aliases in main (#4505) chore: add `ModuleDeclaration` struct (#4512) fix: Force src impl for == on slices (#4507) chore: pass `import_directive` by reference (#4511) feat: Track stack frames and their variables in the debugger (#4188) chore: add regression test for issue 4449 (#4503) chore: pass macro processors by reference (#4501) chore: bump bb to 0.26.3 (#4488) fix: handling of gh deps in noir_wasm (#4499) fix: iterative flattening pass (#4492) chore: Move templated code for assert_message into the stdlib (#4475) chore: pull out separate function for compiling and running a test chore: update cargo deny config (#4486) feat: run tests in parallel in `nargo test` (#4484) END_COMMIT_OVERRIDE --------- Co-authored-by: TomAFrench <tom@tomfren.ch> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.27.2</summary> ## [0.27.2](aztec-package-v0.27.1...aztec-package-v0.27.2) (2024-03-13) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.27.2</summary> ## [0.27.2](barretenberg.js-v0.27.1...barretenberg.js-v0.27.2) (2024-03-13) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.27.2</summary> ## [0.27.2](aztec-cli-v0.27.1...aztec-cli-v0.27.2) (2024-03-13) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.27.2</summary> ## [0.27.2](aztec-packages-v0.27.1...aztec-packages-v0.27.2) (2024-03-13) ### Features * Check initialization arguments in constructors ([#5144](#5144)) ([d003bd6](d003bd6)) * Multithreaded prover folding ([#5147](#5147)) ([94922fc](94922fc)) * Run tests in parallel in `nargo test` (noir-lang/noir#4484) ([58e15ed](58e15ed)) * Track stack frames and their variables in the debugger (noir-lang/noir#4188) ([58e15ed](58e15ed)) ### Bug Fixes * **acir_gen:** More granular element sizes array check (noir-lang/noir#4528) ([58e15ed](58e15ed)) * Add `follow_bindings` to follow `Type::Alias` links (noir-lang/noir#4521) ([58e15ed](58e15ed)) * Allow type aliases in main (noir-lang/noir#4505) ([58e15ed](58e15ed)) * Constant gen ([#5172](#5172)) ([394a0e0](394a0e0)) * **docs:** Update quickstart.md ([#5021](#5021)) ([be9f8a1](be9f8a1)) * Dynamic assert messages in brillig (noir-lang/noir#4531) ([58e15ed](58e15ed)) * Fix brillig slowdown when assigning arrays in loops (noir-lang/noir#4472) ([58e15ed](58e15ed)) * Fix deployments ([#5183](#5183)) ([596253b](596253b)) * Force src impl for == on slices (noir-lang/noir#4507) ([58e15ed](58e15ed)) * Handling of gh deps in noir_wasm (noir-lang/noir#4499) ([58e15ed](58e15ed)) * Intermittent invert 0 in Goblin ([#5174](#5174)) ([3e68b49](3e68b49)) * Iterative flattening pass (noir-lang/noir#4492) ([58e15ed](58e15ed)) * Noir mirror merge strat ([#5166](#5166)) ([74fa8d6](74fa8d6)) * **ssa:** Handle mergers of slices returned from calls (noir-lang/noir#4496) ([58e15ed](58e15ed)) ### Miscellaneous * Add `ModuleDeclaration` struct (noir-lang/noir#4512) ([58e15ed](58e15ed)) * Add HashMap docs (noir-lang/noir#4457) ([58e15ed](58e15ed)) * Add regression test for issue 4449 (noir-lang/noir#4503) ([58e15ed](58e15ed)) * Better output in ci_deploy_contracts.sh ([#5171](#5171)) ([8d73f8a](8d73f8a)) * Bump bb to 0.26.3 (noir-lang/noir#4488) ([58e15ed](58e15ed)) * **ci:** Fix JS publishing workflow checking out inconsistent commits (noir-lang/noir#4493) ([58e15ed](58e15ed)) * Custom hash for eddsa (noir-lang/noir#4440) ([58e15ed](58e15ed)) * Deterministic mode ([#5155](#5155)) ([e68b56a](e68b56a)) * Document big integers (noir-lang/noir#4487) ([58e15ed](58e15ed)) * Generalise `FunctionVisibility` to `ItemVisibility` (noir-lang/noir#4495) ([58e15ed](58e15ed)) * Interaction for a mock first circuit handled inside the `EccOpQueue` ([#4854](#4854)) ([d9cbdc8](d9cbdc8)) * Move `check_method_signatures` to type checking phase (noir-lang/noir#4516) ([58e15ed](58e15ed)) * Move templated code for assert_message into the stdlib (noir-lang/noir#4475) ([58e15ed](58e15ed)) * Organize the `blackbox_solver` crate (noir-lang/noir#4519) ([58e15ed](58e15ed)) * Pass `import_directive` by reference (noir-lang/noir#4511) ([58e15ed](58e15ed)) * Pass macro processors by reference (noir-lang/noir#4501) ([58e15ed](58e15ed)) * Pull out separate function for compiling and running a test ([58e15ed](58e15ed)) * Release Noir(0.25.0) (noir-lang/noir#4352) ([58e15ed](58e15ed)) * Update cargo deny config (noir-lang/noir#4486) ([58e15ed](58e15ed)) * Update various dependencies (noir-lang/noir#4513) ([58e15ed](58e15ed)) </details> <details><summary>barretenberg: 0.27.2</summary> ## [0.27.2](barretenberg-v0.27.1...barretenberg-v0.27.2) (2024-03-13) ### Features * Multithreaded prover folding ([#5147](#5147)) ([94922fc](94922fc)) ### Bug Fixes * Intermittent invert 0 in Goblin ([#5174](#5174)) ([3e68b49](3e68b49)) ### Miscellaneous * Interaction for a mock first circuit handled inside the `EccOpQueue` ([#4854](#4854)) ([d9cbdc8](d9cbdc8)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* master: (48 commits) feat: Visible aliases for nargo commands (#4453) feat: Sync from aztec-packages (#4494) feat: Add checks for bit size consistency on brillig gen (#4542) fix: Allow non-integer globals to reference struct methods (#4490) chore: generalise `FunctionVisibility` to `ItemVisibility` (#4495) fix: Dynamic assert messages in brillig (#4531) chore: organize the `blackbox_solver` crate (#4519) fix(acir_gen): More granular element sizes array check (#4528) chore: Release Noir(0.25.0) (#4352) chore: document big integers (#4487) fix: Add `follow_bindings` to follow `Type::Alias` links (#4521) fix: Fix brillig slowdown when assigning arrays in loops (#4472) chore: Move `check_method_signatures` to type checking phase (#4516) chore(ci): fix JS publishing workflow checking out inconsistent commits (#4493) fix(ssa): Handle mergers of slices returned from calls (#4496) chore: Add HashMap docs (#4457) chore: custom hash for eddsa (#4440) chore: update various dependencies (#4513) fix: Allow type aliases in main (#4505) chore: add `ModuleDeclaration` struct (#4512) ...

* master: (36 commits) fix: Substitute generics when checking the field count of a type (#4547) feat: optimize sha2 implementation (#4441) chore: allow setting namespace visibility on functions (#4510) feat: Visible aliases for nargo commands (#4453) feat: Sync from aztec-packages (#4494) feat: Add checks for bit size consistency on brillig gen (#4542) fix: Allow non-integer globals to reference struct methods (#4490) chore: generalise `FunctionVisibility` to `ItemVisibility` (#4495) fix: Dynamic assert messages in brillig (#4531) chore: organize the `blackbox_solver` crate (#4519) fix(acir_gen): More granular element sizes array check (#4528) chore: Release Noir(0.25.0) (#4352) chore: document big integers (#4487) fix: Add `follow_bindings` to follow `Type::Alias` links (#4521) fix: Fix brillig slowdown when assigning arrays in loops (#4472) chore: Move `check_method_signatures` to type checking phase (#4516) chore(ci): fix JS publishing workflow checking out inconsistent commits (#4493) fix(ssa): Handle mergers of slices returned from calls (#4496) chore: Add HashMap docs (#4457) chore: custom hash for eddsa (#4440) ...

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.27.2</summary> ## [0.27.2](AztecProtocol/aztec-packages@aztec-package-v0.27.1...aztec-package-v0.27.2) (2024-03-13) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.27.2</summary> ## [0.27.2](AztecProtocol/aztec-packages@barretenberg.js-v0.27.1...barretenberg.js-v0.27.2) (2024-03-13) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.27.2</summary> ## [0.27.2](AztecProtocol/aztec-packages@aztec-cli-v0.27.1...aztec-cli-v0.27.2) (2024-03-13) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.27.2</summary> ## [0.27.2](AztecProtocol/aztec-packages@aztec-packages-v0.27.1...aztec-packages-v0.27.2) (2024-03-13) ### Features * Check initialization arguments in constructors ([#5144](AztecProtocol/aztec-packages#5144)) ([d003bd6](AztecProtocol/aztec-packages@d003bd6)) * Multithreaded prover folding ([#5147](AztecProtocol/aztec-packages#5147)) ([94922fc](AztecProtocol/aztec-packages@94922fc)) * Run tests in parallel in `nargo test` (noir-lang/noir#4484) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Track stack frames and their variables in the debugger (noir-lang/noir#4188) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) ### Bug Fixes * **acir_gen:** More granular element sizes array check (noir-lang/noir#4528) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Add `follow_bindings` to follow `Type::Alias` links (noir-lang/noir#4521) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Allow type aliases in main (noir-lang/noir#4505) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Constant gen ([#5172](AztecProtocol/aztec-packages#5172)) ([394a0e0](AztecProtocol/aztec-packages@394a0e0)) * **docs:** Update quickstart.md ([#5021](AztecProtocol/aztec-packages#5021)) ([be9f8a1](AztecProtocol/aztec-packages@be9f8a1)) * Dynamic assert messages in brillig (noir-lang/noir#4531) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Fix brillig slowdown when assigning arrays in loops (noir-lang/noir#4472) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Fix deployments ([#5183](AztecProtocol/aztec-packages#5183)) ([596253b](AztecProtocol/aztec-packages@596253b)) * Force src impl for == on slices (noir-lang/noir#4507) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Handling of gh deps in noir_wasm (noir-lang/noir#4499) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Intermittent invert 0 in Goblin ([#5174](AztecProtocol/aztec-packages#5174)) ([3e68b49](AztecProtocol/aztec-packages@3e68b49)) * Iterative flattening pass (noir-lang/noir#4492) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Noir mirror merge strat ([#5166](AztecProtocol/aztec-packages#5166)) ([74fa8d6](AztecProtocol/aztec-packages@74fa8d6)) * **ssa:** Handle mergers of slices returned from calls (noir-lang/noir#4496) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) ### Miscellaneous * Add `ModuleDeclaration` struct (noir-lang/noir#4512) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Add HashMap docs (noir-lang/noir#4457) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Add regression test for issue 4449 (noir-lang/noir#4503) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Better output in ci_deploy_contracts.sh ([#5171](AztecProtocol/aztec-packages#5171)) ([8d73f8a](AztecProtocol/aztec-packages@8d73f8a)) * Bump bb to 0.26.3 (noir-lang/noir#4488) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * **ci:** Fix JS publishing workflow checking out inconsistent commits (noir-lang/noir#4493) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Custom hash for eddsa (noir-lang/noir#4440) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Deterministic mode ([#5155](AztecProtocol/aztec-packages#5155)) ([e68b56a](AztecProtocol/aztec-packages@e68b56a)) * Document big integers (noir-lang/noir#4487) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Generalise `FunctionVisibility` to `ItemVisibility` (noir-lang/noir#4495) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Interaction for a mock first circuit handled inside the `EccOpQueue` ([#4854](AztecProtocol/aztec-packages#4854)) ([d9cbdc8](AztecProtocol/aztec-packages@d9cbdc8)) * Move `check_method_signatures` to type checking phase (noir-lang/noir#4516) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Move templated code for assert_message into the stdlib (noir-lang/noir#4475) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Organize the `blackbox_solver` crate (noir-lang/noir#4519) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Pass `import_directive` by reference (noir-lang/noir#4511) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Pass macro processors by reference (noir-lang/noir#4501) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Pull out separate function for compiling and running a test ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Release Noir(0.25.0) (noir-lang/noir#4352) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Update cargo deny config (noir-lang/noir#4486) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) * Update various dependencies (noir-lang/noir#4513) ([58e15ed](AztecProtocol/aztec-packages@58e15ed)) </details> <details><summary>barretenberg: 0.27.2</summary> ## [0.27.2](AztecProtocol/aztec-packages@barretenberg-v0.27.1...barretenberg-v0.27.2) (2024-03-13) ### Features * Multithreaded prover folding ([#5147](AztecProtocol/aztec-packages#5147)) ([94922fc](AztecProtocol/aztec-packages@94922fc)) ### Bug Fixes * Intermittent invert 0 in Goblin ([#5174](AztecProtocol/aztec-packages#5174)) ([3e68b49](AztecProtocol/aztec-packages@3e68b49)) ### Miscellaneous * Interaction for a mock first circuit handled inside the `EccOpQueue` ([#4854](AztecProtocol/aztec-packages#4854)) ([d9cbdc8](AztecProtocol/aztec-packages@d9cbdc8)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

chore: generalise FunctionVisibility to ModuleVisibility

f576639

TomAFrench requested a review from jfecher March 6, 2024 20:51

chore: fmt

052cba8

TomAFrench force-pushed the tf/replace-function-vis-with-module-vis branch from 9da5405 to 052cba8 Compare March 6, 2024 21:00

chore: replace ModuleVisibility withItemVisibility

1f01fe0

TomAFrench changed the title ~~chore: generalise FunctionVisibility to ModuleVisibility~~ chore: generalise FunctionVisibility to ItemVisibility Mar 6, 2024

TomAFrench added 4 commits March 7, 2024 22:04

Merge branch 'master' into tf/replace-function-vis-with-module-vis

ab6db60

Merge branch 'master' into tf/replace-function-vis-with-module-vis

480bd25

Merge branch 'master' into tf/replace-function-vis-with-module-vis

82ff498

Merge branch 'master' into tf/replace-function-vis-with-module-vis

3d0a854

TomAFrench requested a review from vezenovm March 11, 2024 23:06

jfecher approved these changes Mar 12, 2024

View reviewed changes

jfecher added this pull request to the merge queue Mar 12, 2024

Merged via the queue into master with commit 604ee8f Mar 12, 2024
43 checks passed

jfecher deleted the tf/replace-function-vis-with-module-vis branch March 12, 2024 13:39

AztecBot mentioned this pull request Mar 12, 2024

feat: Sync from noir AztecProtocol/aztec-packages#5134

Merged

AztecBot mentioned this pull request Mar 12, 2024

chore(master): Release 0.27.2 AztecProtocol/aztec-packages#5170

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: generalise `FunctionVisibility` to `ItemVisibility` #4495

chore: generalise `FunctionVisibility` to `ItemVisibility` #4495

TomAFrench commented Mar 6, 2024

jfecher commented Mar 6, 2024 •

edited

Loading

TomAFrench commented Mar 6, 2024

TomAFrench commented Mar 6, 2024

jfecher commented Mar 6, 2024

jfecher left a comment

chore: generalise FunctionVisibility to ItemVisibility #4495

chore: generalise FunctionVisibility to ItemVisibility #4495

Conversation

TomAFrench commented Mar 6, 2024

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

jfecher commented Mar 6, 2024 • edited Loading

TomAFrench commented Mar 6, 2024

TomAFrench commented Mar 6, 2024

jfecher commented Mar 6, 2024

jfecher left a comment

Choose a reason for hiding this comment

chore: generalise `FunctionVisibility` to `ItemVisibility` #4495

chore: generalise `FunctionVisibility` to `ItemVisibility` #4495

jfecher commented Mar 6, 2024 •

edited

Loading