fix: Fix canonicalization bug #6033

jfecher · 2024-09-13T15:58:41Z

Description

Problem*

Resolves #6032

Summary*

This issue was because when we sort commutative terms we sorted them in a BTreeSet, but this meant any identical terms were deduplicated. I changed it to keep track of how many of each term there was so that we don't accidentally change the expression when canonicalizing it.

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions · 2024-09-13T16:02:29Z

Changes to Brillig bytecode sizes

Generated at commit: 2d4d971c16fc484311eceae8613f42f775c8ce54, compared to commit: 57afc7ddd424220106af7b9c6e0715007f6ea8b8

There are no changes in circuit sizes

test_programs/compile_success_empty/arithmetic_generics/src/main.nr

asterite

LGTM

…ang/noir#6039) fix: Fix canonicalization bug (noir-lang/noir#6033) fix: Parse a statement as an expression (noir-lang/noir#6040) chore: rename CustomAtrribute to CustomAttribute (noir-lang/noir#6038) fix: error on `&mut x` when `x` is not mutable (noir-lang/noir#6037) feat: add `Expr::as_constructor` (noir-lang/noir#5980) chore: Fix docs (noir-lang/noir#6035) chore: document array methods (noir-lang/noir#6034)

fix: Fix canonicalization bug (noir-lang/noir#6033) fix: Parse a statement as an expression (noir-lang/noir#6040) chore: rename CustomAtrribute to CustomAttribute (noir-lang/noir#6038) fix: error on `&mut x` when `x` is not mutable (noir-lang/noir#6037) feat: add `Expr::as_constructor` (noir-lang/noir#5980) chore: Fix docs (noir-lang/noir#6035) chore: document array methods (noir-lang/noir#6034)

…ang/noir#6039) fix: Fix canonicalization bug (noir-lang/noir#6033) fix: Parse a statement as an expression (noir-lang/noir#6040) chore: rename CustomAtrribute to CustomAttribute (noir-lang/noir#6038) fix: error on `&mut x` when `x` is not mutable (noir-lang/noir#6037) feat: add `Expr::as_constructor` (noir-lang/noir#5980) chore: Fix docs (noir-lang/noir#6035) chore: document array methods (noir-lang/noir#6034)

fix: Fix canonicalization bug (noir-lang/noir#6033) fix: Parse a statement as an expression (noir-lang/noir#6040) chore: rename CustomAtrribute to CustomAttribute (noir-lang/noir#6038) fix: error on `&mut x` when `x` is not mutable (noir-lang/noir#6037) feat: add `Expr::as_constructor` (noir-lang/noir#5980) chore: Fix docs (noir-lang/noir#6035) chore: document array methods (noir-lang/noir#6034)

…oir-lang/noir#6051) feat(metaprogramming): Add `#[use_callers_scope]` (noir-lang/noir#6050) feat: show test output when running via LSP (noir-lang/noir#6049) feat: add `Expr::as_lambda` (noir-lang/noir#6048) feat: faster LSP by caching file managers (noir-lang/noir#6047) feat: implement `to_be_radix` in the comptime interpreter (noir-lang/noir#6043) fix: prevent check_can_mutate crashing on undefined variable (noir-lang/noir#6044) feat: add `Expr::as_for` and `Expr::as_for_range` (noir-lang/noir#6039) fix: Fix canonicalization bug (noir-lang/noir#6033) fix: Parse a statement as an expression (noir-lang/noir#6040) chore: rename CustomAtrribute to CustomAttribute (noir-lang/noir#6038) fix: error on `&mut x` when `x` is not mutable (noir-lang/noir#6037) feat: add `Expr::as_constructor` (noir-lang/noir#5980) chore: Fix docs (noir-lang/noir#6035) chore: document array methods (noir-lang/noir#6034)

…oir#6051) feat(metaprogramming): Add `#[use_callers_scope]` (noir-lang/noir#6050) feat: show test output when running via LSP (noir-lang/noir#6049) feat: add `Expr::as_lambda` (noir-lang/noir#6048) feat: faster LSP by caching file managers (noir-lang/noir#6047) feat: implement `to_be_radix` in the comptime interpreter (noir-lang/noir#6043) fix: prevent check_can_mutate crashing on undefined variable (noir-lang/noir#6044) feat: add `Expr::as_for` and `Expr::as_for_range` (noir-lang/noir#6039) fix: Fix canonicalization bug (noir-lang/noir#6033) fix: Parse a statement as an expression (noir-lang/noir#6040) chore: rename CustomAtrribute to CustomAttribute (noir-lang/noir#6038) fix: error on `&mut x` when `x` is not mutable (noir-lang/noir#6037) feat: add `Expr::as_constructor` (noir-lang/noir#5980) chore: Fix docs (noir-lang/noir#6035) chore: document array methods (noir-lang/noir#6034)

feat: allow visibility modifiers in struct definitions (noir-lang/noir#6054) fix: let LSP suggest fields and methods in LValue chains (noir-lang/noir#6051) feat(metaprogramming): Add `#[use_callers_scope]` (noir-lang/noir#6050) feat: show test output when running via LSP (noir-lang/noir#6049) feat: add `Expr::as_lambda` (noir-lang/noir#6048) feat: faster LSP by caching file managers (noir-lang/noir#6047) feat: implement `to_be_radix` in the comptime interpreter (noir-lang/noir#6043) fix: prevent check_can_mutate crashing on undefined variable (noir-lang/noir#6044) feat: add `Expr::as_for` and `Expr::as_for_range` (noir-lang/noir#6039) fix: Fix canonicalization bug (noir-lang/noir#6033) fix: Parse a statement as an expression (noir-lang/noir#6040) chore: rename CustomAtrribute to CustomAttribute (noir-lang/noir#6038) fix: error on `&mut x` when `x` is not mutable (noir-lang/noir#6037) feat: add `Expr::as_constructor` (noir-lang/noir#5980) chore: Fix docs (noir-lang/noir#6035) chore: document array methods (noir-lang/noir#6034)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: add `Expr::as_for` and `Expr::as_for_range` (noir-lang/noir#6039) fix: Fix canonicalization bug (noir-lang/noir#6033) fix: Parse a statement as an expression (noir-lang/noir#6040) chore: rename CustomAtrribute to CustomAttribute (noir-lang/noir#6038) fix: error on `&mut x` when `x` is not mutable (noir-lang/noir#6037) feat: add `Expr::as_constructor` (noir-lang/noir#5980) chore: Fix docs (noir-lang/noir#6035) chore: document array methods (noir-lang/noir#6034) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

:robot: I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.56.0</summary> ## [0.56.0](https://github.com/AztecProtocol/aztec-packages/compare/aztec-package-v0.55.1...aztec-package-v0.56.0) (2024-09-25) ### ⚠ BREAKING CHANGES * remove key registry ([#8613](https://github.com/AztecProtocol/aztec-packages/issues/8613)) ### Features * Remove key registry ([#8613](https://github.com/AztecProtocol/aztec-packages/issues/8613)) ([a668506](https://github.com/AztecProtocol/aztec-packages/commit/a6685067a0a5d17cbbc4cbfed4e78e364864ff51)) * Update rollup storage to hold pending/proven tips ([#8583](https://github.com/AztecProtocol/aztec-packages/issues/8583)) ([38e3051](https://github.com/AztecProtocol/aztec-packages/commit/38e3051d60f9f8a80e33fab4e0f7f3ec3cde2ee2)) </details> <details><summary>barretenberg.js: 0.56.0</summary> ## [0.56.0](https://github.com/AztecProtocol/aztec-packages/compare/barretenberg.js-v0.55.1...barretenberg.js-v0.56.0) (2024-09-25) ### Features * Use new IVC scheme ([#8480](https://github.com/AztecProtocol/aztec-packages/issues/8480)) ([1c7b06d](https://github.com/AztecProtocol/aztec-packages/commit/1c7b06d6621d9873f84147b2b7f1f22bf21bbacb)) ### Bug Fixes * Skip G1 SRS download if numPoints is zero ([#8717](https://github.com/AztecProtocol/aztec-packages/issues/8717)) ([753cdf8](https://github.com/AztecProtocol/aztec-packages/commit/753cdf8b047365b6280c0306fdc6f59f824f740b)) ### Miscellaneous * Migrate higher-level APIs for barretenberg to bb.js ([#8677](https://github.com/AztecProtocol/aztec-packages/issues/8677)) ([0237a20](https://github.com/AztecProtocol/aztec-packages/commit/0237a20c989f2b37a64ee18b41c1da361363a81f)) </details> <details><summary>aztec-packages: 0.56.0</summary> ## [0.56.0](https://github.com/AztecProtocol/aztec-packages/compare/aztec-packages-v0.55.1...aztec-packages-v0.56.0) (2024-09-25) ### ⚠ BREAKING CHANGES * make compute_nullifier_without_context unconstrained ([#8742](https://github.com/AztecProtocol/aztec-packages/issues/8742)) * remove PublicContextInputs ([#8770](https://github.com/AztecProtocol/aztec-packages/issues/8770)) * make TestEnvironment be unconstrained ([#8747](https://github.com/AztecProtocol/aztec-packages/issues/8747)) * change ec_add to unsafe implementation (but much better perf) ([#8374](https://github.com/AztecProtocol/aztec-packages/issues/8374)) * `aztec_macros` are dead, long live `aztec::macros` ([#8438](https://github.com/AztecProtocol/aztec-packages/issues/8438)) * **avm:** GETENVVAR + ISSTATICCALL ([#8692](https://github.com/AztecProtocol/aztec-packages/issues/8692)) * remove sha256 opcode ([#4571](https://github.com/AztecProtocol/aztec-packages/issues/4571)) * removing implicit numeric generics (https://github.com/noir-lang/noir/pull/5837) * Infer globals to be u32 when used in a type (https://github.com/noir-lang/noir/pull/6083) * add support for u1 in the avm, ToRadix's radix arg is a memory addr ([#8570](https://github.com/AztecProtocol/aztec-packages/issues/8570)) * remove key registry ([#8613](https://github.com/AztecProtocol/aztec-packages/issues/8613)) * **avm:** dont compress public bytecode ([#8623](https://github.com/AztecProtocol/aztec-packages/issues/8623)) * **avm:** remove tag in NOT ([#8606](https://github.com/AztecProtocol/aztec-packages/issues/8606)) ### Features * (LSP) if in runtime code, always suggest functions that return Quoted as macro calls (https://github.com/noir-lang/noir/pull/6098) ([7fb2a45](https://github.com/AztecProtocol/aztec-packages/commit/7fb2a454531db8cef757b5ec2028d97e823bef5f)) * (LSP) remove unused imports (https://github.com/noir-lang/noir/pull/6129) ([4522c4f](https://github.com/AztecProtocol/aztec-packages/commit/4522c4f428b288825013d7c38c5a4cbc5b8c8f58)) * (LSP) show global value on hover (https://github.com/noir-lang/noir/pull/6097) ([7fb2a45](https://github.com/AztecProtocol/aztec-packages/commit/7fb2a454531db8cef757b5ec2028d97e823bef5f)) * (LSP) suggest $vars inside `quote { ... }` (https://github.com/noir-lang/noir/pull/6114) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * `aztec_macros` are dead, long live `aztec::macros` ([#8438](https://github.com/AztecProtocol/aztec-packages/issues/8438)) ([7cbabd6](https://github.com/AztecProtocol/aztec-packages/commit/7cbabd6840ee8127c12a51a2342ef634f1d58954)) * Add `Expr::as_constructor` (https://github.com/noir-lang/noir/pull/5980) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * Add `Expr::as_for` and `Expr::as_for_range` (https://github.com/noir-lang/noir/pull/6039) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * Add `Expr::as_lambda` (https://github.com/noir-lang/noir/pull/6048) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * Add Aztec Bot to helm testnet package ([#8702](https://github.com/AztecProtocol/aztec-packages/issues/8702)) ([982a04e](https://github.com/AztecProtocol/aztec-packages/commit/982a04e8021ec88b178ea05fdebb7193998cde38)) * Add epochs to existing orchestrator ([#8675](https://github.com/AztecProtocol/aztec-packages/issues/8675)) ([0337fe9](https://github.com/AztecProtocol/aztec-packages/commit/0337fe9c2a7ac9f19fe8f695c7c072102dae9ec2)) * Add epochs to existing orchestrator v2 ([#8732](https://github.com/AztecProtocol/aztec-packages/issues/8732)) ([cec4d3f](https://github.com/AztecProtocol/aztec-packages/commit/cec4d3fedd5483cece5e53c0c1682d7a0b26f5fd)) * Add initial integration of databus ([#8710](https://github.com/AztecProtocol/aztec-packages/issues/8710)) ([779e104](https://github.com/AztecProtocol/aztec-packages/commit/779e10499cfe668506ba8a199342cf86fae258a7)) * Add peer scoring to req resp rate limits ([#8633](https://github.com/AztecProtocol/aztec-packages/issues/8633)) ([b015a79](https://github.com/AztecProtocol/aztec-packages/commit/b015a79560133d4bf842834066eb88bffba7cb7f)) * Add separate report for public function bytecode sizes ([#8750](https://github.com/AztecProtocol/aztec-packages/issues/8750)) ([d3c102f](https://github.com/AztecProtocol/aztec-packages/commit/d3c102f3c055e29c2beeb5ed81ac7b76b7135d25)) * Add support for u1 in the avm, ToRadix's radix arg is a memory addr ([#8570](https://github.com/AztecProtocol/aztec-packages/issues/8570)) ([1785737](https://github.com/AztecProtocol/aztec-packages/commit/178573738731e2e74e4119a035f913da39675d85)) * Add validation to request / response interactions + adjust scoring appropiately ([#8641](https://github.com/AztecProtocol/aztec-packages/issues/8641)) ([8dfdebc](https://github.com/AztecProtocol/aztec-packages/commit/8dfdebc7055ca89861a3727ea2d419fde98d6cf7)) * Aggregate honk and avm recursion constraints together ([#8696](https://github.com/AztecProtocol/aztec-packages/issues/8696)) ([3fa9e83](https://github.com/AztecProtocol/aztec-packages/commit/3fa9e83c0fac460f586572fe2866823fe7f740d2)) * Allow visibility modifiers in struct definitions (https://github.com/noir-lang/noir/pull/6054) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * **avm:** Avm recursive TS/Noir integration ([#8531](https://github.com/AztecProtocol/aztec-packages/issues/8531)) ([dd09f05](https://github.com/AztecProtocol/aztec-packages/commit/dd09f057e97ac1bba7b3fbf29b50737ebe5ca76f)), closes [#7791](https://github.com/AztecProtocol/aztec-packages/issues/7791) * **avm:** Avm recursive TS/Noir integration ([#8611](https://github.com/AztecProtocol/aztec-packages/issues/8611)) ([e417231](https://github.com/AztecProtocol/aztec-packages/commit/e4172318af81ac2ac8535c89d3e5afc72d33ba29)) * **avm:** Bounded mle implementation ([#8668](https://github.com/AztecProtocol/aztec-packages/issues/8668)) ([aa85f2a](https://github.com/AztecProtocol/aztec-packages/commit/aa85f2a781223f067291b5702f2e47baced865fd)), closes [#8651](https://github.com/AztecProtocol/aztec-packages/issues/8651) * **avm:** GETENVVAR + ISSTATICCALL ([#8692](https://github.com/AztecProtocol/aztec-packages/issues/8692)) ([02cff0b](https://github.com/AztecProtocol/aztec-packages/commit/02cff0b525d9d6b1c854219f06713a8b94a8e9f5)) * **avm:** Opcode STATICCALL - stubbed ([#8601](https://github.com/AztecProtocol/aztec-packages/issues/8601)) ([facff7f](https://github.com/AztecProtocol/aztec-packages/commit/facff7fd0b6ea57e91f7d3e3863435655d8b48ea)), closes [#8596](https://github.com/AztecProtocol/aztec-packages/issues/8596) * **avm:** Remove tag in NOT ([#8606](https://github.com/AztecProtocol/aztec-packages/issues/8606)) ([d5695fc](https://github.com/AztecProtocol/aztec-packages/commit/d5695fcde93cbfda3e45bfa03988a9e72f2dcb59)) * **avm:** Return oracle ([#8629](https://github.com/AztecProtocol/aztec-packages/issues/8629)) ([b6bc7c3](https://github.com/AztecProtocol/aztec-packages/commit/b6bc7c3f5064255480e3d4443471c2c50007d0ca)) * **avm:** Set avm circuit subgroup size ([#8537](https://github.com/AztecProtocol/aztec-packages/issues/8537)) ([3b78058](https://github.com/AztecProtocol/aztec-packages/commit/3b78058288edbbe18a2eb8c81de5576c8a9478ab)) * Benchmark compute_row_evaluations and update analysis script ([#8673](https://github.com/AztecProtocol/aztec-packages/issues/8673)) ([c738c47](https://github.com/AztecProtocol/aztec-packages/commit/c738c47bd13875ba1649d808e7abd2908fa29e07)) * Check unconstrained trait impl method matches (https://github.com/noir-lang/noir/pull/6057) ([3e0067a](https://github.com/AztecProtocol/aztec-packages/commit/3e0067a11935d4f2ead9579458d3c00c2f27f1ef)) * Compute args hash with comptime length ([#8736](https://github.com/AztecProtocol/aztec-packages/issues/8736)) ([dae82d8](https://github.com/AztecProtocol/aztec-packages/commit/dae82d84f95242ad7da1bf8e0c7e5063a35b1fef)) * Constant sized PG proofs and const sized PG rec verifier ([#8605](https://github.com/AztecProtocol/aztec-packages/issues/8605)) ([09e2f44](https://github.com/AztecProtocol/aztec-packages/commit/09e2f447b003ed4c77b12069893785851a2c6258)) * Do not double error on import with error (https://github.com/noir-lang/noir/pull/6131) ([0d9f547](https://github.com/AztecProtocol/aztec-packages/commit/0d9f547d4e470a1e5383c1fff4c0c6125169de19)) * **docs:** Getting started, portals page, some other nits ([#8515](https://github.com/AztecProtocol/aztec-packages/issues/8515)) ([9632e0d](https://github.com/AztecProtocol/aztec-packages/commit/9632e0dcf3c5b8966be0e1d02fa7ea9a5677af97)) * **docs:** Some small custom note stuff ([#8518](https://github.com/AztecProtocol/aztec-packages/issues/8518)) ([a098d41](https://github.com/AztecProtocol/aztec-packages/commit/a098d41ef0ba91beaf8b22a353bccd8e78bae5f5)) * EpochProofQuote implementation in TS ([#8689](https://github.com/AztecProtocol/aztec-packages/issues/8689)) ([1aad110](https://github.com/AztecProtocol/aztec-packages/commit/1aad110ba582599a69216dc0491f19b0df6dafea)) * Faster LSP by caching file managers (https://github.com/noir-lang/noir/pull/6047) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * Implement `to_be_radix` in the comptime interpreter (https://github.com/noir-lang/noir/pull/6043) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * Implement solver for mov_registers_to_registers (https://github.com/noir-lang/noir/pull/6089) ([03b9e71](https://github.com/AztecProtocol/aztec-packages/commit/03b9e71e5ebb3d46827671b2197697b5d294d04e)) * Implement type paths (https://github.com/noir-lang/noir/pull/6093) ([b330e87](https://github.com/AztecProtocol/aztec-packages/commit/b330e874dc11235eb9730aca7c936299378c9ce8)) * Let LSP suggest macro calls too (https://github.com/noir-lang/noir/pull/6090) ([b330e87](https://github.com/AztecProtocol/aztec-packages/commit/b330e874dc11235eb9730aca7c936299378c9ce8)) * Light block builder ([#8662](https://github.com/AztecProtocol/aztec-packages/issues/8662)) ([1e922a5](https://github.com/AztecProtocol/aztec-packages/commit/1e922a5a13bf3105e1317eda6d5536aa44a84b54)) * LSP autocompletion for `TypePath` (https://github.com/noir-lang/noir/pull/6117) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Make compute_nullifier_without_context unconstrained ([#8742](https://github.com/AztecProtocol/aztec-packages/issues/8742)) ([e30a743](https://github.com/AztecProtocol/aztec-packages/commit/e30a743d01ab190a1f7a677d2ae667f15c83d97f)) * Make TestEnvironment be unconstrained ([#8747](https://github.com/AztecProtocol/aztec-packages/issues/8747)) ([b9a1f59](https://github.com/AztecProtocol/aztec-packages/commit/b9a1f59a5343c8fa7caa957a5ebc3eb533a21c9c)) * Make UltraKeccak work with Shplemini at bb-level ([#8646](https://github.com/AztecProtocol/aztec-packages/issues/8646)) ([82b60eb](https://github.com/AztecProtocol/aztec-packages/commit/82b60ebbdb18400363248b80986c993df1b7e4af)) * **metaprogramming:** Add `#[use_callers_scope]` (https://github.com/noir-lang/noir/pull/6050) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * More robust recursion input generator ([#8634](https://github.com/AztecProtocol/aztec-packages/issues/8634)) ([020d4fd](https://github.com/AztecProtocol/aztec-packages/commit/020d4fd0cf4137e21f55b1c41e9e381a27191d84)) * Only download non-pruned blocks ([#8578](https://github.com/AztecProtocol/aztec-packages/issues/8578)) ([ae26474](https://github.com/AztecProtocol/aztec-packages/commit/ae26474709e28116a38fd2c2773de39dfb6816ad)) * Optimize constraints in sha256 (https://github.com/noir-lang/noir/pull/6145) ([0d9f547](https://github.com/AztecProtocol/aztec-packages/commit/0d9f547d4e470a1e5383c1fff4c0c6125169de19)) * Partial notes log encoding ([#8538](https://github.com/AztecProtocol/aztec-packages/issues/8538)) ([5f5ec20](https://github.com/AztecProtocol/aztec-packages/commit/5f5ec2099782a64160c7b06ce2021d28c264e7e9)) * **perf:** Allow array set last uses optimization in return block of Brillig functions (https://github.com/noir-lang/noir/pull/6119) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * **perf:** Remove unused loads in mem2reg and last stores per function (https://github.com/noir-lang/noir/pull/5925) ([3e0067a](https://github.com/AztecProtocol/aztec-packages/commit/3e0067a11935d4f2ead9579458d3c00c2f27f1ef)) * Pretty print Quoted token stream (https://github.com/noir-lang/noir/pull/6111) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Prune if needed ([#8617](https://github.com/AztecProtocol/aztec-packages/issues/8617)) ([49b17d0](https://github.com/AztecProtocol/aztec-packages/commit/49b17d0924fc3b11d0b2202cfc01d3dd4c18617a)), closes [#8608](https://github.com/AztecProtocol/aztec-packages/issues/8608) * Public kernel handles enqueued calls ([#8523](https://github.com/AztecProtocol/aztec-packages/issues/8523)) ([6303b4a](https://github.com/AztecProtocol/aztec-packages/commit/6303b4afbc39715e92d5ca7ae5100c60f6398686)) * Reduce max memory in translator by freeing accumulator and eccvm ([#8253](https://github.com/AztecProtocol/aztec-packages/issues/8253)) ([7247ddb](https://github.com/AztecProtocol/aztec-packages/commit/7247ddba274e691a7c5220848caf1fa9d6aa911e)) * Remove aztec macros (https://github.com/noir-lang/noir/pull/6087) ([0d9f547](https://github.com/AztecProtocol/aztec-packages/commit/0d9f547d4e470a1e5383c1fff4c0c6125169de19)) * Remove key registry ([#8613](https://github.com/AztecProtocol/aztec-packages/issues/8613)) ([a668506](https://github.com/AztecProtocol/aztec-packages/commit/a6685067a0a5d17cbbc4cbfed4e78e364864ff51)) * Remove sha256 opcode ([#4571](https://github.com/AztecProtocol/aztec-packages/issues/4571)) ([4b4a0bf](https://github.com/AztecProtocol/aztec-packages/commit/4b4a0bf17050893f913b3db10bc70a584b7aaa5e)) * Remove unnecessary branching in keccak impl (https://github.com/noir-lang/noir/pull/6133) ([0d9f547](https://github.com/AztecProtocol/aztec-packages/commit/0d9f547d4e470a1e5383c1fff4c0c6125169de19)) * Represent assertions more similarly to function calls (https://github.com/noir-lang/noir/pull/6103) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Show test output when running via LSP (https://github.com/noir-lang/noir/pull/6049) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * Swap endianness in-place in keccak implementation (https://github.com/noir-lang/noir/pull/6128) ([4522c4f](https://github.com/AztecProtocol/aztec-packages/commit/4522c4f428b288825013d7c38c5a4cbc5b8c8f58)) * Update rollup storage to hold pending/proven tips ([#8583](https://github.com/AztecProtocol/aztec-packages/issues/8583)) ([38e3051](https://github.com/AztecProtocol/aztec-packages/commit/38e3051d60f9f8a80e33fab4e0f7f3ec3cde2ee2)) * Use new IVC scheme ([#8480](https://github.com/AztecProtocol/aztec-packages/issues/8480)) ([1c7b06d](https://github.com/AztecProtocol/aztec-packages/commit/1c7b06d6621d9873f84147b2b7f1f22bf21bbacb)) * **vc:** Remove viem signers from validator client ([#8517](https://github.com/AztecProtocol/aztec-packages/issues/8517)) ([8244fa2](https://github.com/AztecProtocol/aztec-packages/commit/8244fa2d496975bb8bcc032690e0eab1b8c9548f)) * Visibility for traits (https://github.com/noir-lang/noir/pull/6056) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) ### Bug Fixes * Address a bunch of issues with generics ([#8625](https://github.com/AztecProtocol/aztec-packages/issues/8625)) ([94718f1](https://github.com/AztecProtocol/aztec-packages/commit/94718f1fbc26b165107872b2e32ba5412ba3b7fd)) * Allow macros to change types on each iteration of a comptime loop (https://github.com/noir-lang/noir/pull/6105) ([03b9e71](https://github.com/AztecProtocol/aztec-packages/commit/03b9e71e5ebb3d46827671b2197697b5d294d04e)) * Allow providing default implementations of unconstrained trait methods (https://github.com/noir-lang/noir/pull/6138) ([0d9f547](https://github.com/AztecProtocol/aztec-packages/commit/0d9f547d4e470a1e5383c1fff4c0c6125169de19)) * Always parse all tokens from quoted token streams (https://github.com/noir-lang/noir/pull/6064) ([3e0067a](https://github.com/AztecProtocol/aztec-packages/commit/3e0067a11935d4f2ead9579458d3c00c2f27f1ef)) * **avm:** Fix tests under proving ([#8640](https://github.com/AztecProtocol/aztec-packages/issues/8640)) ([8bfc769](https://github.com/AztecProtocol/aztec-packages/commit/8bfc769d7cbd6f88bfa7926c051a329ee0fd3468)) * Be more lenient with semicolons on interned expressions (https://github.com/noir-lang/noir/pull/6062) ([3e0067a](https://github.com/AztecProtocol/aztec-packages/commit/3e0067a11935d4f2ead9579458d3c00c2f27f1ef)) * Boomerang variable in sha256 hash function ([#8581](https://github.com/AztecProtocol/aztec-packages/issues/8581)) ([f2a1330](https://github.com/AztecProtocol/aztec-packages/commit/f2a13309f544bbd83b593e6a6207d49d9ef48b74)) * **ci:** Rerun.yml should not trigger if a commit has been pushed ([#8735](https://github.com/AztecProtocol/aztec-packages/issues/8735)) ([39fbf92](https://github.com/AztecProtocol/aztec-packages/commit/39fbf92a068be5f746b7cc379910c6af85f5e064)) * Consider constants as used values to keep their rc ops (https://github.com/noir-lang/noir/pull/6122) ([4522c4f](https://github.com/AztecProtocol/aztec-packages/commit/4522c4f428b288825013d7c38c5a4cbc5b8c8f58)) * Correct stack trace order in comptime assertion failures (https://github.com/noir-lang/noir/pull/6066) ([3e0067a](https://github.com/AztecProtocol/aztec-packages/commit/3e0067a11935d4f2ead9579458d3c00c2f27f1ef)) * Decode databus return values (https://github.com/noir-lang/noir/pull/6095) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Delete database file from disk on db.delete ([#8693](https://github.com/AztecProtocol/aztec-packages/issues/8693)) ([07d43ea](https://github.com/AztecProtocol/aztec-packages/commit/07d43ea77b57aba5d6edba56fe873b7dafd17e50)) * Delete temp lmdb stores + close db connection ([#8778](https://github.com/AztecProtocol/aztec-packages/issues/8778)) ([9321cbc](https://github.com/AztecProtocol/aztec-packages/commit/9321cbcf022994e5f8d41798d8c765490ab96824)) * Disambiguate field or int static trait method call (https://github.com/noir-lang/noir/pull/6112) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Do not prune if we are behind the assumed proven block ([#8744](https://github.com/AztecProtocol/aztec-packages/issues/8744)) ([e85bee5](https://github.com/AztecProtocol/aztec-packages/commit/e85bee5fb32057c8315593027417853cb4dfdcd5)) * **docs:** Simplify home page ([#8630](https://github.com/AztecProtocol/aztec-packages/issues/8630)) ([87e0a17](https://github.com/AztecProtocol/aztec-packages/commit/87e0a17db6c89a3a6e23fca3369c3bc5fe84ad3d)) * Don't crash on untyped global used as array length (https://github.com/noir-lang/noir/pull/6076) ([3e0067a](https://github.com/AztecProtocol/aztec-packages/commit/3e0067a11935d4f2ead9579458d3c00c2f27f1ef)) * Don't prune while proposing or proving. ([#8739](https://github.com/AztecProtocol/aztec-packages/issues/8739)) ([5854879](https://github.com/AztecProtocol/aztec-packages/commit/5854879f46f0f777dd986f1ba6adf6aa24abc683)) * Error on `&mut x` when `x` is not mutable (https://github.com/noir-lang/noir/pull/6037) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * Fix canonicalization bug (https://github.com/noir-lang/noir/pull/6033) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * Fix comptime type formatting (https://github.com/noir-lang/noir/pull/6079) ([3e0067a](https://github.com/AztecProtocol/aztec-packages/commit/3e0067a11935d4f2ead9579458d3c00c2f27f1ef)) * Fixes mapTuple typing ([#8615](https://github.com/AztecProtocol/aztec-packages/issues/8615)) ([25d5805](https://github.com/AztecProtocol/aztec-packages/commit/25d5805db1a2ccd0f06f14ab9a11a3fa455e5b69)) * Handle multi-byte utf8 characters in formatter (https://github.com/noir-lang/noir/pull/6118) ([0d9f547](https://github.com/AztecProtocol/aztec-packages/commit/0d9f547d4e470a1e5383c1fff4c0c6125169de19)) * Handle parenthesized expressions in array length (https://github.com/noir-lang/noir/pull/6132) ([4522c4f](https://github.com/AztecProtocol/aztec-packages/commit/4522c4f428b288825013d7c38c5a4cbc5b8c8f58)) * Infer globals to be u32 when used in a type (https://github.com/noir-lang/noir/pull/6083) ([3e0067a](https://github.com/AztecProtocol/aztec-packages/commit/3e0067a11935d4f2ead9579458d3c00c2f27f1ef)) * Initialise databus using return values (https://github.com/noir-lang/noir/pull/6074) ([b330e87](https://github.com/AztecProtocol/aztec-packages/commit/b330e874dc11235eb9730aca7c936299378c9ce8)) * Let LSP suggest fields and methods in LValue chains (https://github.com/noir-lang/noir/pull/6051) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * Let token pretty printer handle `+=` and similar token sequences (https://github.com/noir-lang/noir/pull/6135) ([0d9f547](https://github.com/AztecProtocol/aztec-packages/commit/0d9f547d4e470a1e5383c1fff4c0c6125169de19)) * **mem2reg:** Remove possibility of underflow (https://github.com/noir-lang/noir/pull/6107) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * New commit_sparse bug and new tests ([#8649](https://github.com/AztecProtocol/aztec-packages/issues/8649)) ([5818018](https://github.com/AztecProtocol/aztec-packages/commit/581801863529cd2b437cb51b041ada17a96949e0)) * Parse a statement as an expression (https://github.com/noir-lang/noir/pull/6040) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * Preserve generic kind on trait methods (https://github.com/noir-lang/noir/pull/6099) ([7fb2a45](https://github.com/AztecProtocol/aztec-packages/commit/7fb2a454531db8cef757b5ec2028d97e823bef5f)) * Prevent check_can_mutate crashing on undefined variable (https://github.com/noir-lang/noir/pull/6044) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * Quick TXE after public executor changes ([#8661](https://github.com/AztecProtocol/aztec-packages/issues/8661)) ([48a715b](https://github.com/AztecProtocol/aztec-packages/commit/48a715b6a11a07af7f9adce7a1049cf5e81a933d)) * **revert:** "chore!: change ec_add to unsafe implementation (but much better perf)" ([#8722](https://github.com/AztecProtocol/aztec-packages/issues/8722)) ([9a1b5b5](https://github.com/AztecProtocol/aztec-packages/commit/9a1b5b5fdd3194f4e7833aacbca4f48aadafbd74)) * **revert:** "feat: Add epochs to existing orchestrator" ([#8727](https://github.com/AztecProtocol/aztec-packages/issues/8727)) ([ff8e1ed](https://github.com/AztecProtocol/aztec-packages/commit/ff8e1edc5eae5d5a18d36cb960eb3d98afa1cfa6)) * Skip G1 SRS download if numPoints is zero ([#8717](https://github.com/AztecProtocol/aztec-packages/issues/8717)) ([753cdf8](https://github.com/AztecProtocol/aztec-packages/commit/753cdf8b047365b6280c0306fdc6f59f824f740b)) * **ssa:** RC correctness issue (https://github.com/noir-lang/noir/pull/6134) ([0d9f547](https://github.com/AztecProtocol/aztec-packages/commit/0d9f547d4e470a1e5383c1fff4c0c6125169de19)) * Unencryptedlogs witgen ([#8669](https://github.com/AztecProtocol/aztec-packages/issues/8669)) ([aee4c2d](https://github.com/AztecProtocol/aztec-packages/commit/aee4c2dde7576fad1c47e407ee0dca43dac2b1b4)) * Unify macro result type with actual type (https://github.com/noir-lang/noir/pull/6086) ([b330e87](https://github.com/AztecProtocol/aztec-packages/commit/b330e874dc11235eb9730aca7c936299378c9ce8)) * Update databus in flattening (https://github.com/noir-lang/noir/pull/6063) ([3e0067a](https://github.com/AztecProtocol/aztec-packages/commit/3e0067a11935d4f2ead9579458d3c00c2f27f1ef)) * **world_state:** Fix race conditions in WorldState and IndexedTree ([#8612](https://github.com/AztecProtocol/aztec-packages/issues/8612)) ([6797525](https://github.com/AztecProtocol/aztec-packages/commit/679752542edf1667d58e8839aca05d2b9fcc7da6)) ### Miscellaneous * Add more cases for assert_equal conversion ([#8446](https://github.com/AztecProtocol/aztec-packages/issues/8446)) ([e3ea298](https://github.com/AztecProtocol/aztec-packages/commit/e3ea298fd1f7326199e6e35b3523aadb2b12a925)) * Archiver cleanup ([#8599](https://github.com/AztecProtocol/aztec-packages/issues/8599)) ([184cc88](https://github.com/AztecProtocol/aztec-packages/commit/184cc882b3f1b90d74f149e46100474263a3665d)) * **avm:** Dont compress public bytecode ([#8623](https://github.com/AztecProtocol/aztec-packages/issues/8623)) ([353da3f](https://github.com/AztecProtocol/aztec-packages/commit/353da3f65e34783058d3ec7187dbe876f737b044)) * **avm:** Simplify bb-prover and other AVM tests ([#8627](https://github.com/AztecProtocol/aztec-packages/issues/8627)) ([0d75363](https://github.com/AztecProtocol/aztec-packages/commit/0d7536395f2406a22a76f15d01114730c84edc18)) * **avm:** Smaller skippable test ([#8664](https://github.com/AztecProtocol/aztec-packages/issues/8664)) ([2418977](https://github.com/AztecProtocol/aztec-packages/commit/241897733fe0a5e2ccdf322449debd367f458086)) * **bb readme:** Document how to Honk Noir programs ([#7638](https://github.com/AztecProtocol/aztec-packages/issues/7638)) ([cd46ddd](https://github.com/AztecProtocol/aztec-packages/commit/cd46ddd96539f2db466d1116dabdb838d2a807e7)) * Bye bye Zeromorph in Solidity ([#8678](https://github.com/AztecProtocol/aztec-packages/issues/8678)) ([74182c4](https://github.com/AztecProtocol/aztec-packages/commit/74182c40e152e988ee8590f39c51d00150ef01ca)) * Change ec_add to unsafe implementation (but much better perf) ([#8374](https://github.com/AztecProtocol/aztec-packages/issues/8374)) ([aabd2d8](https://github.com/AztecProtocol/aztec-packages/commit/aabd2d85d4f3f35d67d53421b47214aa8904c505)) * **ci:** Bump noir compile tests ([#8705](https://github.com/AztecProtocol/aztec-packages/issues/8705)) ([4121ef3](https://github.com/AztecProtocol/aztec-packages/commit/4121ef32d28ea8bf08b10f1bf1508daeef77e1a9)) * **ci:** Make boxes only run on master ([#8604](https://github.com/AztecProtocol/aztec-packages/issues/8604)) ([07e6a7e](https://github.com/AztecProtocol/aztec-packages/commit/07e6a7e36626f51f987fff1962903c86df34eb5b)) * **ci:** More lenient recovery ([#8462](https://github.com/AztecProtocol/aztec-packages/issues/8462)) ([5d9a2fe](https://github.com/AztecProtocol/aztec-packages/commit/5d9a2fee16b1229987f66070239196235dc10a83)) * **ci:** Reinstate a bunch of tests in e2e list ([#8737](https://github.com/AztecProtocol/aztec-packages/issues/8737)) ([226f311](https://github.com/AztecProtocol/aztec-packages/commit/226f31103b5e92017732bc1477733cd634dc1e9c)) * **ci:** Remove deleted e2e ([#8600](https://github.com/AztecProtocol/aztec-packages/issues/8600)) ([03127b2](https://github.com/AztecProtocol/aztec-packages/commit/03127b29c9bcad21ff35c14aecf9b2402faa20a5)) * **ci:** Remove e2e-prover-full from default set ([#8697](https://github.com/AztecProtocol/aztec-packages/issues/8697)) ([8dcc3bd](https://github.com/AztecProtocol/aztec-packages/commit/8dcc3bd3a678239b14a01da4d99f7c2e44030875)) * **ci:** Run noir-projects on txe changes ([#8660](https://github.com/AztecProtocol/aztec-packages/issues/8660)) ([22f6084](https://github.com/AztecProtocol/aztec-packages/commit/22f6084d6a5ff5693b72d2e08ac758472bb73e29)) * **ci:** Scriptify local earthfile ([#8709](https://github.com/AztecProtocol/aztec-packages/issues/8709)) ([aacd238](https://github.com/AztecProtocol/aztec-packages/commit/aacd2389d82ce8dfbd0604ecb095c95a400a1150)) * **ci:** Slightly safer default e2e jobs ([#8729](https://github.com/AztecProtocol/aztec-packages/issues/8729)) ([80acfd9](https://github.com/AztecProtocol/aztec-packages/commit/80acfd943ac3cd42b548043824f530018ac07a2d)) * Consolidate aztec node configurations (helm refactor) ([#8731](https://github.com/AztecProtocol/aztec-packages/issues/8731)) ([9d248a2](https://github.com/AztecProtocol/aztec-packages/commit/9d248a24091cfbf1c4d09b49227136883e6118f0)) * Create a Gemini prover ([#8622](https://github.com/AztecProtocol/aztec-packages/issues/8622)) ([94339fb](https://github.com/AztecProtocol/aztec-packages/commit/94339fbfc7c0c822dc1497c113d48f74a89f1bad)) * Delete .gitattributes in aztec-nr ([#8670](https://github.com/AztecProtocol/aztec-packages/issues/8670)) ([bc6d7ee](https://github.com/AztecProtocol/aztec-packages/commit/bc6d7ee9d6bc6f89100e52efd6cb6cc71664d12a)) * Delete duplicated test (https://github.com/noir-lang/noir/pull/6113) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Delete eth-log-hander ([#8598](https://github.com/AztecProtocol/aztec-packages/issues/8598)) ([4064e90](https://github.com/AztecProtocol/aztec-packages/commit/4064e90c7455d1f06590635678f0588706bce328)) * Delete poseidon2 from `bn254_blackbox_solver` ([#8741](https://github.com/AztecProtocol/aztec-packages/issues/8741)) ([02fea6a](https://github.com/AztecProtocol/aztec-packages/commit/02fea6abe8637b9fb8f9535d1709b367d5e1da5c)) * **docs:** Fix migration notes ([#8713](https://github.com/AztecProtocol/aztec-packages/issues/8713)) ([d5fd155](https://github.com/AztecProtocol/aztec-packages/commit/d5fd155ed14e2c9f7e889f519e7be791561a0e71)) * **docs:** Protocol-specs typos ([#8706](https://github.com/AztecProtocol/aztec-packages/issues/8706)) ([48de163](https://github.com/AztecProtocol/aztec-packages/commit/48de163a55bf792acca51a0df745fee44c7decf1)) * **docs:** Removing old versions (https://github.com/noir-lang/noir/pull/6075) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Document array methods (https://github.com/noir-lang/noir/pull/6034) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * Ec addition for non-zero points (https://github.com/noir-lang/noir/pull/5858) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Fix broken formatting on master (https://github.com/noir-lang/noir/pull/6096) ([7fb2a45](https://github.com/AztecProtocol/aztec-packages/commit/7fb2a454531db8cef757b5ec2028d97e823bef5f)) * Fix docs (https://github.com/noir-lang/noir/pull/6035) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * Fixing MacOS build - static_cast from field issue ([#8642](https://github.com/AztecProtocol/aztec-packages/issues/8642)) ([14ff3cf](https://github.com/AztecProtocol/aztec-packages/commit/14ff3cfb4291c288113695a3f2245340587fc8e9)) * Gas premiums for AVM side effects, DA gas in AVM ([#8632](https://github.com/AztecProtocol/aztec-packages/issues/8632)) ([d5f16cc](https://github.com/AztecProtocol/aztec-packages/commit/d5f16cc41bc077f24947fc92af2767630e928ed8)) * Make structs pub ([#8760](https://github.com/AztecProtocol/aztec-packages/issues/8760)) ([7bb2a38](https://github.com/AztecProtocol/aztec-packages/commit/7bb2a382e83bf422f90b3b144ae5c1d4e7adf227)) * Migrate higher-level APIs for barretenberg to bb.js ([#8677](https://github.com/AztecProtocol/aztec-packages/issues/8677)) ([0237a20](https://github.com/AztecProtocol/aztec-packages/commit/0237a20c989f2b37a64ee18b41c1da361363a81f)) * Misc cleanup ([#8748](https://github.com/AztecProtocol/aztec-packages/issues/8748)) ([e92da1f](https://github.com/AztecProtocol/aztec-packages/commit/e92da1f89974f8a51d491a0facc857fe774bf2fb)) * Protogalaxy recursive verifier matches native verifier ([#8568](https://github.com/AztecProtocol/aztec-packages/issues/8568)) ([a4f61b3](https://github.com/AztecProtocol/aztec-packages/commit/a4f61b39c39bf01a1071b52bbf042408f29d5564)) * Re-add blob library to CI ([#8734](https://github.com/AztecProtocol/aztec-packages/issues/8734)) ([4615fcc](https://github.com/AztecProtocol/aztec-packages/commit/4615fcc1c8b66d4ea71e0cd9c840656b152d05eb)) * Reduce redundant event fetching ([#8628](https://github.com/AztecProtocol/aztec-packages/issues/8628)) ([6903291](https://github.com/AztecProtocol/aztec-packages/commit/690329113876129fcdde52daf9f59f3dcad6949d)) * Reinstate skipped tests ([#8743](https://github.com/AztecProtocol/aztec-packages/issues/8743)) ([18e2697](https://github.com/AztecProtocol/aztec-packages/commit/18e2697d8791b4533e042ec04526e32922b608bc)) * Remove bubble_up_constrains (https://github.com/noir-lang/noir/pull/6127) ([4522c4f](https://github.com/AztecProtocol/aztec-packages/commit/4522c4f428b288825013d7c38c5a4cbc5b8c8f58)) * Remove creation of extra toml file in recursion inputs flow ([#8700](https://github.com/AztecProtocol/aztec-packages/issues/8700)) ([014bacc](https://github.com/AztecProtocol/aztec-packages/commit/014bacc0b2f1d56f416a3ab939b8aa5ad90656dd)) * Remove empty file ([#8724](https://github.com/AztecProtocol/aztec-packages/issues/8724)) ([d5b91b8](https://github.com/AztecProtocol/aztec-packages/commit/d5b91b8992c4c087991e824c9b3618476f83f13c)) * Remove key rotation from the key store ([#8645](https://github.com/AztecProtocol/aztec-packages/issues/8645)) ([d8bcb9f](https://github.com/AztecProtocol/aztec-packages/commit/d8bcb9f16537d5ec9c8f7a7f48efa3e6e767fa28)) * Remove multiple public dbs ([#8585](https://github.com/AztecProtocol/aztec-packages/issues/8585)) ([75b7b60](https://github.com/AztecProtocol/aztec-packages/commit/75b7b60456ded2c18f493aaa12306b49cc64ec21)) * Remove PublicContextInputs ([#8770](https://github.com/AztecProtocol/aztec-packages/issues/8770)) ([1507762](https://github.com/AztecProtocol/aztec-packages/commit/150776269b557703552826f90915c85adb639137)) * Remove special sync behaviour of `verify_honk_proof` ([#8676](https://github.com/AztecProtocol/aztec-packages/issues/8676)) ([a9e412b](https://github.com/AztecProtocol/aztec-packages/commit/a9e412bd49a8f0071906102eef07dd3248303443)) * Remove unnecessary `Prover.toml`s (https://github.com/noir-lang/noir/pull/6140) ([0d9f547](https://github.com/AztecProtocol/aztec-packages/commit/0d9f547d4e470a1e5383c1fff4c0c6125169de19)) * Remove unused imports ([#8766](https://github.com/AztecProtocol/aztec-packages/issues/8766)) ([420dd64](https://github.com/AztecProtocol/aztec-packages/commit/420dd642a4860e08b33b61e6bdd28efdc453ee6f)) * Remove unused TypeVariableKind::Constant (https://github.com/noir-lang/noir/pull/6053) ([3e0067a](https://github.com/AztecProtocol/aztec-packages/commit/3e0067a11935d4f2ead9579458d3c00c2f27f1ef)) * Removing implicit numeric generics (https://github.com/noir-lang/noir/pull/5837) ([3e0067a](https://github.com/AztecProtocol/aztec-packages/commit/3e0067a11935d4f2ead9579458d3c00c2f27f1ef)) * Rename CustomAtrribute to CustomAttribute (https://github.com/noir-lang/noir/pull/6038) ([7ea4709](https://github.com/AztecProtocol/aztec-packages/commit/7ea4709743aaaf2768d35d92cad3fbd4a8404fb0)) * Replace relative paths to noir-protocol-circuits ([00b1e61](https://github.com/AztecProtocol/aztec-packages/commit/00b1e61e4bda15aa456675f09129cd502438f823)) * Replace relative paths to noir-protocol-circuits ([d031f8f](https://github.com/AztecProtocol/aztec-packages/commit/d031f8fec1197b7abda8cfed07ed0797bee891d7)) * Replace relative paths to noir-protocol-circuits ([0f5dd09](https://github.com/AztecProtocol/aztec-packages/commit/0f5dd09b80cb5c6b5e7332520a0451863bc0e28a)) * Replace relative paths to noir-protocol-circuits ([755f484](https://github.com/AztecProtocol/aztec-packages/commit/755f48433df9f940ef472fc923be39576d3a8cfe)) * Replace relative paths to noir-protocol-circuits ([3d4e79a](https://github.com/AztecProtocol/aztec-packages/commit/3d4e79a3cad83b09f55d9ab503ab6b789892a66e)) * Replace relative paths to noir-protocol-circuits ([1bd828f](https://github.com/AztecProtocol/aztec-packages/commit/1bd828f57fea834d8a04e9261c92b2378c5c0fd5)) * Schnorr signature verification in Noir (https://github.com/noir-lang/noir/pull/5437) ([03b9e71](https://github.com/AztecProtocol/aztec-packages/commit/03b9e71e5ebb3d46827671b2197697b5d294d04e)) * Skip p2p integration ([#8779](https://github.com/AztecProtocol/aztec-packages/issues/8779)) ([48de45d](https://github.com/AztecProtocol/aztec-packages/commit/48de45de03b840e8c663f65af2ea866353eabb9b)) * Skip some tests in CI ([#8738](https://github.com/AztecProtocol/aztec-packages/issues/8738)) ([251db7b](https://github.com/AztecProtocol/aztec-packages/commit/251db7be2d7541852de314a13a85205b4b3a0418)) * Split `noirc_frontend/src/tests.rs` into submodules (https://github.com/noir-lang/noir/pull/6139) ([0d9f547](https://github.com/AztecProtocol/aztec-packages/commit/0d9f547d4e470a1e5383c1fff4c0c6125169de19)) * Use config object to make phase manager less noisy ([#8586](https://github.com/AztecProtocol/aztec-packages/issues/8586)) ([5a5f2b2](https://github.com/AztecProtocol/aztec-packages/commit/5a5f2b25c00aadd3fa014a81f21b5d01e83e360d)) * Use panic instead of assert ([#8703](https://github.com/AztecProtocol/aztec-packages/issues/8703)) ([c96d923](https://github.com/AztecProtocol/aztec-packages/commit/c96d923cd94503fc4c408fde3366c55778e37e82)) * Use random ports in p2p_client tests ([#8624](https://github.com/AztecProtocol/aztec-packages/issues/8624)) ([650a241](https://github.com/AztecProtocol/aztec-packages/commit/650a241faee7d2c9be5d0ea071b26b275fb09b39)) </details> <details><summary>barretenberg: 0.56.0</summary> ## [0.56.0](https://github.com/AztecProtocol/aztec-packages/compare/barretenberg-v0.55.1...barretenberg-v0.56.0) (2024-09-25) ### ⚠ BREAKING CHANGES * change ec_add to unsafe implementation (but much better perf) ([#8374](https://github.com/AztecProtocol/aztec-packages/issues/8374)) * **avm:** GETENVVAR + ISSTATICCALL ([#8692](https://github.com/AztecProtocol/aztec-packages/issues/8692)) * remove sha256 opcode ([#4571](https://github.com/AztecProtocol/aztec-packages/issues/4571)) * add support for u1 in the avm, ToRadix's radix arg is a memory addr ([#8570](https://github.com/AztecProtocol/aztec-packages/issues/8570)) * **avm:** remove tag in NOT ([#8606](https://github.com/AztecProtocol/aztec-packages/issues/8606)) ### Features * (LSP) suggest $vars inside `quote { ... }` (https://github.com/noir-lang/noir/pull/6114) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Add initial integration of databus ([#8710](https://github.com/AztecProtocol/aztec-packages/issues/8710)) ([779e104](https://github.com/AztecProtocol/aztec-packages/commit/779e10499cfe668506ba8a199342cf86fae258a7)) * Add support for u1 in the avm, ToRadix's radix arg is a memory addr ([#8570](https://github.com/AztecProtocol/aztec-packages/issues/8570)) ([1785737](https://github.com/AztecProtocol/aztec-packages/commit/178573738731e2e74e4119a035f913da39675d85)) * Aggregate honk and avm recursion constraints together ([#8696](https://github.com/AztecProtocol/aztec-packages/issues/8696)) ([3fa9e83](https://github.com/AztecProtocol/aztec-packages/commit/3fa9e83c0fac460f586572fe2866823fe7f740d2)) * **avm:** Avm recursive TS/Noir integration ([#8531](https://github.com/AztecProtocol/aztec-packages/issues/8531)) ([dd09f05](https://github.com/AztecProtocol/aztec-packages/commit/dd09f057e97ac1bba7b3fbf29b50737ebe5ca76f)), closes [#7791](https://github.com/AztecProtocol/aztec-packages/issues/7791) * **avm:** Avm recursive TS/Noir integration ([#8611](https://github.com/AztecProtocol/aztec-packages/issues/8611)) ([e417231](https://github.com/AztecProtocol/aztec-packages/commit/e4172318af81ac2ac8535c89d3e5afc72d33ba29)) * **avm:** Bounded mle implementation ([#8668](https://github.com/AztecProtocol/aztec-packages/issues/8668)) ([aa85f2a](https://github.com/AztecProtocol/aztec-packages/commit/aa85f2a781223f067291b5702f2e47baced865fd)), closes [#8651](https://github.com/AztecProtocol/aztec-packages/issues/8651) * **avm:** GETENVVAR + ISSTATICCALL ([#8692](https://github.com/AztecProtocol/aztec-packages/issues/8692)) ([02cff0b](https://github.com/AztecProtocol/aztec-packages/commit/02cff0b525d9d6b1c854219f06713a8b94a8e9f5)) * **avm:** Opcode STATICCALL - stubbed ([#8601](https://github.com/AztecProtocol/aztec-packages/issues/8601)) ([facff7f](https://github.com/AztecProtocol/aztec-packages/commit/facff7fd0b6ea57e91f7d3e3863435655d8b48ea)), closes [#8596](https://github.com/AztecProtocol/aztec-packages/issues/8596) * **avm:** Remove tag in NOT ([#8606](https://github.com/AztecProtocol/aztec-packages/issues/8606)) ([d5695fc](https://github.com/AztecProtocol/aztec-packages/commit/d5695fcde93cbfda3e45bfa03988a9e72f2dcb59)) * **avm:** Set avm circuit subgroup size ([#8537](https://github.com/AztecProtocol/aztec-packages/issues/8537)) ([3b78058](https://github.com/AztecProtocol/aztec-packages/commit/3b78058288edbbe18a2eb8c81de5576c8a9478ab)) * Benchmark compute_row_evaluations and update analysis script ([#8673](https://github.com/AztecProtocol/aztec-packages/issues/8673)) ([c738c47](https://github.com/AztecProtocol/aztec-packages/commit/c738c47bd13875ba1649d808e7abd2908fa29e07)) * Constant sized PG proofs and const sized PG rec verifier ([#8605](https://github.com/AztecProtocol/aztec-packages/issues/8605)) ([09e2f44](https://github.com/AztecProtocol/aztec-packages/commit/09e2f447b003ed4c77b12069893785851a2c6258)) * LSP autocompletion for `TypePath` (https://github.com/noir-lang/noir/pull/6117) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Make UltraKeccak work with Shplemini at bb-level ([#8646](https://github.com/AztecProtocol/aztec-packages/issues/8646)) ([82b60eb](https://github.com/AztecProtocol/aztec-packages/commit/82b60ebbdb18400363248b80986c993df1b7e4af)) * More robust recursion input generator ([#8634](https://github.com/AztecProtocol/aztec-packages/issues/8634)) ([020d4fd](https://github.com/AztecProtocol/aztec-packages/commit/020d4fd0cf4137e21f55b1c41e9e381a27191d84)) * **perf:** Allow array set last uses optimization in return block of Brillig functions (https://github.com/noir-lang/noir/pull/6119) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Pretty print Quoted token stream (https://github.com/noir-lang/noir/pull/6111) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Public kernel handles enqueued calls ([#8523](https://github.com/AztecProtocol/aztec-packages/issues/8523)) ([6303b4a](https://github.com/AztecProtocol/aztec-packages/commit/6303b4afbc39715e92d5ca7ae5100c60f6398686)) * Reduce max memory in translator by freeing accumulator and eccvm ([#8253](https://github.com/AztecProtocol/aztec-packages/issues/8253)) ([7247ddb](https://github.com/AztecProtocol/aztec-packages/commit/7247ddba274e691a7c5220848caf1fa9d6aa911e)) * Remove sha256 opcode ([#4571](https://github.com/AztecProtocol/aztec-packages/issues/4571)) ([4b4a0bf](https://github.com/AztecProtocol/aztec-packages/commit/4b4a0bf17050893f913b3db10bc70a584b7aaa5e)) * Represent assertions more similarly to function calls (https://github.com/noir-lang/noir/pull/6103) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Use new IVC scheme ([#8480](https://github.com/AztecProtocol/aztec-packages/issues/8480)) ([1c7b06d](https://github.com/AztecProtocol/aztec-packages/commit/1c7b06d6621d9873f84147b2b7f1f22bf21bbacb)) ### Bug Fixes * **avm:** Fix tests under proving ([#8640](https://github.com/AztecProtocol/aztec-packages/issues/8640)) ([8bfc769](https://github.com/AztecProtocol/aztec-packages/commit/8bfc769d7cbd6f88bfa7926c051a329ee0fd3468)) * Boomerang variable in sha256 hash function ([#8581](https://github.com/AztecProtocol/aztec-packages/issues/8581)) ([f2a1330](https://github.com/AztecProtocol/aztec-packages/commit/f2a13309f544bbd83b593e6a6207d49d9ef48b74)) * Decode databus return values (https://github.com/noir-lang/noir/pull/6095) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Disambiguate field or int static trait method call (https://github.com/noir-lang/noir/pull/6112) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * **mem2reg:** Remove possibility of underflow (https://github.com/noir-lang/noir/pull/6107) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * New commit_sparse bug and new tests ([#8649](https://github.com/AztecProtocol/aztec-packages/issues/8649)) ([5818018](https://github.com/AztecProtocol/aztec-packages/commit/581801863529cd2b437cb51b041ada17a96949e0)) * **revert:** "chore!: change ec_add to unsafe implementation (but much better perf)" ([#8722](https://github.com/AztecProtocol/aztec-packages/issues/8722)) ([9a1b5b5](https://github.com/AztecProtocol/aztec-packages/commit/9a1b5b5fdd3194f4e7833aacbca4f48aadafbd74)) * Unencryptedlogs witgen ([#8669](https://github.com/AztecProtocol/aztec-packages/issues/8669)) ([aee4c2d](https://github.com/AztecProtocol/aztec-packages/commit/aee4c2dde7576fad1c47e407ee0dca43dac2b1b4)) * **world_state:** Fix race conditions in WorldState and IndexedTree ([#8612](https://github.com/AztecProtocol/aztec-packages/issues/8612)) ([6797525](https://github.com/AztecProtocol/aztec-packages/commit/679752542edf1667d58e8839aca05d2b9fcc7da6)) ### Miscellaneous * Add more cases for assert_equal conversion ([#8446](https://github.com/AztecProtocol/aztec-packages/issues/8446)) ([e3ea298](https://github.com/AztecProtocol/aztec-packages/commit/e3ea298fd1f7326199e6e35b3523aadb2b12a925)) * **avm:** Simplify bb-prover and other AVM tests ([#8627](https://github.com/AztecProtocol/aztec-packages/issues/8627)) ([0d75363](https://github.com/AztecProtocol/aztec-packages/commit/0d7536395f2406a22a76f15d01114730c84edc18)) * **avm:** Smaller skippable test ([#8664](https://github.com/AztecProtocol/aztec-packages/issues/8664)) ([2418977](https://github.com/AztecProtocol/aztec-packages/commit/241897733fe0a5e2ccdf322449debd367f458086)) * **bb readme:** Document how to Honk Noir programs ([#7638](https://github.com/AztecProtocol/aztec-packages/issues/7638)) ([cd46ddd](https://github.com/AztecProtocol/aztec-packages/commit/cd46ddd96539f2db466d1116dabdb838d2a807e7)) * Bye bye Zeromorph in Solidity ([#8678](https://github.com/AztecProtocol/aztec-packages/issues/8678)) ([74182c4](https://github.com/AztecProtocol/aztec-packages/commit/74182c40e152e988ee8590f39c51d00150ef01ca)) * Change ec_add to unsafe implementation (but much better perf) ([#8374](https://github.com/AztecProtocol/aztec-packages/issues/8374)) ([aabd2d8](https://github.com/AztecProtocol/aztec-packages/commit/aabd2d85d4f3f35d67d53421b47214aa8904c505)) * Create a Gemini prover ([#8622](https://github.com/AztecProtocol/aztec-packages/issues/8622)) ([94339fb](https://github.com/AztecProtocol/aztec-packages/commit/94339fbfc7c0c822dc1497c113d48f74a89f1bad)) * Delete duplicated test (https://github.com/noir-lang/noir/pull/6113) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * **docs:** Removing old versions (https://github.com/noir-lang/noir/pull/6075) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Ec addition for non-zero points (https://github.com/noir-lang/noir/pull/5858) ([7a87314](https://github.com/AztecProtocol/aztec-packages/commit/7a873147444ef03bc1df88e0fdca3cf6fc124725)) * Fixing MacOS build - static_cast from field issue ([#8642](https://github.com/AztecProtocol/aztec-packages/issues/8642)) ([14ff3cf](https://github.com/AztecProtocol/aztec-packages/commit/14ff3cfb4291c288113695a3f2245340587fc8e9)) * Gas premiums for AVM side effects, DA gas in AVM ([#8632](https://github.com/AztecProtocol/aztec-packages/issues/8632)) ([d5f16cc](https://github.com/AztecProtocol/aztec-packages/commit/d5f16cc41bc077f24947fc92af2767630e928ed8)) * Migrate higher-level APIs for barretenberg to bb.js ([#8677](https://github.com/AztecProtocol/aztec-packages/issues/8677)) ([0237a20](https://github.com/AztecProtocol/aztec-packages/commit/0237a20c989f2b37a64ee18b41c1da361363a81f)) * Protogalaxy recursive verifier matches native verifier ([#8568](https://github.com/AztecProtocol/aztec-packages/issues/8568)) ([a4f61b3](https://github.com/AztecProtocol/aztec-packages/commit/a4f61b39c39bf01a1071b52bbf042408f29d5564)) * Reinstate skipped tests ([#8743](https://github.com/AztecProtocol/aztec-packages/issues/8743)) ([18e2697](https://github.com/AztecProtocol/aztec-packages/commit/18e2697d8791b4533e042ec04526e32922b608bc)) * Remove creation of extra toml file in recursion inputs flow ([#8700](https://github.com/AztecProtocol/aztec-packages/issues/8700)) ([014bacc](https://github.com/AztecProtocol/aztec-packages/commit/014bacc0b2f1d56f416a3ab939b8aa5ad90656dd)) * Skip some tests in CI ([#8738](https://github.com/AztecProtocol/aztec-packages/issues/8738)) ([251db7b](https://github.com/AztecProtocol/aztec-packages/commit/251db7be2d7541852de314a13a85205b4b3a0418)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>0.35.0</summary> ## [0.35.0](v0.34.0...v0.35.0) (2024-10-03) ### ⚠ BREAKING CHANGES * Syncing TypeVariableKind with Kind ([#6094](#6094)) * remove sha256 opcode (AztecProtocol/aztec-packages#4571) * add support for u1 in the avm, ToRadix's radix arg is a memory addr (AztecProtocol/aztec-packages#8570) * Infer globals to be u32 when used in a type ([#6083](#6083)) * removing implicit numeric generics ([#5837](#5837)) ### Features * (LSP) if in runtime code, always suggest functions that return Quoted as macro calls ([#6098](#6098)) ([4a160cb](4a160cb)) * (LSP) remove unused imports ([#6129](#6129)) ([98bc460](98bc460)) * (LSP) show global value on hover ([#6097](#6097)) ([3d9d072](3d9d072)) * (LSP) suggest $vars inside `quote { ... }` ([#6114](#6114)) ([73245b3](73245b3)) * Add `Expr::as_constructor` ([#5980](#5980)) ([76dea7b](76dea7b)) * Add `Expr::as_for` and `Expr::as_for_range` ([#6039](#6039)) ([abcae75](abcae75)) * Add `Expr::as_lambda` ([#6048](#6048)) ([31130dc](31130dc)) * Add a `comptime` string type for string handling at compile-time ([#6026](#6026)) ([5d2984f](5d2984f)) * Add support for u1 in the avm, ToRadix's radix arg is a memory addr (AztecProtocol/aztec-packages#8570) ([e8bbce7](e8bbce7)) * Allow silencing an unused variable defined via `let` ([#6149](#6149)) ([a2bc059](a2bc059)) * Allow visibility modifiers in struct definitions ([#6054](#6054)) ([199be58](199be58)) * Check unconstrained trait impl method matches ([#6057](#6057)) ([aedc983](aedc983)) * Default to outputting witness with file named after package ([#6031](#6031)) ([e74b4ae](e74b4ae)) * Detect unconstructed structs ([#6061](#6061)) ([bcb438b](bcb438b)) * Do not double error on import with error ([#6131](#6131)) ([9b26650](9b26650)) * Expose `derived_generators` and `pedersen_commitment_with_separator` from the stdlib ([#6154](#6154)) ([877b806](877b806)) * Faster LSP by caching file managers ([#6047](#6047)) ([c48a4f8](c48a4f8)) * Hoist constant allocation outside of loops ([#6158](#6158)) ([180bfc9](180bfc9)) * Implement `to_be_radix` in the comptime interpreter ([#6043](#6043)) ([1550278](1550278)) * Implement solver for mov_registers_to_registers ([#6089](#6089)) ([4170c55](4170c55)) * Implement type paths ([#6093](#6093)) ([2174ffb](2174ffb)) * Let `Module::functions` and `Module::structs` return them in definition order ([#6178](#6178)) ([dec9874](dec9874)) * Let LSP suggest macro calls too ([#6090](#6090)) ([26d275b](26d275b)) * Let LSP suggest trait impl methods as you are typing them ([#6029](#6029)) ([dfed81b](dfed81b)) * LSP autocompletion for `TypePath` ([#6117](#6117)) ([3f79d8f](3f79d8f)) * **metaprogramming:** Add `#[use_callers_scope]` ([#6050](#6050)) ([8c34046](8c34046)) * Optimize allocating immediate amounts of memory (AztecProtocol/aztec-packages#8579) ([e8bbce7](e8bbce7)) * Optimize constraints in sha256 ([#6145](#6145)) ([164d29e](164d29e)) * **perf:** Allow array set last uses optimization in return block of Brillig functions ([#6119](#6119)) ([5598059](5598059)) * **perf:** Handle array set optimization across blocks for Brillig functions ([#6153](#6153)) ([12cb80a](12cb80a)) * **perf:** Optimize array set from get ([#6207](#6207)) ([dfeb1c5](dfeb1c5)) * **perf:** Remove inc_rc instructions for arrays which are never mutably borrowed ([#6168](#6168)) ([a195442](a195442)) * **perf:** Remove redundant inc rc without instructions between ([#6183](#6183)) ([be9dcfe](be9dcfe)) * **perf:** Remove unused loads in mem2reg and last stores per function ([#5925](#5925)) ([19eef30](19eef30)) * **perf:** Remove useless paired RC instructions within a block during DIE ([#6160](#6160)) ([59c4118](59c4118)) * **perf:** Simplify the cfg after DIE ([#6184](#6184)) ([a1b5046](a1b5046)) * Pretty print Quoted token stream ([#6111](#6111)) ([cd81f85](cd81f85)) * Refactor SSA passes to run on individual functions ([#6072](#6072)) ([85c502c](85c502c)) * Remove aztec macros ([#6087](#6087)) ([9d96207](9d96207)) * Remove orphaned blocks from cfg to improve `simplify_cfg` pass. ([#6198](#6198)) ([b4712c5](b4712c5)) * Remove sha256 opcode (AztecProtocol/aztec-packages#4571) ([e8bbce7](e8bbce7)) * Remove unnecessary branching in keccak impl ([#6133](#6133)) ([9c69dce](9c69dce)) * Represent assertions more similarly to function calls ([#6103](#6103)) ([3ecd0e2](3ecd0e2)) * Show test output when running via LSP ([#6049](#6049)) ([9fb010e](9fb010e)) * Simplify sha256 implementation ([#6142](#6142)) ([acdfbbc](acdfbbc)) * Skip `remove_enable_side_effects` pass on brillig functions ([#6199](#6199)) ([2303615](2303615)) * **ssa:** Simplify signed casts ([#6166](#6166)) ([eec3a61](eec3a61)) * Swap endianness in-place in keccak implementation ([#6128](#6128)) ([e3cdebe](e3cdebe)) * Syncing TypeVariableKind with Kind ([#6094](#6094)) ([6440e18](6440e18)) * Visibility for globals ([#6161](#6161)) ([103b54d](103b54d)) * Visibility for modules ([#6165](#6165)) ([fcdbcb9](fcdbcb9)) * Visibility for traits ([#6056](#6056)) ([5bbd9ba](5bbd9ba)) * Visibility for type aliases ([#6058](#6058)) ([66d2a07](66d2a07)) ### Bug Fixes * (LSP) make goto and hover work well for attributes ([#6152](#6152)) ([c679bc6](c679bc6)) * Allow macros to change types on each iteration of a comptime loop ([#6105](#6105)) ([0864e7c](0864e7c)) * Allow providing default implementations of unconstrained trait methods ([#6138](#6138)) ([7679bbc](7679bbc)) * Always parse all tokens from quoted token streams ([#6064](#6064)) ([23ed74b](23ed74b)) * Be more lenient with semicolons on interned expressions ([#6062](#6062)) ([052c4fe](052c4fe)) * Consider constants as used values to keep their rc ops ([#6122](#6122)) ([1217005](1217005)) * Correct stack trace order in comptime assertion failures ([#6066](#6066)) ([04f1636](04f1636)) * Databus panic for fns with empty params (AztecProtocol/aztec-packages#8847) ([d252748](d252748)) * Decode databus return values ([#6095](#6095)) ([c40eb1f](c40eb1f)) * Disable side-effects for no_predicates functions ([#6027](#6027)) ([fc74c55](fc74c55)) * Disambiguate field or int static trait method call ([#6112](#6112)) ([5b27ea4](5b27ea4)) * Do not duplicate constant arrays in brillig ([#6155](#6155)) ([68f3022](68f3022)) * **docs:** Rename recursion.md to recursion.mdx ([#6195](#6195)) ([054e48b](054e48b)) * Don't crash on untyped global used as array length ([#6076](#6076)) ([426f295](426f295)) * Ensure to_bytes returns the canonical decomposition ([#6084](#6084)) ([b280a79](b280a79)) * Error on `&mut x` when `x` is not mutable ([#6037](#6037)) ([57afc7d](57afc7d)) * Fix canonicalization bug ([#6033](#6033)) ([7397772](7397772)) * Fix comptime type formatting ([#6079](#6079)) ([e678091](e678091)) * Handle multi-byte utf8 characters in formatter ([#6118](#6118)) ([b1d0619](b1d0619)) * Handle parenthesized expressions in array length ([#6132](#6132)) ([9f0b397](9f0b397)) * Ignore compression of blocks after msg.len in sha256_var ([#6206](#6206)) ([76eec71](76eec71)) * Infer globals to be u32 when used in a type ([#6083](#6083)) ([78262c9](78262c9)) * Initialise databus using return values ([#6074](#6074)) ([e17dfa5](e17dfa5)) * Let LSP suggest fields and methods in LValue chains ([#6051](#6051)) ([5bf6567](5bf6567)) * Let token pretty printer handle `+=` and similar token sequences ([#6135](#6135)) ([684b6cc](684b6cc)) * **mem2reg:** Remove possibility of underflow ([#6107](#6107)) ([aea5cc7](aea5cc7)) * Parse a statement as an expression ([#6040](#6040)) ([ab203e4](ab203e4)) * Pass radix directly to the blackbox ([#6164](#6164)) ([82b89c4](82b89c4)) * Preserve generic kind on trait methods ([#6099](#6099)) ([1df102a](1df102a)) * Prevent check_can_mutate crashing on undefined variable ([#6044](#6044)) ([b3accfc](b3accfc)) * Revert mistaken stack size change ([#6212](#6212)) ([a37117a](a37117a)) * **ssa:** Check if result of array set is used in value of another array set ([#6197](#6197)) ([594ec91](594ec91)) * **ssa:** RC correctness issue ([#6134](#6134)) ([5b1c896](5b1c896)) * Type variables by default should have Any kind ([#6203](#6203)) ([268f2a0](268f2a0)) * Unify macro result type with actual type ([#6086](#6086)) ([af52873](af52873)) * Update databus in flattening ([#6063](#6063)) ([e993da1](e993da1)) ### Miscellaneous Chores * Removing implicit numeric generics ([#5837](#5837)) ([eda9043](eda9043)) </details> <details><summary>0.51.0</summary> ## [0.51.0](v0.50.0...v0.51.0) (2024-10-03) ### ⚠ BREAKING CHANGES * remove sha256 opcode (AztecProtocol/aztec-packages#4571) * add support for u1 in the avm, ToRadix's radix arg is a memory addr (AztecProtocol/aztec-packages#8570) * Add Not instruction in brillig (AztecProtocol/aztec-packages#8488) * **avm:** variants for SET opcode (AztecProtocol/aztec-packages#8441) * **avm/brillig:** take addresses in calldatacopy (AztecProtocol/aztec-packages#8388) * constant inputs for blackbox (AztecProtocol/aztec-packages#7222) ### Features * (bb) 128-bit challenges (AztecProtocol/aztec-packages#8406) ([3c3ed1e](3c3ed1e)) * **acir_gen:** Width aware ACIR gen addition ([#5493](#5493)) ([85fa592](85fa592)) * Add assertions for ACVM `FunctionInput` `bit_size` ([#5864](#5864)) ([8712f4c](8712f4c)) * Add Not instruction in brillig (AztecProtocol/aztec-packages#8488) ([95e19ab](95e19ab)) * Add recursive aggregation object to proving/verification keys (AztecProtocol/aztec-packages#6770) ([4ea25db](4ea25db)) * Add reusable procedures to brillig generation (AztecProtocol/aztec-packages#7981) ([5c4f19f](5c4f19f)) * Add support for u1 in the avm, ToRadix's radix arg is a memory addr (AztecProtocol/aztec-packages#8570) ([e8bbce7](e8bbce7)) * Added indirect const instruction (AztecProtocol/aztec-packages#8065) ([5c4f19f](5c4f19f)) * Adding aggregation to honk and rollup (AztecProtocol/aztec-packages#7466) ([4ea25db](4ea25db)) * Automate verify_honk_proof input generation (AztecProtocol/aztec-packages#8092) ([5c4f19f](5c4f19f)) * **avm/brillig:** Take addresses in calldatacopy (AztecProtocol/aztec-packages#8388) ([3c3ed1e](3c3ed1e)) * **avm:** Variants for SET opcode (AztecProtocol/aztec-packages#8441) ([3c3ed1e](3c3ed1e)) * Avoid heap allocs when going to/from field (AztecProtocol/aztec-packages#7547) ([daad75c](daad75c)) * Change the layout of arrays and vectors to be a single pointer (AztecProtocol/aztec-packages#8448) ([d4832ec](d4832ec)) * Constant inputs for blackbox (AztecProtocol/aztec-packages#7222) ([fb97bb9](fb97bb9)) * Hook up secondary calldata column in dsl (AztecProtocol/aztec-packages#7759) ([4ea25db](4ea25db)) * Integrate new proving systems in e2e (AztecProtocol/aztec-packages#6971) ([daad75c](daad75c)) * Make Brillig do integer arithmetic operations using u128 instead of Bigint (AztecProtocol/aztec-packages#7518) ([daad75c](daad75c)) * Make token transfer be recursive (AztecProtocol/aztec-packages#7730) ([4ea25db](4ea25db)) * New test programs for wasm benchmarking (AztecProtocol/aztec-packages#8389) ([95e19ab](95e19ab)) * Note hashes as points (AztecProtocol/aztec-packages#7618) ([4ea25db](4ea25db)) * Optimize allocating immediate amounts of memory (AztecProtocol/aztec-packages#8579) ([e8bbce7](e8bbce7)) * Optimize constant array handling in brillig_gen (AztecProtocol/aztec-packages#7661) ([4ea25db](4ea25db)) * Optimize to_radix (AztecProtocol/aztec-packages#8073) ([5c4f19f](5c4f19f)) * Pass calldata ids to the backend (AztecProtocol/aztec-packages#7875) ([4ea25db](4ea25db)) * Poseidon2 gates for Ultra arithmetisation (AztecProtocol/aztec-packages#7494) ([5c4f19f](5c4f19f)) * **profiler:** Add support for brillig functions in opcodes-flamegraph (AztecProtocol/aztec-packages#7698) ([4ea25db](4ea25db)) * Remove sha256 opcode (AztecProtocol/aztec-packages#4571) ([e8bbce7](e8bbce7)) * Removing superfluous call to MSM (AztecProtocol/aztec-packages#7708) ([4ea25db](4ea25db)) * Report gates and VKs of private protocol circuits with megahonk (AztecProtocol/aztec-packages#7722) ([4ea25db](4ea25db)) * Simplify constant calls to `poseidon2_permutation`, `schnorr_verify` and `embedded_curve_add` ([#5140](#5140)) ([2823ba7](2823ba7)) * Small optimization in toradix (AztecProtocol/aztec-packages#8040) ([5c4f19f](5c4f19f)) * Sync from noir (AztecProtocol/aztec-packages#7392) ([fb97bb9](fb97bb9)) * Sync from noir (AztecProtocol/aztec-packages#7400) ([fb97bb9](fb97bb9)) * Sync from noir (AztecProtocol/aztec-packages#7432) ([daad75c](daad75c)) * Sync from noir (AztecProtocol/aztec-packages#7444) ([daad75c](daad75c)) * Sync from noir (AztecProtocol/aztec-packages#7454) ([daad75c](daad75c)) * Sync from noir (AztecProtocol/aztec-packages#7512) ([daad75c](daad75c)) * Sync from noir (AztecProtocol/aztec-packages#7577) ([daad75c](daad75c)) * Sync from noir (AztecProtocol/aztec-packages#7583) ([daad75c](daad75c)) * Sync from noir (AztecProtocol/aztec-packages#7743) ([4ea25db](4ea25db)) * Sync from noir (AztecProtocol/aztec-packages#7862) ([4ea25db](4ea25db)) * Sync from noir (AztecProtocol/aztec-packages#7945) ([4ea25db](4ea25db)) * Sync from noir (AztecProtocol/aztec-packages#7958) ([5c4f19f](5c4f19f)) * Sync from noir (AztecProtocol/aztec-packages#8008) ([5c4f19f](5c4f19f)) * Sync from noir (AztecProtocol/aztec-packages#8093) ([5c4f19f](5c4f19f)) * Sync from noir (AztecProtocol/aztec-packages#8125) ([f0c2686](f0c2686)) * Sync from noir (AztecProtocol/aztec-packages#8237) ([f0c2686](f0c2686)) * Sync from noir (AztecProtocol/aztec-packages#8423) ([3c3ed1e](3c3ed1e)) * Sync from noir (AztecProtocol/aztec-packages#8435) ([3c3ed1e](3c3ed1e)) * Sync from noir (AztecProtocol/aztec-packages#8466) ([3c3ed1e](3c3ed1e)) * Sync from noir (AztecProtocol/aztec-packages#8482) ([d4832ec](d4832ec)) * Sync from noir (AztecProtocol/aztec-packages#8512) ([95e19ab](95e19ab)) * Sync from noir (AztecProtocol/aztec-packages#8526) ([95e19ab](95e19ab)) * TXE nr deployments, dependency cleanup for CLI (AztecProtocol/aztec-packages#7548) ([4ea25db](4ea25db)) * Typing return values of embedded_curve_ops (AztecProtocol/aztec-packages#7413) ([daad75c](daad75c)) * Unify all acir recursion constraints based on RecursionConstraint and proof_type (AztecProtocol/aztec-packages#7993) ([5c4f19f](5c4f19f)) ### Bug Fixes * Add trailing extra arguments for backend in gates_flamegraph (AztecProtocol/aztec-packages#7472) ([daad75c](daad75c)) * **debugger:** Update the debugger to handle the new Brillig debug metadata format ([#5706](#5706)) ([a31f82e](a31f82e)) * Deflatten databus visibilities (AztecProtocol/aztec-packages#7761) ([4ea25db](4ea25db)) * Do not duplicate redundant Brillig debug metadata ([#5696](#5696)) ([e4f7dbe](e4f7dbe)) * Export brillig names in contract functions (AztecProtocol/aztec-packages#8212) ([f0c2686](f0c2686)) * Handle multiple entry points for Brillig call stack resolution after metadata deduplication ([#5788](#5788)) ([38fe9dd](38fe9dd)) * Move BigInt modulus checks to runtime in brillig ([#5374](#5374)) ([741d339](741d339)) * Restrict keccak256_injective test input to 8 bits ([#5977](#5977)) ([a1b1346](a1b1346)) * Revert "feat: Sync from noir (AztecProtocol/aztec-packages#7512)" (AztecProtocol/aztec-packages#7558) ([daad75c](daad75c)) * Runtime brillig bigint id assignment ([#5369](#5369)) ([a8928dd](a8928dd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Fix canonicalization bug

c7fda32

jfecher requested a review from a team September 13, 2024 15:58

TomAFrench changed the title ~~Fix canonicalization bug~~ fix: Fix canonicalization bug Sep 13, 2024

Disable test

e159ed5

jfecher commented Sep 13, 2024

View reviewed changes

test_programs/compile_success_empty/arithmetic_generics/src/main.nr Show resolved Hide resolved

Merge branch 'master' into jf/fix-canonicalization

5d963fd

asterite approved these changes Sep 13, 2024

View reviewed changes

jfecher added this pull request to the merge queue Sep 13, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 13, 2024

jfecher added this pull request to the merge queue Sep 13, 2024

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 13, 2024

Merge branch 'master' into jf/fix-canonicalization

909873a

jfecher enabled auto-merge September 13, 2024 19:40

jfecher added this pull request to the merge queue Sep 13, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 13, 2024

jfecher added this pull request to the merge queue Sep 13, 2024

Merged via the queue into master with commit 7397772 Sep 13, 2024
46 checks passed

jfecher deleted the jf/fix-canonicalization branch September 13, 2024 20:24

noirwhal mentioned this pull request Sep 13, 2024

chore: Release Noir(0.35.0) #6030

Merged

AztecBot mentioned this pull request Sep 14, 2024

feat: Sync from noir AztecProtocol/aztec-packages#8543

Merged

AztecBot mentioned this pull request Sep 17, 2024

chore(master): Release 0.56.0 AztecProtocol/aztec-packages#8597

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fix canonicalization bug #6033

fix: Fix canonicalization bug #6033

jfecher commented Sep 13, 2024

github-actions bot commented Sep 13, 2024 •

edited

Loading

asterite left a comment

fix: Fix canonicalization bug #6033

fix: Fix canonicalization bug #6033

Conversation

jfecher commented Sep 13, 2024

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

github-actions bot commented Sep 13, 2024 • edited Loading

Changes to Brillig bytecode sizes

There are no changes in circuit sizes

asterite left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 13, 2024 •

edited

Loading