Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Update gates diff action to not post Brillig sizes report with no changes #6157

Merged
merged 3 commits into from
Sep 26, 2024
Merged

chore(ci): Update gates diff action to not post Brillig sizes report with no changes #6157

merged 3 commits into from
Sep 26, 2024
+1 −1

Conversation

vezenovm
Copy link
Contributor

…mment when not needed

Description

Problem*

Resolves

No issue as found while making the public functions size report on aztec-packages.

Summary*

We currently repost the Brillig opcode report even when there have been no changes. This updates the noir-gates-diff to the most recent commit on the noir-gates-diff main branch which has the fix.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm vezenovm requested review from TomAFrench and a team September 26, 2024 15:25
@vezenovm
Copy link
Contributor Author

Oops I only updated gates_report.yml and not gates_report_brillig.yml. Should be good now.

@TomAFrench TomAFrench added this pull request to the merge queue Sep 26, 2024
Merged via the queue into master with commit 742e8ae Sep 26, 2024
47 checks passed
@TomAFrench TomAFrench deleted the mv/update-gates-diff-action branch September 26, 2024 16:55
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Sep 27, 2024
@AztecBot
[1 changes] chore: enable tests on aztec-nr and contracts (noir-lang/…
3f4047e 
…noir#6162)

feat(perf): Handle array set optimization across blocks for Brillig functions (noir-lang/noir#6153)
feat: visibility for globals (noir-lang/noir#6161)
feat(perf): Remove useless paired RC instructions within a block during DIE (noir-lang/noir#6160)
chore: deprecate various items in stdlib (noir-lang/noir#6156)
feat: Hoist constant allocation outside of loops (noir-lang/noir#6158)
chore(ci): Update gates diff action to not post Brillig sizes report with no changes (noir-lang/noir#6157)
fix: Do not duplicate constant arrays in brillig (noir-lang/noir#6155)
feat: detect unconstructed structs (noir-lang/noir#6061)
fix: (LSP) make goto and hover work well for attributes (noir-lang/noir#6152)
feat: visibility for type aliases (noir-lang/noir#6058)
feat: Sync from aztec-packages (noir-lang/noir#6151)
feat: allow silencing an unused variable defined via `let` (noir-lang/noir#6149)
feat: simplify sha256 implementation (noir-lang/noir#6142)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Sep 27, 2024
@AztecBot
chore: enable tests on aztec-nr and contracts (noir-lang/noir#6162)
6c52f83 
feat(perf): Handle array set optimization across blocks for Brillig functions (noir-lang/noir#6153)
feat: visibility for globals (noir-lang/noir#6161)
feat(perf): Remove useless paired RC instructions within a block during DIE (noir-lang/noir#6160)
chore: deprecate various items in stdlib (noir-lang/noir#6156)
feat: Hoist constant allocation outside of loops (noir-lang/noir#6158)
chore(ci): Update gates diff action to not post Brillig sizes report with no changes (noir-lang/noir#6157)
fix: Do not duplicate constant arrays in brillig (noir-lang/noir#6155)
feat: detect unconstructed structs (noir-lang/noir#6061)
fix: (LSP) make goto and hover work well for attributes (noir-lang/noir#6152)
feat: visibility for type aliases (noir-lang/noir#6058)
feat: Sync from aztec-packages (noir-lang/noir#6151)
feat: allow silencing an unused variable defined via `let` (noir-lang/noir#6149)
feat: simplify sha256 implementation (noir-lang/noir#6142)
@AztecBot AztecBot mentioned this pull request Sep 27, 2024
Merged
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Sep 27, 2024
@AztecBot
[1 changes] feat: expose derived_generators and `pedersen_commitmen…
e57f897 
…t_with_separator` from the stdlib (noir-lang/noir#6154)

fix: Pass radix directly to the blackbox (noir-lang/noir#6164)
chore: enable tests on aztec-nr and contracts (noir-lang/noir#6162)
feat(perf): Handle array set optimization across blocks for Brillig functions (noir-lang/noir#6153)
feat: visibility for globals (noir-lang/noir#6161)
feat(perf): Remove useless paired RC instructions within a block during DIE (noir-lang/noir#6160)
chore: deprecate various items in stdlib (noir-lang/noir#6156)
feat: Hoist constant allocation outside of loops (noir-lang/noir#6158)
chore(ci): Update gates diff action to not post Brillig sizes report with no changes (noir-lang/noir#6157)
fix: Do not duplicate constant arrays in brillig (noir-lang/noir#6155)
feat: detect unconstructed structs (noir-lang/noir#6061)
fix: (LSP) make goto and hover work well for attributes (noir-lang/noir#6152)
feat: visibility for type aliases (noir-lang/noir#6058)
feat: Sync from aztec-packages (noir-lang/noir#6151)
feat: allow silencing an unused variable defined via `let` (noir-lang/noir#6149)
feat: simplify sha256 implementation (noir-lang/noir#6142)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Sep 27, 2024
@AztecBot
feat: expose derived_generators and `pedersen_commitment_with_separ…
4c6240e 
…ator` from the stdlib (noir-lang/noir#6154)

fix: Pass radix directly to the blackbox (noir-lang/noir#6164)
chore: enable tests on aztec-nr and contracts (noir-lang/noir#6162)
feat(perf): Handle array set optimization across blocks for Brillig functions (noir-lang/noir#6153)
feat: visibility for globals (noir-lang/noir#6161)
feat(perf): Remove useless paired RC instructions within a block during DIE (noir-lang/noir#6160)
chore: deprecate various items in stdlib (noir-lang/noir#6156)
feat: Hoist constant allocation outside of loops (noir-lang/noir#6158)
chore(ci): Update gates diff action to not post Brillig sizes report with no changes (noir-lang/noir#6157)
fix: Do not duplicate constant arrays in brillig (noir-lang/noir#6155)
feat: detect unconstructed structs (noir-lang/noir#6061)
fix: (LSP) make goto and hover work well for attributes (noir-lang/noir#6152)
feat: visibility for type aliases (noir-lang/noir#6058)
feat: Sync from aztec-packages (noir-lang/noir#6151)
feat: allow silencing an unused variable defined via `let` (noir-lang/noir#6149)
feat: simplify sha256 implementation (noir-lang/noir#6142)
vezenovm pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Sep 27, 2024
@AztecBot @nventuro
@TomAFrench @sirasistant
feat: Sync from noir (#8792)
6bd5b7e 
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat: expose `derived_generators` and
`pedersen_commitment_with_separator` from the stdlib
(noir-lang/noir#6154)
fix: Pass radix directly to the blackbox
(noir-lang/noir#6164)
chore: enable tests on aztec-nr and contracts
(noir-lang/noir#6162)
feat(perf): Handle array set optimization across blocks for Brillig
functions (noir-lang/noir#6153)
feat: visibility for globals
(noir-lang/noir#6161)
feat(perf): Remove useless paired RC instructions within a block during
DIE (noir-lang/noir#6160)
chore: deprecate various items in stdlib
(noir-lang/noir#6156)
feat: Hoist constant allocation outside of loops
(noir-lang/noir#6158)
chore(ci): Update gates diff action to not post Brillig sizes report
with no changes (noir-lang/noir#6157)
fix: Do not duplicate constant arrays in brillig
(noir-lang/noir#6155)
feat: detect unconstructed structs
(noir-lang/noir#6061)
fix: (LSP) make goto and hover work well for attributes
(noir-lang/noir#6152)
feat: visibility for type aliases
(noir-lang/noir#6058)
feat: Sync from aztec-packages
(noir-lang/noir#6151)
feat: allow silencing an unused variable defined via `let`
(noir-lang/noir#6149)
feat: simplify sha256 implementation
(noir-lang/noir#6142)
END_COMMIT_OVERRIDE

---------

Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <tom@tomfren.ch>
Co-authored-by: sirasistant <sirasistant@gmail.com>
@AztecBot AztecBot mentioned this pull request Sep 27, 2024
Open
Rumata888 pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Sep 27, 2024
@AztecBot @nventuro
@TomAFrench @sirasistant @Rumata888
feat: Sync from noir (#8792)
79f5b40 
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat: expose `derived_generators` and
`pedersen_commitment_with_separator` from the stdlib
(noir-lang/noir#6154)
fix: Pass radix directly to the blackbox
(noir-lang/noir#6164)
chore: enable tests on aztec-nr and contracts
(noir-lang/noir#6162)
feat(perf): Handle array set optimization across blocks for Brillig
functions (noir-lang/noir#6153)
feat: visibility for globals
(noir-lang/noir#6161)
feat(perf): Remove useless paired RC instructions within a block during
DIE (noir-lang/noir#6160)
chore: deprecate various items in stdlib
(noir-lang/noir#6156)
feat: Hoist constant allocation outside of loops
(noir-lang/noir#6158)
chore(ci): Update gates diff action to not post Brillig sizes report
with no changes (noir-lang/noir#6157)
fix: Do not duplicate constant arrays in brillig
(noir-lang/noir#6155)
feat: detect unconstructed structs
(noir-lang/noir#6061)
fix: (LSP) make goto and hover work well for attributes
(noir-lang/noir#6152)
feat: visibility for type aliases
(noir-lang/noir#6058)
feat: Sync from aztec-packages
(noir-lang/noir#6151)
feat: allow silencing an unused variable defined via `let`
(noir-lang/noir#6149)
feat: simplify sha256 implementation
(noir-lang/noir#6142)
END_COMMIT_OVERRIDE

---------

Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <tom@tomfren.ch>
Co-authored-by: sirasistant <sirasistant@gmail.com>
Rumata888 pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Sep 27, 2024
@AztecBot @nventuro
@TomAFrench @sirasistant @Rumata888
feat: Sync from noir (#8792)
c23c351 
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat: expose `derived_generators` and
`pedersen_commitment_with_separator` from the stdlib
(noir-lang/noir#6154)
fix: Pass radix directly to the blackbox
(noir-lang/noir#6164)
chore: enable tests on aztec-nr and contracts
(noir-lang/noir#6162)
feat(perf): Handle array set optimization across blocks for Brillig
functions (noir-lang/noir#6153)
feat: visibility for globals
(noir-lang/noir#6161)
feat(perf): Remove useless paired RC instructions within a block during
DIE (noir-lang/noir#6160)
chore: deprecate various items in stdlib
(noir-lang/noir#6156)
feat: Hoist constant allocation outside of loops
(noir-lang/noir#6158)
chore(ci): Update gates diff action to not post Brillig sizes report
with no changes (noir-lang/noir#6157)
fix: Do not duplicate constant arrays in brillig
(noir-lang/noir#6155)
feat: detect unconstructed structs
(noir-lang/noir#6061)
fix: (LSP) make goto and hover work well for attributes
(noir-lang/noir#6152)
feat: visibility for type aliases
(noir-lang/noir#6058)
feat: Sync from aztec-packages
(noir-lang/noir#6151)
feat: allow silencing an unused variable defined via `let`
(noir-lang/noir#6149)
feat: simplify sha256 implementation
(noir-lang/noir#6142)
END_COMMIT_OVERRIDE

---------

Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <tom@tomfren.ch>
Co-authored-by: sirasistant <sirasistant@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vezenovm @TomAFrench