Add option to always expand posts marked with content warnings #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! |
|
And no, you don't need to add it elsewhere. The other ones will just default to English. |
nolanlawson
approved these changes
Jan 8, 2023
Great, thanks! |
|
Sorry, but CI appears to be broken right now. #2349 . I would prefer to get tests passing before merging any PR |
Makes sense - take as long as you need. It looks at first glance to be all unrelated to my PR, but if I have broken anything then please let me know and I'll fix it! |
|
It looks like there is a small bug with this:
It should collapse on the first try. I'll look at it. |
nolanlawson
reviewed
Jan 9, 2023
|
Fixed it and added a test to confirm the fix: 04388ff |
nolanlawson
reviewed
Jan 9, 2023
nolanlawson
reviewed
Jan 9, 2023
alice-werefox
pushed a commit
to alice-werefox/sema-werefox-cafe
that referenced
this pull request
Apr 3, 2023
…olanlawson#2342) Co-authored-by: Nolan Lawson <nolan@nolanlawson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to always expand posts marked with content warnings. If the option is enabled, posts with content warnings are expanded by default, but can be closed using the "show less" button as usual.
This adds a new intl key. I wasn't sure whether the correct approach was just to add the key to en_US or to add it (untranslated) to every language; I've just done the former for now, but if it does need to be added untranslated to every language please let me know and I'll do so.
Fixes #1997.