Move most of APIClient interface to its promise chain #6022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nb-ohad
force-pushed
the
ohad-leaner-api-client
branch
from
7b3f98f
to
0b3caf3
Compare
guymguym
reviewed
May 18, 2020
nb-ohad
force-pushed
the
ohad-leaner-api-client
branch
from
c77b7c7
to
81ab0bd
Compare
guymguym
reviewed
May 18, 2020
guymguym
reviewed
May 18, 2020
nb-ohad
force-pushed
the
ohad-leaner-api-client
branch
2 times, most recently
from
3ee014c
to
b8aee35
Compare
guymguym
approved these changes
May 19, 2020
|
@nb-ohad Can you squash your commits? |
This change will decrease the size of an APiClient object to an object with a 2 fields an rpc reference and the options for the client. The interface objects (which contain the method declaration) will be generated on the fly on each access and will consist of a single field named `client` that point back to the client that created them. The methods themselves are now implemented on the prototype of each API object. A side effect of this change is that we cannot pass an API method directly as a callback because it loses its context. A workaround is to pass an arrow function that preserves the context. See the changes to node.n2n_singal as an example.
nb-ohad
force-pushed
the
ohad-leaner-api-client
branch
from
b8aee35
to
6343cf1
Compare
This was referenced Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This change will decrease the size of an APiClient object to an object with a single field named
options.The interface objects (which contain the method declaration) will be generated on the fly on each access and will consist of a single field named
clientthat point back to the client that created them.The methods themselves are not implemented on the prototype of each API object.
A side effect of this change is that we cannot pass an API method directly as a callback because it loses its context. A workaround is to pass an arrow function that preserves the context as I did for node.n2n_signal
This PR is an alternative to the solution presented in PR #6017